Skip to content

Miguel comments - #58

Merged
ryan-odea merged 7 commits into
mainfrom
devel-09072026-odea
Jul 10, 2026
Merged

Miguel comments#58
ryan-odea merged 7 commits into
mainfrom
devel-09072026-odea

Conversation

@ryan-odea

@ryan-odearyan-odea commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This PR just addresses some comments from Miguel:

  • Removes 'nested' since trials may not need to be nested (harmonizes with the R version)
  • Changes @remlapmot to second author (and enforced through a CITATION.cff)

You may want to check your affiliation!

@ryan-odea
ryan-odea requested a review from remlapmotJuly 9, 2026 18:27
remlapmot
remlapmot reviewed Jul 10, 2026
View reviewed changes
Comment threadCITATION.cff Outdated
remlapmot
remlapmot reviewed Jul 10, 2026
View reviewed changes
Comment threadCITATION.cff Outdated
remlapmot
remlapmot reviewed Jul 10, 2026
View reviewed changes
Comment threadCITATION.cff Outdated
remlapmot
remlapmot reviewed Jul 10, 2026
View reviewed changes
Comment threadCITATION.cff Outdated
remlapmot
remlapmot requested changes Jul 10, 2026
View reviewed changes

@remlapmotremlapmot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ryan

Just need to collapse those multiple affiliation lines into one for each author.

ryan-odeaand others added 4 commits July 10, 2026 09:57
@ryan-odea@remlapmot
Update CITATION.cff
188c7d6
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
@ryan-odea@remlapmot
Update CITATION.cff
4148bcd
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
@ryan-odea@remlapmot
Update CITATION.cff
497851f
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
@ryan-odea@remlapmot
Update CITATION.cff
6e7c387
Co-authored-by: Tom Palmer <remlapmot@hotmail.com>
@ryan-odea

ryan-odea commented Jul 10, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Thanks Ryan

Just need to collapse those multiple affiliation lines into one for each author.

Sounds good, just accepted all of your suggestions!

remlapmot
remlapmot approved these changes Jul 10, 2026
View reviewed changes

@remlapmotremlapmot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryan-odea
ryan-odea merged commit fca0b64 into mainJul 10, 2026
6 checks passed
@ryan-odea
ryan-odea deleted the devel-09072026-odea branch July 10, 2026 08:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remlapmotremlapmotremlapmot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryan-odea@remlapmot