Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement a scalable (multi indexing pipeline) nats source and implement a drain mechanism in the indexing pipeline.
Rationale
Nats does not support partitioned consumers, for this reason it is impossible to name a partition/consumer in a consumer group to reference it as a partition in Quickwit (
PartitionId). Consumer groups are entirely dynamic in nats (no rebalancing, no static mechanism) and there is no other way to have this feature.From this first issue, two solutions were considered:
AckPolicy. And acknowledge insuggest_truncate, but in order to strenghten the pipeline in case of rolling out indexer we also need a drain mechanism so a source can gracefully acknowledge even when the pipeline is shutting down.Side notes
Other source implementation could benefit from this drain mechanism like gcp pubsub.