fix: use scrollHeight for PNG export so legend is never cut - #1675
Open
Flotapponnier wants to merge 5 commits into
Open
fix: use scrollHeight for PNG export so legend is never cut#1675Flotapponnier wants to merge 5 commits into
Flotapponnier wants to merge 5 commits into
Conversation
- Limit inline labels to top 10 non-excluded lines (legend shows all) - Collision deflection: sort labels by Y, push each down until clear of previous - Increase padR 96→130 so label text never gets clipped by SVG viewport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
html-to-image defaults to offsetHeight (visible height), which clips the legend when it wraps into many rows (100+ providers). Passing scrollHeight/scrollWidth captures the full content regardless of scroll position.