fix: mobile overflow on benchmark detail pages - #236
Merged
Conversation
- Tables (ledger, region-grid): min-w only applies from sm: so mobile
shrinks the table inside its overflow-x-auto wrapper instead of
forcing 480/520px and pushing the whole page past the viewport edge
- count-leaderboard summary strip stacks 1-col on mobile, reduces
gap-x so 'RANGE 40 → 306 7 providers' no longer cuts off
- summary-stat removes the 8rem min-width on mobile flex children
- breadcrumb + bench identifier lower tracking on mobile, last crumb
truncates at 60vw so long titles can't push the row off-screen
- Title + subtitle get break-words as safety net
- html { overflow-x: clip } as a final root-level safety netUh oh!
There was an error while loading. Please reload this page.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sur iPhone (375-414px), les pages /benchmarks/[slug] avaient tout le contenu qui sortait du viewport à droite : breadcrumb, titre, paragraphe, et la ligne LEADER/RANGE/GAP. Cause racine : plusieurs composants forcent une largeur minimum en px supérieure au viewport.
Fixes (par cause racine, pas en band-aid)
overflow-x: clip sur html (pas hidden) ne crée pas de scroll container, donc le position: sticky du header continue de marcher. C'est le filet, pas la solution : les vrais fix sont les min-w responsive.
Test plan