Skip to content

chart: top-N selector for crowded cohorts#257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jun 2, 2026
Merged

chart: top-N selector for crowded cohorts #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion src/components/time-series-chart.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ export function TimeSeriesChart({
// `excluded` flag drives both opacity (CSS fade-out) and Y-axis math
// (excluded values are dropped from min/max so the remaining lines
// can spread out vertically when an outlier is hidden).
const lines = useMemo(() => {
const allLines = useMemo(() => {
const built = benchmark.results
.map((r) => ({
slug: r.slug,
Expand All@@ -138,6 +138,16 @@ export function TimeSeriesChart({
return built;
}, [benchmark, range, region, colors, excluded, seriesOverride]);

// Top-N selector. When the cohort grows past ~20 series the chart
// becomes visually noisy and the legend wraps to multiple lines.
// null = show all; number = clip to the top N by recent mean.
const TOP_N_DEFAULT = allLines.length > 20 ? 20 : null;
const [topN, setTopN] = useState<number | null>(TOP_N_DEFAULT);
const lines = useMemo(() => {
if (topN == null) return allLines;
return allLines.slice(0, topN);
}, [allLines, topN]);

// A key that flips when the data shape changes. used to retrigger
// the line-draw animation.
const seriesKey = `${range}::${region}::${metricLabelOverride ?? "default"}`;
Expand DownExpand Up@@ -251,6 +261,33 @@ export function TimeSeriesChart({
))}
</div>
)}

{allLines.length > 10 && (
<div className="flex items-center gap-1">
<span className="mr-2 text-[10px] uppercase tracking-[0.16em] text-ink-faint">
Show
</span>
{([5, 10, 20, null] as const).map((n) => {
const active = topN === n;
const label = n == null ? "All" : `Top ${n}`;
return (
<button
key={String(n)}
type="button"
onClick={() => setTopN(n)}
className={`rounded-md border px-2 py-1 text-[11px] font-sans font-medium uppercase tracking-[0.1em] transition-all ${
active
? "border-ink bg-ink text-paper"
: "border-ink/15 bg-paper text-ink hover:border-ink/40"
}`}
aria-pressed={active}
>
{label}
</button>
);
})}
</div>
)}
</div>

{lines.length === 0 ? (
Expand Down
Loading