fix: Top-N on default chart view + drop unscored rows from ledger - #263
Closed
Flotapponnier wants to merge 2 commits into
Closed
fix: Top-N on default chart view + drop unscored rows from ledger#263Flotapponnier wants to merge 2 commits into
Flotapponnier wants to merge 2 commits into
Conversation
Web search confirmed user is not alone. WebKit bug 297779 reports that on iOS 26 Safari + WKWebView (Telegram in-app browser, Chrome iOS), any position: fixed element drifts 10-24 px when scroll direction reverses, exposing the page under the header through a thin gap. Mastodon and LinkedIn ship the same symptom. Apple acknowledged the bug, partially fixed it in iOS 26.1 but residual reports persist into Dec 2025. position: sticky uses a different render path in WebKit that does not trip the jitter heuristic. It is also simpler: - no spacer div needed (the element stays in normal flow) - no useRef + ResizeObserver to keep the spacer in sync - no headerH state Net: -25 lines on top of fixing the cosmetic gap. Desktop and standalone Safari behavior are identical, sticky just renders more reliably in WebViews. Refs: - https://bugs.webkit.org/show_bug.cgi?id=297779 - mastodon/mastodon#36144 - TelegramMessenger/Telegram-iOS#1748
4 tasks
Flotapponnier
commented
Jun 18, 2026
CollaboratorAuthor
Closing as part of branch/PR cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two related gaps surfaced on the hl-frontends bench after expanding to 60 providers:
Top-N selector was missing from the default chart view. The Top 5/10/20/All toggle landed only on
time-series-chart.tsxin PR chart: top-N selector for crowded cohorts #257/fix(chart): top-N selector hidden on metrics with sparse data #258, but the bench page renders the Ranked Bar view by default. Reader sees the toolbar on the time-series tab but not on the headline view, looks confused.Unscored rows polluted both the ranked-bar list and the ledger. Providers whose Prom queries returned nothing this cycle were rendered as a long tail of "Currently unavailable / Awaiting next successful scrape" entries. On a 60-row cohort that's 20+ noise rows readers have to scroll past, and it makes the page look broken even when it isn't.
Fix
Top-N on
RankedBarChart— mirrors the time-series version: sized offbenchmark.results.length, default Top 20 when cohort > 20, hidden when cohort ≤ 10.Unscored filter — drops rows where
availability === "unavailable" && ms.p50 === 0. Applied identically inranked-bar-chart.tsxandledger-table.tsxso the chart and the table tell the same story. Providers stay in the underlying spec so/products/<slug>pages still resolve (SEO coverage preserved), they just no longer pollute the leaderboard surfaces.Test plan
/products/<slug>still resolves for every spec provider (including unscored ones)