Skip to content

fix(bench): bump maxDuration to 60s for 20+ provider benches#286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 3 commits into from
Jun 3, 2026
Merged

fix(bench): bump maxDuration to 60s for 20+ provider benches #286

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d14eed5
sync(topN): lift Top-N to parent so chart and ledger share one value
Flotapponnier Jun 3, 2026
3adab06
fix(bench): maxDuration 60s for cold start with 20+ providers
Flotapponnier Jun 3, 2026
dc66828
merge: resolve chart conflicts, prefer origin/dev versions
Flotapponnier Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/app/benchmarks/[slug]/page.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,14 @@ import type { Benchmark } from "@/types/benchmark";
// the route still prerenders cleanly.
export const revalidate = 60;

// Cold start render does up to ~200 Prom calls (provider × percentiles ×
// series queries) which can exceed Vercel's default 10s function timeout
// on benches with 20+ providers. Once ISR warms, the page is cached and
// fast — this only affects the first hit per revalidate window. Bumped
// to 60s to absorb the slow cold path. The actual hot path latency is
// served from the CDN cache so the user-facing P99 stays sub-second.
export const maxDuration = 60;

type Params = { slug: string };

export async function generateStaticParams() {
Expand Down
Loading