Skip to content

fix(sitemap): drop /products/<slug> URLs that 404#620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jun 21, 2026
Merged

fix(sitemap): drop /products/<slug> URLs that 404 #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/app/sitemap.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import { getBenchmarks } from "@/data/benchmarks";
import { loadAllAlternatives } from "@/lib/alternatives";
import { loadAllAnswers } from "@/lib/answers";
import { CHAINS, getBenchmarksForChain } from "@/lib/chains";
import { getProviderSlugs } from "@/lib/providers";
import { getProvider, getProviderSlugs } from "@/lib/providers";
import { SITE } from "@/data/site";
import type { Benchmark } from "@/types/benchmark";
import type { Answer } from "@/lib/answers";
Expand DownExpand Up@@ -190,7 +190,23 @@ async function buildFullSitemap(): Promise<MetadataRoute.Sitemap> {
return entries;
});

const providerRoutes: MetadataRoute.Sitemap = providerSlugs.map((slug) => ({
// Validate every slug against getProvider() so the sitemap can never
// ship a /products/<slug> URL that the page would 404 on. The page
// calls `getProvider(slug)` and renders notFound() when it returns
// undefined, so this is the exact filter generateStaticParams would
// need to apply if it were prerendering the route. Without this
// guard, Google indexed soft 404s for slugs the sitemap claimed
// existed (quicknode, coingecko, infura, ankr were all flagged).
const validatedSlugs = (
await Promise.all(
providerSlugs.map(async (slug) => {
const p = await getProvider(slug);
return p ? slug : null;
}),
)
).filter((s): s is string => s !== null);

const providerRoutes: MetadataRoute.Sitemap = validatedSlugs.map((slug) => ({
url: `${SITE.url}/products/${slug}`,
lastModified: providerLastRun.get(slug.toLowerCase()) ?? catalogTs,
changeFrequency: "daily",
Expand Down
Loading