fix(hf): swallow timeout in fetch_json - #640
Merged
Merged
Conversation
… timeouts cannot abort snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #636. The /api/series fetch in production timed out on first cold run, raising bare TimeoutError (subclass of OSError, not URLError) and aborting the whole snapshot. Catch TimeoutError + OSError explicitly so fetch_series can swallow per-URL timeouts via PublisherError as intended. Bump per-series timeout from 30s to 60s.
Hotfix path because the previous v1 partition is still served on HF and the workflow was failing on every retry.