fix(nav): bring back category pills on category hub pages + drop sub-nav strip - #684
Merged
Conversation
…drop sub-nav strip The header sub-nav strip added in the CMC redesign duplicated the pill row that already exists in BenchmarkGrid, with a less legible text + underline style. Reverting: - Drop the SiteSubNav strip from the header. - Always render the pill row inside BenchmarkGrid, even when the page passes a lockedCategory (category hub routes). - New allCategories prop so the hub routes pass the full taxonomy even though their benchmarks prop is pre-filtered to one category. - On locked pages pill clicks navigate naturally (no preventDefault) so users move between /benchmarks/category/<slug> URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMC-style sub-nav strip added recently duplicated the pill row already in BenchmarkGrid, with a less legible text + underline style. Users prefer the original pill UI from prod.
Changes:
Typecheck + lint clean.