Skip to content

feat(worker): materialize venue dimension variants (pm-data-freshness + pm-api-latency)#730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Jun 25, 2026
Merged

feat(worker): materialize venue dimension variants (pm-data-freshness + pm-api-latency) #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions worker/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,17 +191,21 @@ function variantCombos(spec: Spec): BenchmarkFilters[] {
const chains = (dims.chain ?? []).map((d) => d.value).filter((v) => v !== "all");
const regions = (dims.region ?? []).map((d) => d.value).filter((v) => v !== "all");
const kinds = (dims.kind ?? []).map((d) => d.value).filter((v) => v !== "all");
const venues = (dims.venue ?? []).map((d) => d.value).filter((v) => v !== "all");
const opt = <T,>(xs: T[]): (T | undefined)[] => (xs.length ? [undefined, ...xs] : [undefined]);
const combos: BenchmarkFilters[] = [];
for (const chain of opt(chains)) {
for (const region of opt(regions)) {
for (const kind of opt(kinds)) {
if (!chain && !region && !kind) continue; // the aggregate is tier A
combos.push({
...(chain ? { chain } : {}),
...(region ? { region } : {}),
...(kind ? { kind } : {}),
});
for (const venue of opt(venues)) {
if (!chain && !region && !kind && !venue) continue; // the aggregate is tier A
combos.push({
...(chain ? { chain } : {}),
...(region ? { region } : {}),
...(kind ? { kind } : {}),
...(venue ? { venue } : {}),
});
}
}
}
}
Expand DownExpand Up@@ -297,6 +301,7 @@ function variantPath(slug: string, f: BenchmarkFilters): string {
if (f.chain) qs.set("chain", f.chain);
if (f.region) qs.set("region", f.region);
if (f.kind) qs.set("kind", f.kind);
if (f.venue) qs.set("venue", f.venue);
return `/api/bench/${slug}/variant${qs.size ? `?${qs.toString()}` : ""}`;
}

Expand Down
Loading