Uh oh!
There was an error while loading. Please reload this page.
SSZ Multiproof - #57
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| .as_ref() | ||
| .iter() | ||
| .map(|v| builder.main().load_witness(F::from(*v as u64))) | ||
| .collect_vec(); |
There was a problem hiding this comment.
we have this in 5 or more places now (incl step circuit), might be worth putting this in a util method for this?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ec2
commented
Feb 2, 2024
I've removed the patch to halo2curves in the PR as well :D |
nulltea
left a comment
There was a problem hiding this comment.
My point re. code repetition still stands. Otherwise LGMT
TODO:
[x] Clean up some duplicate code
[x] Consider removing some of the preprocessor tests which only test individual circuits
[x] Fix spec tests
This PR reduces the amount of advice cells being used. We merklize a whole beacon header in circuit when what we really want is just a merkle proof for a couple specific fields.
Before:
After: