Uh oh!
There was an error while loading. Please reload this page.
fix(f3): pin crypto@v0.43.0 - #6485
Conversation
WalkthroughThe pull request updates multiple Go module dependency versions in the f3-sidecar/go.mod file, downgrading or adjusting versions for packages including libp2p/go-libp2p-kad-dht, golang.org/x/crypto, github.com/miekg/dns, and several golang.org/x/\* packages. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.5.0)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies" Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@f3-sidecar/go.mod`:
- Line 18: Replace the pinned dependency golang.org/x/crypto v0.43.0 in go.mod
with at least v0.45.0 to include fixes for the SSH CVEs (CVE-2025-58181 and
CVE-2025-47914), and update or remove the accompanying comment about assembly
optimizations/commit cf29fa96f8b66328e59829f064539321159bfa5b to reflect that
SHA-3 is delegated to crypto/sha3 (Go 1.24+) and that the security-fix upgrade
should be used unless a documented, measured performance regression is proven
for this codebase.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary of changes
Pin crypto@0.43.0 as it removed some assembly optimizations since v0.44.0. See filecoin-project/go-f3#1063 (comment) for details
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.