Uh oh!
There was an error while loading. Please reload this page.
chore(deps): bump go-deps - #6536
Conversation
WalkthroughUpdates Go module dependencies across three files: f3-sidecar, interop-tests/src/tests/go_app, and tools/prometheus_metrics_validator. Dependencies bumped include filecoin-project/go-f3, libp2p, Pion networking stack, golang.org/x modules (crypto, exp, mod, net, telemetry, text, tools), OpenTelemetry, and prometheus to newer versions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.5.0)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies" Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
f3-sidecar/go.mod (1)
21-143:⚠️ Potential issue | 🔴 CriticalPin
golang.org/x/cryptoto v0.43.0.The current version v0.47.0 is incompatible with go-f3 v0.8.12. Versions v0.44.0 and later removed the assembly-optimized Keccak implementation, causing the Keccak code path to fall back to the slow generic implementation and triggering CI timeouts. This constraint is documented in go-f3 PRs
#1055and#1063.
🤖 Fix all issues with AI agents
In `@f3-sidecar/go.mod`:
- Around line 5-19: Update the pinned version of the golang.org/x/crypto
dependency in the require block: change the version for module
golang.org/x/crypto from v0.47.0 to v0.43.0 so the legacy Keccak assembly path
used by go-f3 remains available; make the edit where golang.org/x/crypto is
listed in the require(...) section of the go.mod file.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary of changes
Changes introduced in this pull request:
go-f3to v0.8.12cryptoto latest to resolve https://github.com/ChainSafe/forest/security/dependabot/126 and https://github.com/ChainSafe/forest/security/dependabot/128 (see chore(deps): replace golang.org/x/crypto/sha3 with go-keccak, upgrade x/crypto filecoin-project/go-f3#1064 )go get -u && go mod tidyReference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit