Skip to content

fix: ignore F3 in RPC checks until reset - #6547

Merged
LesnyRumcajs merged 2 commits into
mainfrom
ignore-rpc-f3
Feb 5, 2026
Merged

fix: ignore F3 in RPC checks until reset#6547
LesnyRumcajs merged 2 commits into
mainfrom
ignore-rpc-f3

Conversation

@LesnyRumcajs

@LesnyRumcajsLesnyRumcajs commented Feb 5, 2026

Copy link
Copy Markdown
Member

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Updated test filter configuration by adding a revival note and an explicit Filecoin.F3 entry.
    • Adjusts test verification behavior to reflect the updated filter entries so F3-related items are included in test checks.

@LesnyRumcajs
LesnyRumcajs requested a review from a team as a code ownerFebruary 5, 2026 15:32
@LesnyRumcajs
LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a teamFebruary 5, 2026 15:32
@LesnyRumcajsLesnyRumcajs added the RPC requires calibnet RPC checks to run on CI label Feb 5, 2026
@coderabbitai

coderabbitaiBot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Added two lines to the filter-list: a revival note for F3 and an explicit entry !Filecoin.F3 to re-enable the Filecoin.F3 item in the filter behavior.

Changes

Cohort / File(s)Summary
Filter Configuration
scripts/tests/api_compare/filter-list
Added two lines: a revival note for F3 and an explicit filter entry !Filecoin.F3, re-enabling Filecoin.F3 in the filter list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • sudo-shashank
  • hanabi1224
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly describes the main change: ignoring F3 in RPC checks, which aligns with the filter-list modifications adding F3 exclusion entries.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ignore-rpc-f3

Comment @coderabbitai help to get the list of available commands and usage tips.

hanabi1224
hanabi1224 previously approved these changes Feb 5, 2026

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@scripts/tests/api_compare/filter-list`:
- Line 3: Replace the ambiguous date in the comment line that reads "# F3 is to
be revived around 12.02.2026" with an unambiguous format such as ISO
"2026-02-12" or a spelled-out date like "February 12, 2026" so the revival note
for F3 is locale-independent.

Comment threadscripts/tests/api_compare/filter-list Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@LesnyRumcajsLesnyRumcajs mentioned this pull request Feb 5, 2026
6 tasks
@LesnyRumcajs
LesnyRumcajs added this pull request to the merge queueFeb 5, 2026
Merged via the queue into main with commit a25c85aFeb 5, 2026
31 of 33 checks passed
@LesnyRumcajs
LesnyRumcajs deleted the ignore-rpc-f3 branch February 5, 2026 16:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPCrequires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LesnyRumcajs@hanabi1224