Skip to content

Fix RPC parity test failure - #6667

Merged
sudo-shashank merged 3 commits into
mainfrom
shashank/fix-rpc-gateway-check
Mar 2, 2026
Merged

Fix RPC parity test failure#6667
sudo-shashank merged 3 commits into
mainfrom
shashank/fix-rpc-gateway-check

Conversation

@sudo-shashank

@sudo-shashanksudo-shashank commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

Changes introduced in this pull request:

  • Filter out Filecoin.StateMinerInitialPledgeCollateral and Filecoin.StateMinerPreCommitDepositForPower as they are not supported via lotus-gateway.

Reference issue to close (if applicable)

Closes#6658
Closes#6661
Closes#6665

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Tests
    • Updated API gateway filter-list test configurations to reflect an expanded set of unsupported Filecoin operations.

@coderabbitai

coderabbitaiBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adad178 and 48ab56b.

📒 Files selected for processing (1)
  • scripts/tests/api_compare/filter-list-gateway

Walkthrough

Added two not-supported Filecoin state entries to the RPC parity test filter-list-gateway configuration file to reflect additional stateful APIs that lack parity between implementations. No control flow or error handling changes.

Changes

Cohort / File(s)Summary
RPC Parity Test Configuration
scripts/tests/api_compare/filter-list-gateway
Added two entries to the not-supported list: !Filecoin.StateMinerInitialPledgeCollateral and !Filecoin.StateMinerPreCommitDepositForPower.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'Fix RPC parity test failure' directly describes the primary objective: addressing RPC parity test failures by filtering unsupported methods from gateway checks.
Linked Issues check✅ PassedThe PR addresses the root cause of repeated RPC parity test failures [#6658, #6661, #6665] by filtering two unsupported RPC methods from gateway checks.
Out of Scope Changes check✅ PassedAll changes are scoped to filtering unsupported RPC methods from gateway tests, directly addressing the linked issues with no extraneous modifications.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shashank/fix-rpc-gateway-check

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashanksudo-shashank added the RPC requires calibnet RPC checks to run on CI label Mar 2, 2026
@sudo-shashanksudo-shashank changed the title Fix lotus-gateway RPC parity test failureFix RPC parity test failureMar 2, 2026
@sudo-shashank
sudo-shashank marked this pull request as ready for review March 2, 2026 07:14
@sudo-shashank
sudo-shashank requested a review from a team as a code ownerMarch 2, 2026 07:14
@sudo-shashank
sudo-shashank requested review from LesnyRumcajs and hanabi1224 and removed request for a teamMarch 2, 2026 07:14
@sudo-shashank
sudo-shashank added this pull request to the merge queueMar 2, 2026
Merged via the queue into main with commit 097ee9cMar 2, 2026
34 checks passed
@sudo-shashank
sudo-shashank deleted the shashank/fix-rpc-gateway-check branch March 2, 2026 08:17
@coderabbitaicoderabbitaiBot mentioned this pull request Apr 6, 2026
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPCrequires calibnet RPC checks to run on CI

Projects

None yet

2 participants

@sudo-shashank@hanabi1224