Uh oh!
There was an error while loading. Please reload this page.
test(ci): upload CI test results to codecov - #6749
Conversation
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a Nextest JUnit output path to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Comment |
504b45c to
817fdd6CompareThere was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/unit-tests.yml:
- Around line 86-92: The "Upload Test Results to CodeCov" job step currently
runs only on success; modify that step (the step named "Upload Test Results to
CodeCov" that uses codecov/codecov-action@v5 and uses token: ${{
secrets.CODECOV_TOKEN }}) to include an if: condition so it runs on both success
and failure (but not on manual cancel), e.g. add if: "!cancelled()" to the step
declaration so test results are uploaded even when tests fail.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5da2b32c-930f-4fea-b2fb-c04b48598a9c
📒 Files selected for processing (2)
.config/nextest.toml.github/workflows/unit-tests.yml
Uh oh!
There was an error while loading. Please reload this page.
817fdd6 to
feb0229Comparefeb0229 to
1b242ccCompare
Summary of changes
test results uploaded to https://app.codecov.io/gh/ChainSafe/forest/tests/hm%2Fjunit-test-results
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit