fix: optimize tipset cache usage

[hanabi1224]

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
• I have added tests that prove my fix is effective or that my feature works (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

• I have read and agree to the CONTRIBUTING document.
• I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

• Performance

  • Cached environment-flag evaluations to avoid repeated lookups, improving runtime efficiency across many operations.
  • Reduced default tipset cache capacity for improved memory efficiency.

• Refactor

  • Standardized tipset resolution and chain traversal paths across core components for consistency.
  • Reworked several modules to use centralized, lazily-initialized env toggles instead of per-call checks.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 53214b83-1569-49ce-8da6-de2da5c948e1

📥 Commits

Reviewing files that changed from the base of the PR and between e874bf5 and 0def445.

📒 Files selected for processing (11)

• src/auth/mod.rs
• src/chain/store/index.rs
• src/chain_sync/chain_follower.rs
• src/libp2p/service.rs
• src/rpc/json_validator.rs
• src/rpc/methods/eth.rs
• src/rpc/methods/eth/tipset_resolver.rs
• src/utils/io/mmap.rs
• src/utils/misc/env.rs
• src/utils/proofs_api/parameters.rs
• src/utils/proofs_api/paramfetch.rs

✅ Files skipped from review due to trivial changes (1)

• src/libp2p/service.rs

🚧 Files skipped from review as they are similar to previous changes (5)

• src/auth/mod.rs
• src/utils/proofs_api/parameters.rs
• src/utils/io/mmap.rs
• src/rpc/methods/eth.rs
• src/utils/proofs_api/paramfetch.rs

---

Walkthrough

Caches many environment-variable truthiness checks via a new def_is_env_truthy! macro, replaces per-call env reads with lazily-initialized accessors, refactors tipset iteration/loading to use tipset.chain(&db) and chain_index.load_required_tipset(...), and removes ChainIndex::chain() while adjusting a tipset cache size constant.

Changes

Cohort / File(s)	Summary
Env macro & accessors src/utils/misc/env.rs	Adds def_is_env_truthy! macro that generates memoized pub fn accessors (test builds call is_env_truthy per-invocation).
Env-var caching callsites src/auth/mod.rs, src/beacon/drand.rs, src/f3/mod.rs, src/rpc/methods/f3.rs, src/utils/io/mmap.rs, src/utils/proofs_api/parameters.rs, src/utils/proofs_api/paramfetch.rs, src/libp2p/service.rs, src/rpc/json_validator.rs, src/rpc/methods/eth/tipset_resolver.rs	Replace per-call is_env_truthy/is_env_set_and_truthy uses with macro-generated cached accessors or LazyLock statics; imports adjusted accordingly.
IGNORE_DRAND flag & usage src/beacon/drand.rs, src/fil_cns/validation.rs, src/chain/store/index.rs	Introduce pub static IGNORE_DRAND: LazyLock<bool> and switch callsites from env-var string checks to reading the cached IGNORE_DRAND.
Tipset loading via ChainIndex src/rpc/methods/chain.rs, src/rpc/methods/eth.rs, src/rpc/methods/eth/filter/mod.rs	Change tipset loads from Tipset::load_required(store, ...) to chain_index.load_required_tipset(...).
Chain iteration & ChainIndex.chain removal src/chain/store/index.rs, src/libp2p/chain_exchange/provider.rs, src/state_manager/mod.rs, src/tool/subcommands/snapshot_cmd.rs	Remove ChainIndex::chain(...) usage and replace callers with tipset.chain(&db) or root.chain(cs.blockstore()); also remove ChainIndex::chain public method and reduce DEFAULT_TIPSET_CACHE_SIZE from 131072 to 2880.
Local refactors & callsite fixes src/chain_sync/chain_follower.rs, src/cli_shared/cli/config.rs, src/dev/subcommands/state_cmd.rs, src/utils/proofs_api/paramfetch.rs, src/utils/io/mmap.rs	Use cached env-accessors, simplify config defaults, cache local chain_index where needed, and adjust imports/usages to match the new helpers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix: add cache to speed up fn tipset_by_height #5944: Related changes to src/chain/store/index.rs tipset iteration and tipset_by_height logic.
• Gate JWT expiration validation behind env var #6166: Prior introduction of the JWT expiration-validation env-gate now optimized with LazyLock caching here.
• fix(test): speed up test-release and codecov on CI #6372: Related proof-params/env handling changes in src/utils/proofs_api/* touched by this PR.

Suggested reviewers

• akaladarshi
• sudo-shashank
• LesnyRumcajs

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: optimize tipset cache usage' clearly summarizes the primary change across the PR: replacing per-call environment variable checks with cached, lazily-initialized values and refactoring chain iteration patterns to use optimized tipset access methods.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch hm/optimize-tipset-cache-usage

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch hm/optimize-tipset-cache-usage

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/auth/mod.rs`:
- Around line 47-52: The static LazyLock DISABLE_EXP_VALIDATION causes
verify_token() behavior to be cached process-wide and makes test results
order-dependent; change verify_token() to read
is_env_truthy("FOREST_JWT_DISABLE_EXP_VALIDATION") at call time instead of using
the static, or replace DISABLE_EXP_VALIDATION with a non-static helper function
(e.g., should_disable_exp_validation()) that calls is_env_truthy() each
invocation; update the code paths in verify_token() that reference
DISABLE_EXP_VALIDATION to call the helper or inline is_env_truthy so env changes
during tests take effect.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: aa59d859-cc5d-4938-8b5a-a1371d86b23a

📥 Commits

Reviewing files that changed from the base of the PR and between c2c6d23 and e874bf5.

📒 Files selected for processing (18)

• src/auth/mod.rs
• src/beacon/drand.rs
• src/chain/store/index.rs
• src/chain_sync/chain_follower.rs
• src/cli_shared/cli/config.rs
• src/dev/subcommands/state_cmd.rs
• src/f3/mod.rs
• src/fil_cns/validation.rs
• src/libp2p/chain_exchange/provider.rs
• src/rpc/methods/chain.rs
• src/rpc/methods/eth.rs
• src/rpc/methods/eth/filter/mod.rs
• src/rpc/methods/f3.rs
• src/state_manager/mod.rs
• src/tool/subcommands/snapshot_cmd.rs
• src/utils/io/mmap.rs
• src/utils/proofs_api/parameters.rs
• src/utils/proofs_api/paramfetch.rs

[codecov]

Codecov Report

❌ Patch coverage is 56.00000% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.62%. Comparing base (c2c6d23) to head (0def445).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/dev/subcommands/state_cmd.rs	0.00%	7 Missing ⚠️
src/state_manager/mod.rs	33.33%	5 Missing and 1 partial ⚠️
src/rpc/methods/f3.rs	0.00%	2 Missing ⚠️
src/tool/subcommands/snapshot_cmd.rs	0.00%	2 Missing ⚠️
src/chain/store/index.rs	85.71%	1 Missing ⚠️
src/rpc/methods/chain.rs	66.66%	0 Missing and 1 partial ⚠️
src/rpc/methods/eth.rs	0.00%	0 Missing and 1 partial ⚠️
src/rpc/methods/eth/filter/mod.rs	0.00%	1 Missing ⚠️
src/utils/proofs_api/paramfetch.rs	50.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
src/auth/mod.rs	100.00% <100.00%> (ø)
src/beacon/drand.rs	76.66% <100.00%> (-0.85%)	⬇️
src/chain_sync/chain_follower.rs	39.27% <100.00%> (-0.10%)	⬇️
src/cli_shared/cli/config.rs	100.00% <100.00%> (ø)
src/f3/mod.rs	59.12% <100.00%> (ø)
src/fil_cns/validation.rs	78.75% <100.00%> (ø)
src/libp2p/chain_exchange/provider.rs	83.33% <100.00%> (-0.12%)	⬇️
src/libp2p/service.rs	12.30% <ø> (+0.06%)	⬆️
src/rpc/json_validator.rs	96.10% <ø> (+2.20%)	⬆️
src/rpc/methods/eth/tipset_resolver.rs	60.00% <100.00%> (-0.53%)	⬇️
... and 12 more

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c6d23...0def445. Read the comment docs.