Skip to content

[automated] Update Lotus version in API tests - #7035

Closed
leshyatwork[bot] wants to merge 1 commit into
mainfrom
leshy/update-lotus-version
Closed

[automated] Update Lotus version in API tests#7035
leshyatwork[bot] wants to merge 1 commit into
mainfrom
leshy/update-lotus-version

Conversation

@leshyatwork

@leshyatworkleshyatworkBot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Updates Lotus version in the JSON-RPC API tests to the latest release.

@leshyatworkleshyatworkBot added the RPC requires calibnet RPC checks to run on CI label May 12, 2026
@leshyatwork
leshyatworkBot requested a review from a team as a code ownerMay 12, 2026 00:38
@leshyatwork
leshyatworkBot removed the request for review from a teamMay 12, 2026 00:38
@leshyatworkleshyatworkBot added the RPC requires calibnet RPC checks to run on CI label May 12, 2026
@codecov

codecovBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.36%. Comparing base (d77c915) to head (380bffd).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 3 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d39419...380bffd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akaladarshi

akaladarshi commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

We should hold off on this for now because filecoin-project/lotus#13610 is not part of the lotus new version yet and we have already merged the #7001

Hence the tests are failing.

@hanabi1224

hanabi1224 commented May 12, 2026

Copy link
Copy Markdown
Contributor

@akaladarshi we could use a commit tag instead?

@akaladarshi
akaladarshiforce-pushed the leshy/update-lotus-version branch from 09c7a44 to bf877f8CompareMay 12, 2026 10:42
@akaladarshi
akaladarshi enabled auto-merge May 12, 2026 11:19
hanabi1224
hanabi1224 previously approved these changes May 12, 2026
View reviewed changes
@akaladarshi
akaladarshi added this pull request to the merge queueMay 12, 2026
@LesnyRumcajs
LesnyRumcajs removed this pull request from the merge queue due to a manual request May 12, 2026
@LesnyRumcajs

LesnyRumcajs commented May 12, 2026

Copy link
Copy Markdown
Member

As discussed, it doesn't make sense to do manual changes unless needed. Let's wait for a proper release.

LesnyRumcajs
LesnyRumcajs requested changes May 12, 2026
View reviewed changes

@LesnyRumcajsLesnyRumcajs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking

@leshyatwork
leshyatworkBotforce-pushed the leshy/update-lotus-version branch 2 times, most recently from 5acb971 to be4982dCompareMay 14, 2026 00:44
@LesnyRumcajs

LesnyRumcajs commented May 14, 2026

Copy link
Copy Markdown
Member

The latest Lotus release didn't include this fix for some reason, so still blocked. https://github.com/filecoin-project/lotus/releases/tag/v1.36.0

@leshyatwork
leshyatworkBotforce-pushed the leshy/update-lotus-version branch 5 times, most recently from a49d8d3 to 70a3e1fCompareMay 21, 2026 00:46
@leshyatwork
leshyatworkBotforce-pushed the leshy/update-lotus-version branch 4 times, most recently from bcf3978 to c31e1d1CompareMay 27, 2026 00:45
@leshyatwork
leshyatworkBotforce-pushed the leshy/update-lotus-version branch 5 times, most recently from d0f21d3 to 642591fCompareJune 3, 2026 00:56
@leshyatwork
leshyatworkBotforce-pushed the leshy/update-lotus-version branch 7 times, most recently from 64b8dec to efb726aCompareJune 11, 2026 00:50
@leshyatwork
leshyatworkBotforce-pushed the leshy/update-lotus-version branch 2 times, most recently from e8bcd91 to b0e7252CompareJune 14, 2026 00:52
@leshyatwork
leshyatworkBotforce-pushed the leshy/update-lotus-version branch from b0e7252 to 380bffdCompareJune 15, 2026 00:53
@LesnyRumcajs

LesnyRumcajs commented Jun 15, 2026

Copy link
Copy Markdown
Member

I disabled the workflow manually for now, since it will be failing indefinitely until Lotus makes a release with the aforementioned change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LesnyRumcajsLesnyRumcajsLesnyRumcajs requested changes
@akaladarshiakaladarshiAwaiting requested review from akaladarshiakaladarshi is a code owner automatically assigned from ChainSafe/forest
+1 more reviewer
@hanabi1224hanabi1224hanabi1224 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

RPCrequires calibnet RPC checks to run on CIStatus: DO NOT MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akaladarshi@hanabi1224@LesnyRumcajs