Uh oh!
There was an error while loading. Please reload this page.
Conversation
Judis
reviewed
Apr 25, 2022
Uh oh!
There was an error while loading. Please reload this page.
Judis
reviewed
Apr 26, 2022
| end | ||
| def run_step(module, state) when is_atom(module) do | ||
| apply(module, :run, [state, []]) |
MemberAuthor
There was a problem hiding this comment.
sure, what is wrong?
A step can be one of the following:
* a 1-arity function
* a `{module, function, args}` tuple - calls `apply(module, function, [state | args])`
* a `{module, options}` tuple - calls `module.run(state, options)`
* a `module` atom - calls `module.run(state, [])`
| ] ++ | ||
| maybe_steps(options[:auth], [{__MODULE__, :auth, [options[:auth]]}]) ++ | ||
| maybe_steps(options[:params], [{__MODULE__, :put_params, [options[:params]]}]) ++ | ||
| maybe_steps(options[:steps], [{__MODULE__, :run_steps, [options[:steps]]}]) |
Contributor
There was a problem hiding this comment.
May be we can reverse this operation and use [x|y] syntax?
MemberAuthor
There was a problem hiding this comment.
I've changed adding steps to request, can you look again?
| response_telemetry_step = {__MODULE__, :log_response_end, []} | ||
| retry = options[:retry] | ||
| retry = if retry == true, do: [], else: retry |
MemberAuthor
There was a problem hiding this comment.
we can set retry: true then it will be default case:
retry only in case of exceptions (HTTPoison.Error and Mint.Error e.g. are exceptions) or status code >= 500, for 3 times with 2 sec pause
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
anroninforce-pushed
the
add-steps
branch
3 times, most recently
from
June 6, 2022 16:58
02d00f9 to
9e8acbdCompareanroninforce-pushed
the
add-steps
branch
2 times, most recently
from
August 3, 2022 13:31
faeaa15 to
319b858Compareanroninforce-pushed
the
add-steps
branch
3 times, most recently
from
August 6, 2023 12:57
be2cb9a to
a58cc3bCompareanroninforce-pushed
the
add-steps
branch
3 times, most recently
from
April 23, 2025 11:54
cbf95f1 to
ad2f92dCompareanroninforce-pushed
the
add-steps
branch
6 times, most recently
from
January 14, 2026 10:57
577799a to
6f0bc74Compare* Add exponent retry * Dynamically start Finch pool with the given proxy configs * Support multiple content-encoding headers * Add follow_redirects step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.