Skip to content

fix(store): fix installed status detection for plugins with path-derived IDs#270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChuckBuilds merged 1 commit into from
Feb 24, 2026
Merged

fix(store): fix installed status detection for plugins with path-derived IDs #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions web_interface/static/v3/plugins_manager.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5261,8 +5261,17 @@ function showStoreLoading(show) {

// ── Plugin Store: Client-Side Filter/Sort/Pagination ────────────────────────

function isStorePluginInstalled(pluginId) {
return (window.installedPlugins || installedPlugins || []).some(p => p.id === pluginId);
function isStorePluginInstalled(pluginIdOrPlugin) {
const installed = window.installedPlugins || installedPlugins || [];
// Accept either a plain ID string or a store plugin object (which may have plugin_path)
if (typeof pluginIdOrPlugin === 'string') {
return installed.some(p => p.id === pluginIdOrPlugin);
}
const storeId = pluginIdOrPlugin.id;
// Derive the actual installed directory name from plugin_path (e.g. "plugins/ledmatrix-weather" → "ledmatrix-weather")
const pluginPath = pluginIdOrPlugin.plugin_path || '';
const pathDerivedId = pluginPath ? pluginPath.split('/').pop() : null;
return installed.some(p => p.id === storeId || (pathDerivedId && p.id === pathDerivedId));
}

function applyStoreFiltersAndSort(skipPageReset) {
Expand DownExpand Up@@ -5292,9 +5301,9 @@ function applyStoreFiltersAndSort(skipPageReset) {

// Installed filter
if (st.filterInstalled === true) {
list = list.filter(plugin => isStorePluginInstalled(plugin.id));
list = list.filter(plugin => isStorePluginInstalled(plugin));
} else if (st.filterInstalled === false) {
list = list.filter(plugin => !isStorePluginInstalled(plugin.id));
list = list.filter(plugin => !isStorePluginInstalled(plugin));
}

// Sort
Expand DownExpand Up@@ -5541,7 +5550,7 @@ function renderPluginStore(plugins) {
};

container.innerHTML = plugins.map(plugin => {
const installed = isStorePluginInstalled(plugin.id);
const installed = isStorePluginInstalled(plugin);
return `
<div class="plugin-card">
<div class="flex items-start justify-between mb-4">
Expand DownExpand Up@@ -6103,7 +6112,7 @@ function renderCustomRegistryPlugins(plugins, registryUrl) {
};

container.innerHTML = plugins.map(plugin => {
const isInstalled = installedPlugins.some(p => p.id === plugin.id);
const isInstalled = isStorePluginInstalled(plugin);
const pluginIdJs = escapeJs(plugin.id);
const escapedUrlJs = escapeJs(registryUrl);
const pluginPathJs = escapeJs(plugin.plugin_path || '');
Expand Down