fix: live priority now interrupts long display durations (#196)

[ChuckBuilds]

Summary

Fixes#196 — Live priority games not taking over the display when dynamic duration is enabled.

• Root cause: _check_live_priority() was only called once per main loop iteration, before entering the display duration loop. With dynamic duration, the loop runs for 60-120+ seconds without checking if a favorite team's live game started.
• Fix: Both the high-FPS and normal FPS display loops now check _check_live_priority() every ~30 seconds (throttled). When live content is detected, the loop breaks immediately and switches to the live game mode.
• This matches the existing pattern for on-demand requests (_poll_on_demand_requests()), which are already checked inside both loops.

Test plan

• Enable live_priority for a sport plugin with an active live game
• While another mode is displaying with dynamic duration (leaderboard, odds ticker, etc.), verify the display switches to the live game within ~30 seconds
• When the live game ends, verify display returns to normal rotation
• With live_priority disabled, verify no interruption occurs

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Display now performs throttled periodic live-priority checks in both high-FPS and standard rendering loops, improving responsiveness to higher-priority live modes.
  • When a live mode preempts the current display, the system switches immediately and skips remaining loop cleanup to apply the new mode faster, reducing delayed or missed mode changes.

[coderabbitai]

📝 Walkthrough

Walkthrough

Periodic live-priority checks (~30s) were added to both the high-FPS dynamic loop and the standard display loop in the display controller. If a different live mode is detected while on-demand is inactive, the controller updates the active mode, sets a force-change flag, attempts to align the mode index, and exits the current loop to apply priority immediately.

Changes

Cohort / File(s)

Summary

Display Loop Priority Checks src/display_controller.py

Inserted throttled live-priority polling (guarded by self._next_live_priority_check) into both the high-FPS and standard display loops when on-demand is inactive. On detection of a differing live_mode, logs preemption, sets self.current_display_mode = live_mode, self.force_change = True, attempts to set self.current_mode_index (ignores ValueError), and breaks from the current render loop. Removed a late elapsed = time.time() - start_time assignment in the high-FPS loop and added a post-loop guard to skip rotation/sleep when preempted.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: enabling live priority to interrupt long display durations, which directly addresses the core fix in the changeset.
Linked Issues check	✅ Passed	The PR implements periodic live-priority checking within display loops (~30 seconds), allowing live games to interrupt long-running displays and preempt rotation logic—directly addressing issue #196's requirement that live games have priority.
Out of Scope Changes check	✅ Passed	All changes focus on adding throttled live-priority checks and preemption logic within display loops; no unrelated modifications were introduced outside the stated objective.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/live-priority-during-display-loop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/display_controller.py`:
- Around line 1866-1875: The live-priority check sets self.current_display_mode
and self.force_change but doesn't update the rotation pointer, so subsequent
rotation will overwrite the live mode; after detecting live_mode in the block
that calls self._check_live_priority() (the branch that sets
self.current_display_mode, self.force_change and breaks), also set
self.current_mode_index to the index of live_mode in the sequence used for
rotation (e.g., find live_mode in self.display_modes or the list that drives
rotation) or to a sentinel value that prevents the rotator advancing; ensure you
handle the case where live_mode is not found (fallback to 0 or leave unchanged)
so the rotation logic uses the correct index going forward.
- Around line 1793-1802: When detecting live priority in the high-FPS loop
(where _check_live_priority() returns a live_mode and you set
self.current_display_mode and self.force_change), also update
self.current_mode_index to the index of that live_mode so subsequent rotation
logic using active_mode doesn't overwrite it; mirror the pattern used earlier
where current_mode_index is set when live is chosen (use the same lookup
mechanism that maps modes to indices), ensuring this update happens before the
break and only when live_mode != active_mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1c3f778-2d7f-48a0-b1d2-03cb2416356e

📥 Commits

Reviewing files that changed from the base of the PR and between 35df06b and d87d896.

📒 Files selected for processing (1)

• src/display_controller.py

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/display_controller.py`:
- Around line 1795-1797: The current throttle uses (elapsed % 30.0) <
display_interval which can miss the narrow window; replace it with an explicit
timestamp check (e.g., add self.next_live_priority_check_at or
self.last_live_priority_check) and compare time.time() >=
next_live_priority_check_at before calling self._check_live_priority(), then
update next_live_priority_check_at = time.time() + 30.0 (or set
last_live_priority_check = time.time()) after the check; apply the same change
to the analogous block around the _check_live_priority calls at the other
location (lines 1871-1874) and ensure the condition still respects
self.on_demand_active and display_interval where relevant.
- Around line 1797-1806: The live-priority branch currently only breaks the
inner render loop so later outer-loop logic (rotation advancement and
remaining-duration handling) can still run and override the new live mode;
modify the branch in the block handling live_mode (the one that sets
self.current_display_mode, self.force_change and self.current_mode_index) so
that after setting those fields you also short-circuit the outer flow—e.g. set a
dedicated flag (like self._live_preempted = True) or call/return to exit the
enclosing loop/function so no further rotation or duration logic for the old
active_mode executes; apply the same change to the analogous block around lines
1874-1883 that checks live priority.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b77dff31-d55b-4faf-9847-6f468636cafc

📥 Commits

Reviewing files that changed from the base of the PR and between d87d896 and a570799.

📒 Files selected for processing (1)

• src/display_controller.py

[coderabbitai]

🧹 Nitpick comments (1)

src/display_controller.py (1)

1794-1811: Consider computing elapsed from now to avoid redundant time.time() calls.

At 125 FPS, calling time.time() twice per iteration is harmless but slightly wasteful. Computing now first and deriving elapsed from it is cleaner.

♻️ Optional: Reduce time.time() calls

- elapsed = time.time() - start_time
now = time.time()
+ elapsed = now - start_time
if not self.on_demand_active and now >= self._next_live_priority_check:

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@src/display_controller.py` around lines 1794 - 1811, Compute now once and
derive elapsed from it to avoid duplicate time.time() calls: replace the current
two calls to time.time() by setting now = time.time() first, then elapsed = now
- start_time, and keep the rest of the logic using now and elapsed (affecting
the block that checks self._next_live_priority_check, calls
self._check_live_priority(), and updates self.current_display_mode,
self.force_change, and self.current_mode_index from self.available_modes).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/display_controller.py`:
- Around line 1794-1811: Compute now once and derive elapsed from it to avoid
duplicate time.time() calls: replace the current two calls to time.time() by
setting now = time.time() first, then elapsed = now - start_time, and keep the
rest of the logic using now and elapsed (affecting the block that checks
self._next_live_priority_check, calls self._check_live_priority(), and updates
self.current_display_mode, self.force_change, and self.current_mode_index from
self.available_modes).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cac4f5c5-4597-4d1e-8129-b087ca35118b

📥 Commits

Reviewing files that changed from the base of the PR and between a570799 and 738d3df.

📒 Files selected for processing (1)

• src/display_controller.py