chore: ignore team logos fetched at runtime - #551
Conversation
logo_downloader.py and LogoHelper write into assets/sports/<league>_logos/ whenever a plugin meets a team whose logo is not on disk. Those directories are also tracked -- 209 NCAA logos and 153 soccer ones ship with the repo -- so every rig accumulates untracked files nobody intended to commit. This checkout had 62; hdpi shows the same. The cost is not the files, it is that a permanently dirty `git status` trains everyone to ignore the one signal that says a checkout is not what you think it is. That is how a stale tree sat unnoticed on a rig for hours until a restart surfaced four sports plugins that could no longer import. Ignoring a directory does not untrack what is already in it, so the logos that ship keep shipping -- verified: 209 and 153 still tracked, no deletions in the diff. Only new downloads are hidden. Adding a logo on purpose stays possible and is what the escape hatch in the comment documents. It is also rare: the last deliberate addition was #415, four named NCAA logos a plugin needed, and `git log` finds no other in a year. So the common case is noise and the rare case is explicit, which is the right way round. Untracked files: 62 -> 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
|
@coderabbitai review Generated by Claude Code |
|
|
The problem
src/logo_downloader.pyandLogoHelperwrite intoassets/sports/<league>_logos/whenever a plugin meets a team whose logo is not on disk. Those directories are also tracked — 209 NCAA logos and 153 soccer ones ship with the repo — so every rig accumulates untracked files nobody intended to commit.This checkout had 62. hdpi shows the same pattern.
The cost is not the files. It is that a permanently dirty
git statustrains everyone to ignore the one signal that says a checkout is not what you think it is — which is how a stale tree sat unnoticed on a rig for hours until a restart surfaced four sports plugins that could no longer import.Why this is safe
Ignoring a directory does not untrack what is already in it. The logos that ship keep shipping — verified: 209 and 153 still tracked, and the diff contains no deletions. Only new downloads are hidden.
Why ignoring is the right call rather than committing them
Deliberate logo additions are rare and explicit. The last one was #415 — four named NCAA logos a plugin needed — and
git log --since="1 year ago"finds no other. So the common case is runtime noise and the rare case is intentional, which is the right way round for an ignore rule. The escape hatch is documented in the.gitignorecomment:Verified working.
Result
Untracked files: 62 → 0.
Not in scope
The 213 MB of tracked assets and the 199 MB pack are a separate question that would need a history rewrite. Flagging, not touching.
🤖 Generated with Claude Code
https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9