fix(weather): fix stale daily forecast days and radar tile timeout (v2.2.3) - #111
Conversation
…2.2.3) Two bugs caused weather to show days-old data: 1. Radar tile fetch timed out the plugin executor: refresh_data() fetched 12 tiles sequentially (worst case 120s), exceeding the 30s executor timeout. Reduced to 6 frames and added a 20s wall-clock budget so the fetch always completes within the executor window. 2. Daily forecast showed past days from stale cached data: _process_forecast_data used daily[1:4] relative to fetch time. Replaced with a date filter (same pattern as the existing hourly filter) so only future days appear regardless of when the data was fetched. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 2 minutes and 41 seconds.Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
refresh_data()fetched 12 tiles sequentially (worst case 120s), exceeding the plugin executor's 30s timeout. Reduced to 6 frames with a 20s wall-clock budget — fetch now completes safely in a few seconds under normal conditions_process_forecast_datauseddaily[1:4]relative to the API fetch time. With 3-day-old cached data, Tuesday would show Sun/Mon/Tue. Replaced with a date filter (matching the existing hourly filter pattern) so only future days are displayed regardless of data freshnessContext
Part of a two-repo fix for plugins silently showing stale data. The radar timeout in this plugin was the trigger for the
PluginState.ERRORpermanent-lockout bug fixed in LEDMatrix#316.Test plan
2026-04-28 09:29:45(was stuck at2026-04-25 07:35)🤖 Generated with Claude Code