Skip to content

chore(baseball-scoreboard): move fine-tuning config fields behind Advanced Settings (x-advanced) - #204

Closed
ChuckBuilds wants to merge 1 commit into
mainfrom
claude/chuck-builds-plugin-config-65322r-baseball-scoreboard
Closed

chore(baseball-scoreboard): move fine-tuning config fields behind Advanced Settings (x-advanced)#204
ChuckBuilds wants to merge 1 commit into
mainfrom
claude/chuck-builds-plugin-config-65322r-baseball-scoreboard

Conversation

@ChuckBuilds

Copy link
Copy Markdown
Owner

Pull Request

Summary

Applies the "easy stuff up front, power stuff behind one click" treatment (LEDMatrix core PR #417's x-advanced mechanism) to baseball-scoreboard's config_schema.json: 197 of 227 flat fields are now flagged "x-advanced": true, so the core web UI collapses them into one "Advanced Settings" section at the bottom of the config page. Purely additive schema-data change — no field removed or renamed, no default or required changed, no manager.py change.

Type of change

  • Bug fix in an existing plugin
  • New plugin (also fill out the SUBMISSION.md checklist below)
  • New feature for an existing plugin
  • Documentation only
  • Repo-wide change (registry script, hook, top-level docs)
  • UX-only config schema reorganization (no behavior change)

Plugin(s) affected

baseball-scoreboard

Related issues

N/A — part of the plugin-store-wide config UX uplift following LEDMatrix core PR #417.

Test plan

  • Loaded the plugin in LEDMatrix on real hardware
  • Loaded the plugin in LEDMatrix emulator mode (EMULATOR=true python3 run.py)
  • Rendered the plugin in the dev preview server (scripts/dev_server.py)
  • Verified the web UI configuration form against the schema
  • N/A — repo-wide / docs-only change

Details: schema still parses as strict JSON; the diff is exactly 197 inserted "x-advanced": true, lines (path-aware text insertion, preserving the file's existing formatting); verified programmatically that stripping every x-advanced key yields a schema deep-equal to main (validation behavior identical — only rendering changes); update_registry.py --dry-run reported changes for this plugin only. Rendering was not eyeballed against a live core web UI in this environment — the flags use exactly the mechanism core already ships.

Required for plugin changes

  • Bumped version in plugins/<id>/manifest.json (1.19.0 → 1.19.1, with a versions[] changelog entry)
  • class_name in manifest.json matches the actual class in manager.py exactly (unchanged)
  • entry_point matches the real file (unchanged)
  • Updated the plugin's README.md if config keys changed (no keys changed — N/A)
  • config_schema.json is the source of truth for the web UI form — no new options added, only x-advanced render hints
  • Pre-commit hook ran successfully (update_registry.py run directly; plugins.json synced to 1.19.1)

Checklist

  • My commits follow the message convention in CONTRIBUTING.md
  • I read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  • I've not committed any secrets

Notes for reviewer

What was flagged advanced, and why (one line each):

  • update_interval — global fetch interval with a sane 3600s default; pure tuning.
  • Per-league (mlb / milb / ncaa_baseball, uniformly): exclude_teams — niche spoiler-avoidance filter; display_modes.{live,recent,upcoming}_display_mode — switch-vs-scroll enums most users leave at default; scroll_settings.* (6 fields) — scroll fine-tuning, only relevant after opting into scroll; live_priority — rotation-interrupt tweak; {live,recent,upcoming}_game_duration + non_favorite_live_game_duration — dwell-time tuning; live_update_interval / update_interval_seconds — poll-interval tuning; display_options.* (8 toggles incl. show_pitcher_batter, show_player_card, show_traditional_scoreboard) — optional extra-info/extra-screen toggles, not needed to get games on screen; filtering.favorite_live_boost — rotation-weight knob; mode_durations.* — null-by-default overrides; dynamic_duration.* — disabled-by-default duration system.
  • customization.* (all leaf fields: score/status/detail/period/team-name/rank text styles, layout offsets, bases/outs/count/at-bat, player card, traditional scoreboard) — per-element font/color/offset overrides; the plugin looks right with defaults.

Kept basic (never flagged): league enabled toggles, favorite_teams, display_modes.show_live/show_recent/show_upcoming, filtering.show_favorite_teams_only / show_all_live, display_duration / game_display_duration, and game_limits.recent/upcoming_games_to_show.

Pre-existing quirk left untouched (out of scope): none for this manifest; new versions[] entry uses ledmatrix_min_version matching the most recent entry's key. jsonschema package wasn't available locally, so manifest-vs-schema/manifest_schema.json validation is left to CI.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62


Generated by Claude Code

…anced Settings (x-advanced)

UX-only schema reorganization for a quicker first-time setup. No fields
removed or renamed, no defaults changed, no validation change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@ChuckBuilds, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 419f1caf-fa1a-4a37-bd78-f83907f01d37

📥 Commits

Reviewing files that changed from the base of the PR and between 3ba5905 and aa3c1fd.

📒 Files selected for processing (3)
  • plugins.json
  • plugins/baseball-scoreboard/config_schema.json
  • plugins/baseball-scoreboard/manifest.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/chuck-builds-plugin-config-65322r-baseball-scoreboard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown
Owner Author

Closing in favor of the consolidated PR #208 (per maintainer request, all x-advanced schema uplifts in one PR — this plugin's change is included there as its own commit).


Generated by Claude Code

@ChuckBuilds
ChuckBuilds deleted the claude/chuck-builds-plugin-config-65322r-baseball-scoreboard branch August 5, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants