chore(lacrosse-scoreboard): move fine-tuning config fields behind Advanced Settings (x-advanced) - #207
Conversation
…anced Settings (x-advanced) UX-only schema reorganization for a quicker first-time setup. No fields removed or renamed, no defaults changed, no validation change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
|
Closing in favor of the consolidated PR #208 (per maintainer request, all x-advanced schema uplifts in one PR — this plugin's change is included there as its own commit). Generated by Claude Code |
Pull Request
Summary
Applies the "easy stuff up front, power stuff behind one click" treatment (LEDMatrix core PR #417's
x-advancedmechanism) to lacrosse-scoreboard'sconfig_schema.json: 93 of 127 flat fields are now flagged"x-advanced": true, so the core web UI collapses them into one "Advanced Settings" section at the bottom of the config page. Purely additive schema-data change — no field removed or renamed, no default orrequiredchanged, no manager.py change.Type of change
Plugin(s) affected
lacrosse-scoreboard
Related issues
N/A — part of the plugin-store-wide config UX uplift following LEDMatrix core PR #417.
Test plan
EMULATOR=true python3 run.py)scripts/dev_server.py)Details: schema still parses as strict JSON; flags inserted via text patch preserving the file's 2-space indent and unicode escapes; verified programmatically that recursively stripping every
x-advancedkey yields a schema deep-equal tomain, and that noobject-type property carries the flag;update_registry.py --dry-runreported changes for this plugin only. Rendering was not eyeballed against a live core web UI in this environment — the flags use exactly the mechanism core already ships.Required for plugin changes
versioninplugins/<id>/manifest.json(1.4.0 → 1.4.1, with aversions[]changelog entry)class_nameinmanifest.jsonmatches the actual class inmanager.pyexactly (unchanged)entry_pointmatches the real file (unchanged)README.mdif config keys changed (no keys changed — N/A)config_schema.jsonis the source of truth for the web UI form — no new options added, onlyx-advancedrender hintsupdate_registry.pyrun directly;plugins.jsonsynced to 1.4.1)Checklist
CONTRIBUTING.mdCONTRIBUTING.mdandCODE_OF_CONDUCT.mdNotes for reviewer
What was flagged advanced, and why (one line each):
defaults.update_interval_seconds/defaults.season_cache_duration_seconds— poll-interval and cache-TTL tuning with sane defaults.defaults.show_odds— betting odds, off by default and niche;defaults.show_shots— README says leave off (ESPN doesn't publish the stat yet).scroll_settings.*(6 fields) — scroll fine-tuning;teams.exclude_teams— niche spoiler-protection list;teams.favorite_live_boost— rotation-weight knob;update_intervals.*(5 fields) — per-mode poll intervals;display_durations.*(5 fields) — per-league overrides of the basicdefaults.display_duration;display_options.show_odds/show_shots— off-by-default niche toggles;mode_durations.*— null-default overrides;dynamic_duration.*— opt-in duration fine-tuning, off by default.customization.*— per-element font overrides (6 text elements) and pixel-offset layout overrides (all default 0).Kept basic (never flagged):
enabled(required), league enable toggles +favorite_teams/favorite_teams_only/show_all_live,display_modes.*including the switch/scroll mode enums (headline feature in this plugin's README quick-start),filtering.recent/upcoming_games_to_show(also in the quick-start example),live_priority,defaults.display_duration, and theshow_records/show_rankingtoggles (rank badges are a headline feature).Note:
schema/manifest_schema.jsondoesn't exist in this repo checkout, so manifest validation is left to CI's manifest check.🤖 Generated with Claude Code
https://claude.ai/code/session_01LFNedFLmEcSHqSHG9Lwa62
Generated by Claude Code