feat(sports): sunset the bundled scroll fallback in the remaining six by ChuckBuilds · Pull Request #351 · ChuckBuilds/ledmatrix-plugins

ChuckBuilds · 2026-09-01T20:03:08Z

afl, basketball, lacrosse, nrl and soccer — completing B6 on this side. Stacked on #350 (→ #349 → main); retarget down the chain as they land.

Same shape as hockey (#346), football (#349) and baseball (#350): scroll_display_legacy.py deleted, guarded import collapsed to a plain one, manifests floored at 3.2.0. 3,622 lines of frozen copy removed, −3,203 net.

Checked before deleting, not after

Every orchestration method in all five frozen copies was diffed against the core's, looking specifically for logic the core lacks:

legacy-only	verdict
`if not self.scroll_helper` guards	Unreachable in core — it imports `ScrollHelper` unguarded and always constructs one. Legacy needed them because its own import was guarded and it sets `self.scroll_helper = None`.
`get_dynamic_duration`'s `return 60`	Same unreachable guard.
`_scroll_start_time`	Legacy reads it, core doesn't — but only to compute an average-FPS debug line, which core produces from `_fps_sample_start` via `_log_scroll_progress`.
`get_current_leagues` `.copy()` vs `list()`	Identical.
`_log_scroll_progress` throttling	Core has it.
`clear()`	Core resets strictly more state.

None is behaviour the core is missing. Baseball's px/frame heuristic was the only genuine one across all eight, and #350 handled it.

Two tests were leaning on the guard

Both are worth naming, because the sunset is what exposed them.

lacrosse/test_lacrosse_plugin.py stubs the host src modules so the plugin imports without a core. The list included src.common.scroll_helper but not src.common.sports_scroll — the guard used to swallow that. Now stubbed, with real classes rather than None, since ScrollDisplay subclasses one at module level (a None fails with "NoneType takes no arguments").

soccer/test_live_screens.py is the more interesting one. It installs a stub src package to fake src.logo_downloader — which shadowed the core entirely. So its guarded import had been falling back, and the test has been exercising the frozen copy rather than the class that ships, since B5. The stub now carries a __path__ into the real core so only logo_downloader is faked. Driving the real class then surfaced a missing display_width on its hand-built object — an attribute the legacy path never read.

That is the same failure mode as football's show_odds in #348: a hand-built double drifting from the code it stands in for, hidden because the object silently took a different path.

Verification

Every method and class constant survives the de-indent byte-for-byte in all five, separator icons included (NBA_/NCAA_/WNBA_/MARCH_MADNESS_SEPARATOR_ICON, NCAA_LACROSSE_SEPARATOR_ICON, SCROLL_CONFIG_KEY, SCROLL_LEAGUE_KEYS, _SCHEMA_CARD_WIDTH). Review with git diff -w.
112 safety-harness renders pass — 24 each for afl, basketball, nrl and soccer, 16 for lacrosse.
Five repo gates pass: check_scroll_adoption (+ 17-case self-test), check_manifest_version_fields, check_module_collisions, check_selection_settings.
Fleet: 225 passed, 2 skipped, 0 failed.

Where B6 stands after this

SUNSET_PLUGINS names seven. Hockey is the eighth — its sunset (#346) merged into #333 rather than main, so it arrives with that branch rather than through this chain.

⚠️ #333 is currently CONFLICTING and still a draft, three commits behind main (#345, #347, #348). It needs re-resolving before it can land, and it now carries hockey's sunset with it. Worth doing carefully — the same staleness bit #349 once already, where a version bump chosen an hour earlier had gone backwards.

🤖 Generated with Claude Code

https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9

afl, basketball, lacrosse, nrl and soccer. Same shape as hockey (#346), football (#349) and baseball (#350): scroll_display_legacy.py deleted, the guarded import of the core's src.common.sports_scroll collapsed to a plain one, manifests floored at 3.2.0. 3,622 lines of frozen copy removed. Checked before deleting, not after. Every orchestration method in all five frozen copies was diffed against the core's, looking for logic the core lacks: - `if not self.scroll_helper` guards -- unreachable in core, which imports ScrollHelper unguarded and always constructs one. Legacy needed them because its own import was guarded and it sets self.scroll_helper = None. - `get_dynamic_duration`'s `return 60` fallback -- same unreachable guard. - `_scroll_start_time` -- legacy reads it, core does not, but only to compute an average-FPS debug line that core produces from _fps_sample_start instead. - `get_current_leagues` returning `.copy()` vs `list()` -- identical. - `_log_scroll_progress` throttling -- core has it. - `clear()` -- core resets strictly more state. None is a behaviour the core is missing. Baseball's px/frame heuristic was the only real one across all eight, and it was handled in #350. Two tests were relying on the guard, and both are worth naming because the sunset is what exposed them: - lacrosse/test_lacrosse_plugin.py stubs the host `src` modules so the plugin imports without a core, and the list did not include src.common.sports_scroll -- the guard used to swallow that. Stubbed now, with real classes rather than None, since ScrollDisplay subclasses one at module level. - soccer/test_live_screens.py installs a stub `src` package to fake src.logo_downloader, which SHADOWED the core. So its guarded import had been falling back, and the test has been exercising the frozen copy rather than the class that ships -- since B5. The stub now carries a __path__ into the real core so only logo_downloader is faked. Driving the real class then surfaced a missing display_width on its hand-built object, which the legacy path never read. Verified: every method and class constant survives the de-indent byte-for-byte in all five, separator icons included; 112 safety-harness renders pass (24 each for afl, basketball, nrl and soccer, 16 for lacrosse); five repo gates pass; fleet is 225 passed, 2 skipped, 0 failed. SUNSET_PLUGINS names seven. Hockey is the eighth and its sunset (#346) merged into #333 rather than main, so it arrives with that branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9

coderabbitai · 2026-09-01T20:03:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 12917365-6596-4d38-9a66-ff60a57074ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codacy-production · 2026-09-01T20:04:19Z

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results

ErrorProne 1 high

View in Codacy

🟢 Metrics 430 complexity

Metric Results

Complexity 430

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

Hockey joins this PR so it is not stranded. Its sunset previously lived only in #346, which merged into #333's branch rather than main -- and #333 is superseded by #353, which does not carry the sunset. Closing #333 without this would leave hockey the one scoreboard of eight still shipping a fallback. Same change as the other seven: scroll_display_legacy.py deleted (703 lines), the guarded import collapsed to a plain one, floor raised to 3.2.0. test_core_fallback.py -> test_core_scroll.py, identical to afl's but for the Run: path. Bumped to 1.22.0 rather than 1.21.0 so it clears every version hockey currently holds anywhere: 1.20.3 on main, 1.21.0 on #353's branch. A floor is only meaningful on a version that can actually supersede what users have. SUNSET_PLUGINS now names all eight, which is the point of listing it rather than inferring it -- the set is a statement that the sunset holds, and it is now true of the whole fleet. Also brings docs/plugin-development/08-shared-sports-code.md up to date. Its sunset rule still read "Until condition 3 holds, keep the guarded try-core/except-local import", which was correct in August and is now the opposite of what the fleet does. Condition 3 holds for src.common.sports_scroll: the store refuses on all three routes in -- install_plugin (core #431/#433), the git-pull branch of update_plugin (#508) and install_from_url (#510). The rule now says to keep the guard for modules that have NOT been through a sunset, to drop it along with the copy for those that have, and to raise the floor in the same commit as the deletion. The instruction to keep it in step with the core doc "in the same PR" is corrected too: they are in different repositories, so that was never possible. Verified: all four separator-icon constants and every method survive the de-indent byte-for-byte; hockey 19 passed, 0 failed; 16 safety-harness renders pass; five repo gates pass, with check_scroll_adoption now reporting 8 sunset plugins free of a fallback; fleet 225 passed, 2 skipped, 0 failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9

ChuckBuilds · 2026-09-02T02:06:43Z

Hockey added — this now completes B6 across all eight

Hockey's sunset previously lived only in #346, which merged into #333's branch rather than main. Since #353 supersedes #333 and does not carry the sunset (its scroll_display_legacy.py is still present, floor still 2.0.0), closing #333 would have left hockey the one scoreboard of eight still shipping a fallback. So it moves here.

Same change as the other seven: 703 lines deleted, guard collapsed, floor 3.2.0, test_core_fallback.py → test_core_scroll.py.

Bumped to 1.22.0, not 1.21.0, so it clears every version hockey currently holds anywhere — 1.20.3 on main, 1.21.0 on #353's branch. A floor only means something on a version that can actually supersede what users have.

SUNSET_PLUGINS now names all eight, and check_scroll_adoption reports 8 sunset plugin(s) still free of one.

Also: the sunset rule doc was saying the opposite of what we do

docs/plugin-development/08-shared-sports-code.md still read:

Until condition 3 holds, keep the guarded try-core/except-local import — the fallback is the only real protection.

True in August, and now the reverse of what the whole fleet does. Condition 3 does hold for src.common.sports_scroll: the store refuses on all three routes in — install_plugin (#431/#433), the git-pull branch of update_plugin (#508), and install_from_url (#510).

Rewritten to say: keep the guard for modules that have not been through a sunset; drop it along with the copy for those that have; raise the floor in the same commit as the deletion; and add the plugin to SUNSET_PLUGINS in the same PR. Also corrected the instruction to keep it in step with the core doc "in the same PR" — they are in different repositories, so that was never possible.

Verification

All four separator-icon constants and every method survive the de-indent byte-for-byte.
hockey: 19 passed, 0 failed; 16 safety-harness renders pass.
Five repo gates pass.
Fleet: 225 passed, 2 skipped, 0 failed.

Note on #333

With hockey here, #333 can be closed — everything in it is either superseded by #353 or carried here. Worth confirming before you close it, since it is the only other place hockey's sunset exists.

* feat(football): sunset the bundled scroll fallback, floor at 3.2.0 scroll_display_legacy.py is deleted and the guarded import of the core's src.common.sports_scroll collapses to a plain one, with the manifest floored at 3.2.0 to match. Keeping the try/except with nothing behind it would name the missing scroll_display_legacy rather than the core module actually absent, which is the single log line a user gets before the scoreboard stops appearing. 709 lines removed. Football is the one plugin where this is not a pure deletion, and that deserved measuring rather than asserting. Everywhere else the frozen copy and the live path are method-for-method identical; here _default_game_card_width diverged. The frozen one returns max(128, display_height * 2 + 40); the adopted one measures the score gap with a throwaway GameRenderer and converges, which is what stopped the score being drawn across the logos on tall cards. Built both classes and compared across every supported panel: panel legacy core delta 64x32 128 128 same 128x32 128 128 same 256x32 128 128 same 64x64 168 176 +8 128x64 168 176 +8 256x64 168 176 +8 128x96 232 240 +8 256x128 296 304 +8 Identical on every 32-tall panel, 8px wider on taller ones, in classic and adaptive layout alike. That difference only ever reached users on a pre-3.2.0 core, because everyone on 3.2.0 or newer has been on the measured path since 2.29.0 -- the fallback was never the modern path's behaviour. And those users keep the version they have, since the new floor stops this one reaching them. So the population that could observe the change is exactly the population that will not receive it: no board changes what it draws. Recorded in the manifest notes anyway, because "removed dead code" would be false and the next person deserves the real answer. test_core_fallback.py -> test_core_scroll.py, the same rewrite hockey got in #346 (the two files were byte-identical but for the Run: path, so this is that rewrite with one substitution). It asserts the sunset rather than the fallback: the import is top-level and unguarded, no copy exists or is imported, the base is the core class by identity, an old core fails naming exactly src.common.sports_scroll, and the manifest floors at 3.2.0 or above. check_scroll_adoption.py gains sunset_violations and SUNSET_PLUGINS, the same gate #346 adds for hockey. offending_classes is left byte-identical so its eleven pinned cases keep meaning what they mean. The existing check asks whether the fallback was INLINED and structurally cannot ask whether it still EXISTS -- it opens scroll_display.py and nothing else -- so a resurrected file or a returned guard would both pass it silently. #346 and this PR each name their own plugin; whichever lands second resolves a one-line conflict in the set. Verified: separator-icon constants and every method survive the de-indent byte-for-byte (NFL_SEPARATOR_ICON, NCAA_FB_SEPARATOR_ICON, SCROLL_LEAGUE_KEYS, _SCHEMA_CARD_WIDTH); 24 of 24 safety-harness renders pass across eight panel sizes and three modes; the four repo gates pass; football's suite is 40 passed, 1 skipped, 0 failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9 * feat(baseball): sunset the bundled scroll fallback, standardise on the core The third B6 sunset, after hockey (#346) and football (#349). Same shape: scroll_display_legacy.py deleted, the guarded import of the core's src.common.sports_scroll collapsed to a plain one, manifest floored at 3.2.0. Keeping the try/except with nothing behind it would name the missing scroll_display_legacy rather than the core module actually absent, which is the single log line a user gets before the scoreboard stops appearing. 764 lines removed. Baseball is the one plugin whose frozen copy carried orchestration logic the core does not have, and that is the point of doing it deliberately rather than by deletion. Its _configure_scroll_helper had an extra branch: when scroll_speed * scroll_delay fell outside the 0.1-5.0 pixels-per-frame window but scroll_speed alone sat inside it, it reinterpreted scroll_speed as pixels-per-FRAME rather than the pixels-per-second the setting is documented as. Verified by running both implementations: scroll_speed delay legacy core 50.0 0.01 0.5 0.5 (the default -- agree) 1.0 0.01 1.0 0.1 10x 2.0 0.01 2.0 0.1 20x 0.5 0.01 0.5 0.1 5x Checked across all eight lineages: baseball's was the only copy with it. The core's behaviour is the one to keep. The branch silently ignored the unit the setting is defined in and ran an order of magnitude faster than asked; the core honours the configured pixels-per-second and clamps to the same window, which is what every other scoreboard already does. Re-measured after the collapse: baseball now matches the core exactly at every point in the range above. In practice this reaches nobody. The branch only ever ran on a pre-3.2.0 core; everyone on 3.2.0 or newer has been on the core path since 1.22.0, and the new floor stops this version reaching the rest. Recorded in the manifest anyway, because a silently retired behaviour is worse than a documented one. test_core_fallback.py -> test_core_scroll.py, the same rewrite hockey and football got. SUNSET_PLUGINS grows to three. Verified: all three separator-icon constants and every method survive the de-indent byte-for-byte (MLB_SEPARATOR_ICON, MILB_SEPARATOR_ICON, NCAA_BASEBALL_SEPARATOR_ICON, SCROLL_LEAGUE_KEYS, _SCHEMA_CARD_WIDTH); 24 of 24 safety-harness renders pass across eight panel sizes; the four repo gates pass; baseball's suite is 26 passed, 0 skipped, 0 failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9 * feat(sports): sunset the bundled scroll fallback in the remaining six (#351) * feat(sports): sunset the bundled scroll fallback in the last five afl, basketball, lacrosse, nrl and soccer. Same shape as hockey (#346), football (#349) and baseball (#350): scroll_display_legacy.py deleted, the guarded import of the core's src.common.sports_scroll collapsed to a plain one, manifests floored at 3.2.0. 3,622 lines of frozen copy removed. Checked before deleting, not after. Every orchestration method in all five frozen copies was diffed against the core's, looking for logic the core lacks: - `if not self.scroll_helper` guards -- unreachable in core, which imports ScrollHelper unguarded and always constructs one. Legacy needed them because its own import was guarded and it sets self.scroll_helper = None. - `get_dynamic_duration`'s `return 60` fallback -- same unreachable guard. - `_scroll_start_time` -- legacy reads it, core does not, but only to compute an average-FPS debug line that core produces from _fps_sample_start instead. - `get_current_leagues` returning `.copy()` vs `list()` -- identical. - `_log_scroll_progress` throttling -- core has it. - `clear()` -- core resets strictly more state. None is a behaviour the core is missing. Baseball's px/frame heuristic was the only real one across all eight, and it was handled in #350. Two tests were relying on the guard, and both are worth naming because the sunset is what exposed them: - lacrosse/test_lacrosse_plugin.py stubs the host `src` modules so the plugin imports without a core, and the list did not include src.common.sports_scroll -- the guard used to swallow that. Stubbed now, with real classes rather than None, since ScrollDisplay subclasses one at module level. - soccer/test_live_screens.py installs a stub `src` package to fake src.logo_downloader, which SHADOWED the core. So its guarded import had been falling back, and the test has been exercising the frozen copy rather than the class that ships -- since B5. The stub now carries a __path__ into the real core so only logo_downloader is faked. Driving the real class then surfaced a missing display_width on its hand-built object, which the legacy path never read. Verified: every method and class constant survives the de-indent byte-for-byte in all five, separator icons included; 112 safety-harness renders pass (24 each for afl, basketball, nrl and soccer, 16 for lacrosse); five repo gates pass; fleet is 225 passed, 2 skipped, 0 failed. SUNSET_PLUGINS names seven. Hockey is the eighth and its sunset (#346) merged into #333 rather than main, so it arrives with that branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9 * feat(hockey): sunset the bundled scroll fallback, completing B6 Hockey joins this PR so it is not stranded. Its sunset previously lived only in #346, which merged into #333's branch rather than main -- and #333 is superseded by #353, which does not carry the sunset. Closing #333 without this would leave hockey the one scoreboard of eight still shipping a fallback. Same change as the other seven: scroll_display_legacy.py deleted (703 lines), the guarded import collapsed to a plain one, floor raised to 3.2.0. test_core_fallback.py -> test_core_scroll.py, identical to afl's but for the Run: path. Bumped to 1.22.0 rather than 1.21.0 so it clears every version hockey currently holds anywhere: 1.20.3 on main, 1.21.0 on #353's branch. A floor is only meaningful on a version that can actually supersede what users have. SUNSET_PLUGINS now names all eight, which is the point of listing it rather than inferring it -- the set is a statement that the sunset holds, and it is now true of the whole fleet. Also brings docs/plugin-development/08-shared-sports-code.md up to date. Its sunset rule still read "Until condition 3 holds, keep the guarded try-core/except-local import", which was correct in August and is now the opposite of what the fleet does. Condition 3 holds for src.common.sports_scroll: the store refuses on all three routes in -- install_plugin (core #431/#433), the git-pull branch of update_plugin (#508) and install_from_url (#510). The rule now says to keep the guard for modules that have NOT been through a sunset, to drop it along with the copy for those that have, and to raise the floor in the same commit as the deletion. The instruction to keep it in step with the core doc "in the same PR" is corrected too: they are in different repositories, so that was never possible. Verified: all four separator-icon constants and every method survive the de-indent byte-for-byte; hockey 19 passed, 0 failed; 16 safety-harness renders pass; five repo gates pass, with check_scroll_adoption now reporting 8 sunset plugins free of a fallback; fleet 225 passed, 2 skipped, 0 failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9 --------- Co-authored-by: Claude <noreply@anthropic.com> * fix(tests): drop a dead import, and name the missing core where it is missed Two review findings, both valid. **`import types` was unused** in every copy of test_core_scroll.py. Inherited rather than introduced: the original test_core_fallback.py never used it either, and football's copy already on main carries it too. Removed from all eight, football's included, so the eight stay byte-identical bar the `Run:` path -- that identity is the property that makes them one rewrite replicated rather than eight files to keep in step. It was the only F401 in the set. **test_live_screens.py stubbed `src` even when it could not find a core.** The stub only receives a `__path__` when discovery succeeds; without one it shadows the real package, and scroll_display's now-unguarded import fails with "'src' is not a package" -- naming `src` rather than the core module, which is exactly the misleading symptom the comment three lines above warns about. It now says so at the discovery point instead. Skips rather than fails, exit 2 per run_plugin_tests.py's convention: no core on the path is a "cannot run here", not a broken plugin. Verified both ways -- with a core the file passes as before, without one it exits 2 and the message names the real cause and the fix. Fleet 246 passed, 2 skipped, 0 failed; four gates pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9 --------- Co-authored-by: Claude <noreply@anthropic.com>

The twenty methods below were byte-identical in all eight scoreboards. They now live in core src.common.sports_card (LEDMatrix#513) and each plugin delegates: colour _font_color _element_color _coerce_rgb _score_color_for _recent_score_color _favorite_result settings _scroll_card_option _upcoming_center_mode _vs_text date/time _format_game_date _format_game_time _weekday_for _card_tzinfo favourites _favorite_teams_for _side_is_favorite _side_score font sizing _crisp_size _schema_font_size _resolve_font_size _unshare_element_fonts 245 lines leave each plugin, 1,960 in total. One fix to any of that now reaches every scoreboard instead of needing eight identical edits, and a new scoreboard gets them by importing one module. Each method keeps its name, signature and decorators and delegates the body, so no call site moves and nothing that overrode one loses the ability to. The plugins' six constant tables are gone in favour of the shared ones, which were verified identical first. Football's _crisp_size is replaced by the seven-plugin variant. The two agree on every real input; the difference is a `not desired` guard that stops a None size raising TypeError, so football only loses a crash path. **Verification.** All 176 safety-harness renders across the eight plugins are byte-identical to the pre-change baseline -- 24 each for the six in-season sports, 16 each for hockey and lacrosse -- captured with a frozen clock and compared with cmp, not by eye. Fleet 246 passed, 2 skipped, 0 failed. Four repo gates pass. Two tests were leaning on a stubbed `src` and are fixed the way #351 fixed soccer's: football's test_score_celebration.py stubbed `src` with no __path__, so the stub shadowed the core and the new top-level import failed naming `src` rather than the module wanted; lacrosse's test_lacrosse_plugin.py stubs its host modules explicitly and now loads the real sports_card, since a bare stub would satisfy the import and fail at the first call. **The floor rises to 3.3.0** -- the helper is a new core module, so it first ships in that release. This must not merge before 3.3.0 is cut, or the store will refuse to install or update these eight. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9

* refactor(sports): delegate the shared card helpers to the core The twenty methods below were byte-identical in all eight scoreboards. They now live in core src.common.sports_card (LEDMatrix#513) and each plugin delegates: colour _font_color _element_color _coerce_rgb _score_color_for _recent_score_color _favorite_result settings _scroll_card_option _upcoming_center_mode _vs_text date/time _format_game_date _format_game_time _weekday_for _card_tzinfo favourites _favorite_teams_for _side_is_favorite _side_score font sizing _crisp_size _schema_font_size _resolve_font_size _unshare_element_fonts 245 lines leave each plugin, 1,960 in total. One fix to any of that now reaches every scoreboard instead of needing eight identical edits, and a new scoreboard gets them by importing one module. Each method keeps its name, signature and decorators and delegates the body, so no call site moves and nothing that overrode one loses the ability to. The plugins' six constant tables are gone in favour of the shared ones, which were verified identical first. Football's _crisp_size is replaced by the seven-plugin variant. The two agree on every real input; the difference is a `not desired` guard that stops a None size raising TypeError, so football only loses a crash path. **Verification.** All 176 safety-harness renders across the eight plugins are byte-identical to the pre-change baseline -- 24 each for the six in-season sports, 16 each for hockey and lacrosse -- captured with a frozen clock and compared with cmp, not by eye. Fleet 246 passed, 2 skipped, 0 failed. Four repo gates pass. Two tests were leaning on a stubbed `src` and are fixed the way #351 fixed soccer's: football's test_score_celebration.py stubbed `src` with no __path__, so the stub shadowed the core and the new top-level import failed naming `src` rather than the module wanted; lacrosse's test_lacrosse_plugin.py stubs its host modules explicitly and now loads the real sports_card, since a bare stub would satisfy the import and fail at the first call. **The floor rises to 3.3.0** -- the helper is a new core module, so it first ships in that release. This must not merge before 3.3.0 is cut, or the store will refuse to install or update these eight. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RRtqXDCnvnY6EQwhT5CV9 * feat(scoreboards): take the scroll-card geometry from the core mixin Companion to the sports_card adoption in the previous commit, and the second half of the same idea. That one shared the settings lookups; this one shares the geometry those settings drive. Nine methods -- _score_reserve_width, _center_gap_width, _logo_slot_width, _logo_cache_key, _layout_offset, _upcoming_date_and_time, _draw_upcoming_center, _draw_upcoming_game_status and set_rankings_cache -- plus five class constants were being maintained in eight copies. They now come from src.common.sports_game_renderer.SportsGameRendererMixin (ChuckBuilds/LEDMatrix#514). Comparing executable ASTs before the change, 67 of the 70 bodies were already identical to the mixin's. The three that were not stay behind as ordinary overrides: baseball's _logo_slot_width and _draw_upcoming_game_status, and hockey's _upcoming_date_and_time. Of the constants only _SCORE_PROBE varies, so afl and basketball -- the two leagues that reach three digits a side -- keep theirs and the rest inherit. This rides in the same version bump as the sports_card adoption rather than taking a second one. Both need core 3.3.0, so splitting them would mean shipping every scoreboard twice for one floor. Also drops the datetime/timezone/ZoneInfo imports that the previous commit orphaned when the date and time formatting moved to sports_card. Hockey still parses timestamps in its override, so it keeps them. Nothing drawn changes: the bodies were moved rather than rewritten. * test(lacrosse): load the real geometry mixin instead of a bare src.common stub test_lacrosse_plugin.py stubs "src.common" as a plain ModuleType, so `from src.common.sports_game_renderer import SportsGameRendererMixin` in game_renderer.py could not resolve and the import check failed with "'src.common' is not a package". It only bites when the test runs standalone. Under scripts/run_plugin_tests.py something has already imported the real src.common package, so the sys.modules.setdefault() is a no-op and the real package wins -- which is why the fleet reported this file passing while running it directly failed. The previous commit's sports_card had the same problem and was fixed by loading the real module by hand. Rather than paste that block a second time it now loops over both names, so the next core helper needs no third edit. Unrelated and pre-existing: 7-segment-clock/test_render_polarity.py fails on pristine origin/main (009a9e7) too, so it is not from this branch. * test: guard the scroll/Vegas card, which no gate rendered The plugin safety harness drives every scoreboard in `switch` mode, so its renders come from the full-screen scorebug in sports.py. game_renderer.py -- the scroll/Vegas card renderer -- is imported but never called. Replacing render_game_card, _draw_upcoming_center, _center_gap_width and _logo_slot_width with functions that raise leaves all 16 of hockey's harness renders passing and byte-identical to the clean tree. Adding a harness.json variant with `*_display_mode: "scroll"` does not close it either: those renders come out byte-identical to the switch ones, so the mode never reaches the card path from there. The cost of the gap is concrete. Both halves of this branch -- the sports_card helpers and the geometry mixin -- were verified as "byte-identical across 176 renders" while not one of those renders touched the file being changed. B5 shipped four of eight scoreboards with scroll mode broken for the same reason, with every gate green. This drives GameRenderer directly, which is the real path, over 8 plugins x 3 panel sizes x 3 game types = 72 cards, and compares to goldens committed beside each plugin. It picks up the existing scripts/test_*.py convention, so CI discovers it with no workflow change. Verified it bites: widening the centre gap by 2px in the core mixin fails 48 of the 72 cards. On the clean tree all 72 pass. Two details that are easy to get wrong and are deliberate here: - It asserts the card COUNT, not just the mismatch count. A comparison whose inputs quietly went missing reports zero differences and reads as a pass -- that exact failure produced a green "identical: 24, differing: 0" earlier in this work, against a baseline that had never rendered. - It chdir()s to the core. The plugins' default logo_dir values are relative, so anywhere else renders logo-less cards that still compare clean against each other -- a pass that proves nothing. * test: pull the scroll-card guard out of this PR The guard fails in CI: 21 of its 72 goldens differ there, on the same Pillow 12.3.0, so it is not a rasterisation difference. It renders with real logo assets loaded from the core checkout, and those vary -- main recently dropped case-colliding duplicate league logos -- so the goldens encode one machine's asset set rather than the plugin's rendering. That is a flaw in the guard, not in this branch's consolidation, and a gate that fails on its own inputs should not block the change it was written to protect. It comes back in its own PR, rebuilt to be environment-independent: either rendering without logos, or comparing HEAD against the merge base in the same environment instead of against committed goldens. Nothing else changes. This branch is still verified against main by the 176 safety-harness renders, which are byte-identical, and by the plugin fleet. --------- Co-authored-by: Claude <noreply@anthropic.com>

ChuckBuilds mentioned this pull request Sep 1, 2026

feat(sports): fill the other slots with games worth watching, and make the settings take effect #333

Closed

ChuckBuilds changed the title ~~feat(sports): sunset the bundled scroll fallback in the last five~~ feat(sports): sunset the bundled scroll fallback in the remaining six Sep 2, 2026

ChuckBuilds merged commit 1fd8974 into sunset/baseball-scroll-fallback Sep 2, 2026
3 of 4 checks passed

ChuckBuilds mentioned this pull request Sep 2, 2026

feat(sports): land the seven sunsets that never reached main #354

Merged

ChuckBuilds mentioned this pull request Sep 2, 2026

refactor(sports): delegate the shared card helpers to the core #359

Merged

Navigation Menu

Uh oh!

feat(sports): sunset the bundled scroll fallback in the remaining six - #351

feat(sports): sunset the bundled scroll fallback in the remaining six#351
ChuckBuilds merged 2 commits into
sunset/baseball-scroll-fallbackfrom
sunset/remaining-five-scroll-fallback

ChuckBuilds commented Sep 1, 2026

Uh oh!

coderabbitai Bot commented Sep 1, 2026 •

edited

Loading

Review skipped

Uh oh!

codacy-production Bot commented Sep 1, 2026 •

edited

Loading

Uh oh!

ChuckBuilds commented Sep 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ChuckBuilds commented Sep 1, 2026

Checked before deleting, not after

Two tests were leaning on the guard

Verification

Where B6 stands after this

Uh oh!

coderabbitai Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codacy-production Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

ChuckBuilds commented Sep 2, 2026

Hockey added — this now completes B6 across all eight

Also: the sunset rule doc was saying the opposite of what we do

Verification

Note on #333

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Sep 1, 2026 •

edited

Loading

codacy-production Bot commented Sep 1, 2026 •

edited

Loading