Skip to content

Railcraft compat - #384

Open
LonelyxiyaOVO wants to merge 19 commits into
CleanroomMC:masterfrom
LonelyxiyaOVO:Railcraft-compat
Open

Railcraft compat#384
LonelyxiyaOVO wants to merge 19 commits into
CleanroomMC:masterfrom
LonelyxiyaOVO:Railcraft-compat

Conversation

@LonelyxiyaOVO

@LonelyxiyaOVOLonelyxiyaOVO commented May 5, 2026

Copy link
Copy Markdown

bro Railcraft compat

Wizzerinus
Wizzerinus reviewed May 5, 2026
View reviewed changes

@WizzerinusWizzerinus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer of this mod, just mentioning some things I noticed ;)

Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/CokeOven.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/FluidFuels.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/RollingMachine.java
WaitingIdly
WaitingIdly requested changes May 5, 2026
View reviewed changes

@WaitingIdlyWaitingIdly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few other things:

  1. instead of magic numbers as defaults, use the railcraft defaults directly - ie IRollingMachineCrafter.DEFAULT_PROCESS_TIME.
  2. run /gs generateWiki or enabling dev_generate_wiki in gradle.properties - check the log to ensure no warnings/missing lang keys.
  3. wizz also brought up great points, listen to those.

Comment threadgradle.properties
Comment threaddependencies.gradle
Comment threadexamples/postInit/generated/railcraft_example.groovy Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/RockCrusher.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/RollingMachine.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/RollingMachine.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/RollingMachine.java Outdated
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/RollingMachine.java Outdated
WaitingIdly
WaitingIdly requested changes May 5, 2026
View reviewed changes
Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java Outdated
Comment on lines +33 to +46
if (time <= 0) {
GroovyLog.msg("Error adding Railcraft Blast Furnace recipe")
.error()
.add("time must be greater than 0, got: {}", time)
.post();
return null;
}
if (slag < 0) {
GroovyLog.msg("Error adding Railcraft Blast Furnace recipe")
.error()
.add("slag must be non-negative, got: {}", slag)
.post();
return null;
}

@WaitingIdlyWaitingIdlyMay 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validate in the builder

Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/BlastFurnace.java Outdated
Comment on lines +141 to +148
if (time <= 0) {
msg.add("time must be greater than 0, got: {}", time);
time = IBlastFurnaceCrafter.SMELT_TIME;
}
if (slag < 0) {
msg.add("slag must be non-negative, got: {}", slag);
slag = 1;
}

@WaitingIdlyWaitingIdlyMay 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there are any messages, the validation fails. just do

Suggested change
if (time <= 0) {
msg.add("time must be greater than 0, got: {}", time);
time = IBlastFurnaceCrafter.SMELT_TIME;
}
if (slag < 0) {
msg.add("slag must be non-negative, got: {}", slag);
slag = 1;
}
msg.add(time <= 0, "time must be greater than 0, got: {}", time);
msg.add(slag < 0, "slag must be non-negative, got: {}", slag);

Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/CokeOven.java Outdated
Comment on lines +116 to +117
@Property
private FluidStack fluid;

@WaitingIdlyWaitingIdlyMay 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of this, use fluidOutput from parent

Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/FluidFuels.java Outdated
@RegistryDescription
public class FluidFuels extends VirtualizedRegistry<FluidFuels.FuelEntry> {

private final Map<String, Integer> backupFuels = new HashMap<>();

@WaitingIdlyWaitingIdlyMay 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now completely unused

Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/RollingMachine.java Outdated

public boolean remove(IRollingMachineCrafter.IRollingRecipe recipe) {
return Crafters.rollingMachine().getRecipes().removeIf(r -> {
if (r == recipe) {

@WaitingIdlyWaitingIdlyMay 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if r == recipe well you can just do addBackup(recipe) + Crafters.rollingMachine().getRecipes().remove(recipe) then

Comment threadbuildscript.properties Outdated
# Version of your mod.
# This field can be left empty if you want your mod's version to be determined by the latest git tag instead.
modVersion = 1.4.3
modVersion = 1.4.4

@WaitingIdlyWaitingIdlyMay 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo changing the version

@LonelyxiyaOVO

LonelyxiyaOVO commented May 6, 2026

Copy link
Copy Markdown
Author

I've fixed it. Please take a look and let me know if there are any issues

WaitingIdly
WaitingIdly requested changes May 6, 2026
View reviewed changes

@WaitingIdlyWaitingIdly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one new thing. please actually resolve the other issues you have marked as resolved, but have not resolved.

Comment threadsrc/main/java/com/cleanroommc/groovyscript/compat/mods/railcraft/CokeOven.java Outdated
@LonelyxiyaOVO

LonelyxiyaOVO commented May 6, 2026

Copy link
Copy Markdown
Author

check

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WaitingIdlyWaitingIdlyWaitingIdly requested changes
+1 more reviewer
@WizzerinusWizzerinusWizzerinus left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LonelyxiyaOVO@WaitingIdly@Wizzerinus