Skip to content

Datafusion v28 - #127

Merged
nickitat merged 4 commits into
ClickHouse:mainfrom
jychen7:datafusion-7108
Jul 31, 2023
Merged

Datafusion v28#127
nickitat merged 4 commits into
ClickHouse:mainfrom
jychen7:datafusion-7108

Conversation

@jychen7

@jychen7jychen7 commented Jul 29, 2023

Copy link
Copy Markdown
Contributor

jychen7
jychen7 commented Jul 29, 2023
View reviewed changes
Comment threaddatafusion/results/single.json
[0.638, 0.563, 0.585],
[3.278, 3.119, 2.940],
[7.710, 4.401, 4.398],
[null, null, null],

@jychen7jychen7Jul 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Notably, apache/datafusion#6904 and related PRs for faster grouping performance show 2-3x performance improvements

@nickitatnickitat self-assigned this Jul 30, 2023
@nickitat

nickitat commented Jul 30, 2023

Copy link
Copy Markdown
Member

hi @jychen7
thanks for the contribution
could you pls update index.html - to do this you need to run generate-results.sh in the root ClickBench dir

jychen7
jychen7 commented Jul 31, 2023
View reviewed changes
Comment threadindex.html
@jychen7

jychen7 commented Jul 31, 2023

Copy link
Copy Markdown
ContributorAuthor

@nickitat sure, done

@nickitat
nickitat merged commit 643abc3 into ClickHouse:mainJul 31, 2023
@DandandanDandandan mentioned this pull request Nov 29, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nickitatnickitat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jychen7@nickitat