Uh oh!
There was an error while loading. Please reload this page.
Bump ClickHouse.Driver to 1.4.0 - #65
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
alex-clickhouseforce-pushed
the
alex-clickhouse/bump-driver-1.4.0-rc1
branch
from
September 2, 2026 08:00
674d6f6 to
5201686Comparealex-clickhouse
marked this pull request as ready for review
September 2, 2026 08:14
Moves the driver pin from 1.3.0 to the final 1.4.0 release. All three project files move together — src, Tests and FunctionalTests — since a split pin produces an NU1605 downgrade error. Recorded under v0.3.1 (Unreleased) in both CHANGELOG.md and RELEASENOTES.md, per AGENTS.md's instruction to keep public docs current. The notes call out the two driver behaviour changes a consumer could notice: query responses are now zstd-compressed rather than gzip by default (decoded transparently), and reading a column from ClickHouseDataReader with no current row now throws InvalidOperationException. EF Core always positions the reader before materializing, so the latter only reaches code that uses the underlying ClickHouseConnection directly. Verified locally against driver 1.4.0 (resolved version confirmed in project.assets.json for every project, not assumed): - Restore: no NuGet warnings, no NU1605 downgrade. - Build: BUILD SUCCEEDED, 0 errors, 326 warnings with --no-incremental. 326 is this repo's pre-existing warning baseline (predominantly EF1001, inherent to implementing an EF Core provider), so the delta is zero. - EFCore.ClickHouse.Tests: 661 passed, 0 failed, 0 skipped. - EFCore.ClickHouse.FunctionalTests: 323 passed, 0 failed, 4 skipped. The 4 skips are the pre-existing NorthwindJoinQueryClickHouseTest cases. Both suites run against a real ClickHouse via Testcontainers. No source changes were required. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
alex-clickhouseforce-pushed
the
alex-clickhouse/bump-driver-1.4.0-rc1
branch
from
September 2, 2026 09:07
5201686 to
060fdb2CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
ClickHouse.Driverfrom 1.3.0 to the final 1.4.0 release across allthree project files —
src,TestsandFunctionalTests. They have to movetogether; a split pin produces an
NU1605downgrade error.This PR originally validated
1.4.0-rc1. Now that 1.4.0 is on NuGet it has beenretargeted at the final release and re-verified from scratch — not just a
version-string swap. Real behaviour changed between rc1 and final, including
"throw instead of dropping data for overlapping JSON paths", a JSON parent-walk
fix, and a new insert-query-placement option that touched
IBatchSerializer.Why
Keep the provider on the current released driver, and confirm 1.4.0 is a clean
drop-in before downstream users hit it.
Testing
All local, against driver
1.4.0with the resolved version confirmed in everyproject's
project.assets.jsonrather than assumed.dotnet restore— no NuGet warnings, noNU1605downgrade.dotnet build --no-restore -c Release --no-incremental—0 errors, 326 warnings. 326 is this repo's pre-existing baseline
(predominantly
EF1001, which is inherent to implementing an EF Coreprovider), so the delta is zero. This repo deliberately does not set
TreatWarningsAsErrors.dotnet test --no-build -c Release:EFCore.ClickHouse.Tests— 661 passed, 0 failed, 0 skippedEFCore.ClickHouse.FunctionalTests— 323 passed, 0 failed, 4 skipped(the 4 skips are the pre-existing
NorthwindJoinQueryClickHouseTestcases)Both suites run against a real ClickHouse via Testcontainers, not mocks.
No source changes were required.
Changelog
Recorded under
v0.3.1 (Unreleased)in bothCHANGELOG.mdandRELEASENOTES.md, in each file's own voice, perAGENTS.md's instruction tokeep public docs current. Added as a new
### Dependenciessection, placed lastto match the existing section ordering.
The entries name the two driver behaviour changes a consumer could actually
notice: query responses are now zstd-compressed rather than gzip by default
(decoded transparently), and reading a column from
ClickHouseDataReaderwithno current row now throws
InvalidOperationException. EF Core always positionsthe reader before materializing, so the latter only reaches code that drops down
to the underlying
ClickHouseConnection.🤖 Generated with Claude Code