[Don't merge] Upgrade the Arrow to 16.1.0#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikitamikhaylov wants to merge 6 commits into from
Closed

[Don't merge] Upgrade the Arrow to 16.1.0 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
57986f2
Empty commit
nikitamikhaylov Oct 15, 2024
39e53db
Merge pull request #66 from copperybean/release-13.0.0
al13n321 May 21, 2024
45ea0d6
Merge pull request #47 from ClickHouse/fix-uninit-value-msan
Avogar Nov 3, 2023
fb031b0
Merge pull request #39 from ClickHouse/count-from-record-batch
Avogar Aug 9, 2023
21a89cf
Merge pull request #9 from taiyang-li/raw_orc_reader
Avogar Mar 1, 2022
4c22e00
Merge pull request #10 from taiyang-li/fix_pr_9
Avogar Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions cpp/src/arrow/adapters/orc/adapter.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -222,6 +222,11 @@ class ORCFileReader::Impl {
return Init();
}

virtual liborc::Reader* GetRawORCReader() {
return reader_.get();
}


Status Init() {
int64_t nstripes = reader_->getNumberOfStripes();
stripes_.resize(static_cast<size_t>(nstripes));
Expand DownExpand Up@@ -548,6 +553,10 @@ class ORCFileReader::Impl {
return NextStripeReader(batch_size, empty_vec);
}

liborc::Reader* ORCFileReader::GetRawORCReader() {
return impl_->GetRawORCReader();
}

private:
MemoryPool* pool_;
std::unique_ptr<liborc::Reader> reader_;
Expand All@@ -559,6 +568,15 @@ ORCFileReader::ORCFileReader() { impl_.reset(new ORCFileReader::Impl()); }

ORCFileReader::~ORCFileReader() {}

liborc::Reader* ORCFileReader::GetRawORCReader() {
return impl_->GetRawORCReader();
}

Status ORCFileReader::Open(const std::shared_ptr<io::RandomAccessFile>& file,
MemoryPool* pool, std::unique_ptr<ORCFileReader>* reader) {
return Open(file, pool).Value(reader);
}

Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
#ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK
Expand Down
14 changes: 14 additions & 0 deletions cpp/src/arrow/adapters/orc/adapter.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@
#include "arrow/type_fwd.h"
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
#include "arrow/adapters/orc/adapter_util.h"

namespace arrow {
namespace adapters {
Expand All@@ -53,6 +54,19 @@ class ARROW_EXPORT ORCFileReader {
public:
~ORCFileReader();

/// \brief Creates a new ORC reader.
///
/// \param[in] file the data source
/// \param[in] pool a MemoryPool to use for buffer allocations
/// \param[out] reader the returned reader object
/// \return Status
ARROW_DEPRECATED("Deprecated in 6.0.0. Use Result-returning overload instead.")
static Status Open(const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool,
std::unique_ptr<ORCFileReader>* reader);

/// \brief Get ORC reader from inside.
liborc::Reader* GetRawORCReader();

/// \brief Creates a new ORC reader
///
/// \param[in] file the data source
Expand Down
17 changes: 17 additions & 0 deletions cpp/src/arrow/ipc/reader.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1369,6 +1369,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
return total;
}

Result<int64_t> RecordBatchCountRows(int i) override {
DCHECK_GE(i, 0);
DCHECK_LT(i, num_record_batches());
ARROW_ASSIGN_OR_RAISE(auto outer_message,
ReadMessageFromBlock(GetRecordBatchBlock(i)));
auto metadata = outer_message->metadata();
const flatbuf::Message* message = nullptr;
RETURN_NOT_OK(
internal::VerifyMessage(metadata->data(), metadata->size(), &message));
auto batch = message->header_as_RecordBatch();
if (batch == nullptr) {
return Status::IOError(
"Header-type of flatbuffer-encoded Message is not RecordBatch.");
}
return batch->length();
}

Status Open(const std::shared_ptr<io::RandomAccessFile>& file, int64_t footer_offset,
const IpcReadOptions& options) {
owned_file_ = file;
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/arrow/ipc/reader.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,8 @@ class ARROW_EXPORT RecordBatchFileReader
/// \brief Computes the total number of rows in the file.
virtual Result<int64_t> CountRows() = 0;

virtual Result<int64_t> RecordBatchCountRows(int i) = 0;

/// \brief Begin loading metadata for the desired batches into memory.
///
/// This method will also begin loading all dictionaries messages into memory.
Expand Down
5 changes: 5 additions & 0 deletions cpp/src/arrow/util/bit_stream_utils.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -272,6 +272,11 @@ inline void GetValue_(int num_bits, T* v, int max_bytes, const uint8_t* buffer,
#pragma warning(push)
#pragma warning(disable : 4800)
#endif
if (ARROW_PREDICT_FALSE(*bit_offset >= 64)) {
auto msg = std::string("invalid bit offset: ") + std::to_string(*bit_offset);
msg += ", may be malformed num_bits: " + std::to_string(num_bits);
throw std::runtime_error(msg);
}
*v = static_cast<T>(bit_util::TrailingBits(*buffered_values, *bit_offset + num_bits) >>
*bit_offset);
#ifdef _MSC_VER
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/parquet/encoding.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2721,7 +2721,7 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
T min_delta_;
uint32_t mini_block_idx_;
std::shared_ptr<ResizableBuffer> delta_bit_widths_;
int delta_bit_width_;
int delta_bit_width_ = 0;

T last_value_;
};
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[Don't merge] Upgrade the Arrow to 16.1.0#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nikitamikhaylov
wants to merge
6
commits into

from

 Closed


[Don't merge] Upgrade the Arrow to 16.1.0
#67
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
57986f2

Empty commit


nikitamikhaylov Oct 15, 2024
39e53db

Merge pull request #66 from copperybean/release-13.0.0


al13n321 May 21, 2024
45ea0d6

Merge pull request #47 from ClickHouse/fix-uninit-value-msan


Avogar Nov 3, 2023
fb031b0

Merge pull request #39 from ClickHouse/count-from-record-batch


Avogar Aug 9, 2023
21a89cf

Merge pull request #9 from taiyang-li/raw_orc_reader


Avogar Mar 1, 2022
4c22e00

Merge pull request #10 from taiyang-li/fix_pr_9


Avogar Mar 21, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -222,6 +222,11 @@ class ORCFileReader::Impl {
 return Init();
 }

 virtual liborc::Reader* GetRawORCReader() {
 return reader_.get();
 }


 Status Init() {
 int64_t nstripes = reader_->getNumberOfStripes();
 stripes_.resize(static_cast<size_t>(nstripes));
Expand DownExpand Up@@ -548,6 +553,10 @@ class ORCFileReader::Impl {
 return NextStripeReader(batch_size, empty_vec);
 }

 liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
 }

 private:
 MemoryPool* pool_;
 std::unique_ptr<liborc::Reader> reader_;
Expand All@@ -559,6 +568,15 @@ ORCFileReader::ORCFileReader() { impl_.reset(new ORCFileReader::Impl()); }

ORCFileReader::~ORCFileReader() {}

liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
}

Status ORCFileReader::Open(const std::shared_ptr<io::RandomAccessFile>& file,
 MemoryPool* pool, std::unique_ptr<ORCFileReader>* reader) {
 return Open(file, pool).Value(reader);
}

Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
 const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
#ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK
Expand Down

14 changes: 14 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@
#include "arrow/type_fwd.h"
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
#include "arrow/adapters/orc/adapter_util.h"

namespace arrow {
namespace adapters {
Expand All@@ -53,6 +54,19 @@ class ARROW_EXPORT ORCFileReader {
 public:
 ~ORCFileReader();

 /// \brief Creates a new ORC reader.
 ///
 /// \param[in] file the data source
 /// \param[in] pool a MemoryPool to use for buffer allocations
 /// \param[out] reader the returned reader object
 /// \return Status
 ARROW_DEPRECATED("Deprecated in 6.0.0. Use Result-returning overload instead.")
 static Status Open(const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool,
 std::unique_ptr<ORCFileReader>* reader);

 /// \brief Get ORC reader from inside.
 liborc::Reader* GetRawORCReader();

 /// \brief Creates a new ORC reader
 ///
 /// \param[in] file the data source
Expand Down

17 changes: 17 additions & 0 deletions
cpp/src/arrow/ipc/reader.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1369,6 +1369,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
 return total;
 }

 Result<int64_t> RecordBatchCountRows(int i) override {
 DCHECK_GE(i, 0);
 DCHECK_LT(i, num_record_batches());
 ARROW_ASSIGN_OR_RAISE(auto outer_message,
 ReadMessageFromBlock(GetRecordBatchBlock(i)));
 auto metadata = outer_message->metadata();
 const flatbuf::Message* message = nullptr;
 RETURN_NOT_OK(
 internal::VerifyMessage(metadata->data(), metadata->size(), &message));
 auto batch = message->header_as_RecordBatch();
 if (batch == nullptr) {
 return Status::IOError(
 "Header-type of flatbuffer-encoded Message is not RecordBatch.");
 }
 return batch->length();
 }

 Status Open(const std::shared_ptr<io::RandomAccessFile>& file, int64_t footer_offset,
 const IpcReadOptions& options) {
 owned_file_ = file;
Expand Down

2 changes: 2 additions & 0 deletions
cpp/src/arrow/ipc/reader.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,8 @@ class ARROW_EXPORT RecordBatchFileReader
 /// \brief Computes the total number of rows in the file.
 virtual Result<int64_t> CountRows() = 0;

 virtual Result<int64_t> RecordBatchCountRows(int i) = 0;

 /// \brief Begin loading metadata for the desired batches into memory.
 ///
 /// This method will also begin loading all dictionaries messages into memory.
Expand Down

5 changes: 5 additions & 0 deletions
cpp/src/arrow/util/bit_stream_utils.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -272,6 +272,11 @@ inline void GetValue_(int num_bits, T* v, int max_bytes, const uint8_t* buffer,
#pragma warning(push)
#pragma warning(disable : 4800)
#endif
 if (ARROW_PREDICT_FALSE(*bit_offset >= 64)) {
 auto msg = std::string("invalid bit offset: ") + std::to_string(*bit_offset);
 msg += ", may be malformed num_bits: " + std::to_string(num_bits);
 throw std::runtime_error(msg);
 }
 *v = static_cast<T>(bit_util::TrailingBits(*buffered_values, *bit_offset + num_bits) >>
 *bit_offset);
#ifdef _MSC_VER
Expand Down

2 changes: 1 addition & 1 deletion
cpp/src/parquet/encoding.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2721,7 +2721,7 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
 T min_delta_;
 uint32_t mini_block_idx_;
 std::shared_ptr<ResizableBuffer> delta_bit_widths_;
 int delta_bit_width_;
 int delta_bit_width_ = 0;

 T last_value_;
};
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Don't merge] Upgrade the Arrow to 16.1.0#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nikitamikhaylov
wants to merge
6
commits into

from

 Closed


[Don't merge] Upgrade the Arrow to 16.1.0
#67
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
57986f2

Empty commit


nikitamikhaylov Oct 15, 2024
39e53db

Merge pull request #66 from copperybean/release-13.0.0


al13n321 May 21, 2024
45ea0d6

Merge pull request #47 from ClickHouse/fix-uninit-value-msan


Avogar Nov 3, 2023
fb031b0

Merge pull request #39 from ClickHouse/count-from-record-batch


Avogar Aug 9, 2023
21a89cf

Merge pull request #9 from taiyang-li/raw_orc_reader


Avogar Mar 1, 2022
4c22e00

Merge pull request #10 from taiyang-li/fix_pr_9


Avogar Mar 21, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -222,6 +222,11 @@ class ORCFileReader::Impl {
 return Init();
 }

 virtual liborc::Reader* GetRawORCReader() {
 return reader_.get();
 }


 Status Init() {
 int64_t nstripes = reader_->getNumberOfStripes();
 stripes_.resize(static_cast<size_t>(nstripes));
Expand DownExpand Up@@ -548,6 +553,10 @@ class ORCFileReader::Impl {
 return NextStripeReader(batch_size, empty_vec);
 }

 liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
 }

 private:
 MemoryPool* pool_;
 std::unique_ptr<liborc::Reader> reader_;
Expand All@@ -559,6 +568,15 @@ ORCFileReader::ORCFileReader() { impl_.reset(new ORCFileReader::Impl()); }

ORCFileReader::~ORCFileReader() {}

liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
}

Status ORCFileReader::Open(const std::shared_ptr<io::RandomAccessFile>& file,
 MemoryPool* pool, std::unique_ptr<ORCFileReader>* reader) {
 return Open(file, pool).Value(reader);
}

Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
 const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
#ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK
Expand Down

14 changes: 14 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@
#include "arrow/type_fwd.h"
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
#include "arrow/adapters/orc/adapter_util.h"

namespace arrow {
namespace adapters {
Expand All@@ -53,6 +54,19 @@ class ARROW_EXPORT ORCFileReader {
 public:
 ~ORCFileReader();

 /// \brief Creates a new ORC reader.
 ///
 /// \param[in] file the data source
 /// \param[in] pool a MemoryPool to use for buffer allocations
 /// \param[out] reader the returned reader object
 /// \return Status
 ARROW_DEPRECATED("Deprecated in 6.0.0. Use Result-returning overload instead.")
 static Status Open(const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool,
 std::unique_ptr<ORCFileReader>* reader);

 /// \brief Get ORC reader from inside.
 liborc::Reader* GetRawORCReader();

 /// \brief Creates a new ORC reader
 ///
 /// \param[in] file the data source
Expand Down

17 changes: 17 additions & 0 deletions
cpp/src/arrow/ipc/reader.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1369,6 +1369,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
 return total;
 }

 Result<int64_t> RecordBatchCountRows(int i) override {
 DCHECK_GE(i, 0);
 DCHECK_LT(i, num_record_batches());
 ARROW_ASSIGN_OR_RAISE(auto outer_message,
 ReadMessageFromBlock(GetRecordBatchBlock(i)));
 auto metadata = outer_message->metadata();
 const flatbuf::Message* message = nullptr;
 RETURN_NOT_OK(
 internal::VerifyMessage(metadata->data(), metadata->size(), &message));
 auto batch = message->header_as_RecordBatch();
 if (batch == nullptr) {
 return Status::IOError(
 "Header-type of flatbuffer-encoded Message is not RecordBatch.");
 }
 return batch->length();
 }

 Status Open(const std::shared_ptr<io::RandomAccessFile>& file, int64_t footer_offset,
 const IpcReadOptions& options) {
 owned_file_ = file;
Expand Down

2 changes: 2 additions & 0 deletions
cpp/src/arrow/ipc/reader.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,8 @@ class ARROW_EXPORT RecordBatchFileReader
 /// \brief Computes the total number of rows in the file.
 virtual Result<int64_t> CountRows() = 0;

 virtual Result<int64_t> RecordBatchCountRows(int i) = 0;

 /// \brief Begin loading metadata for the desired batches into memory.
 ///
 /// This method will also begin loading all dictionaries messages into memory.
Expand Down

5 changes: 5 additions & 0 deletions
cpp/src/arrow/util/bit_stream_utils.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -272,6 +272,11 @@ inline void GetValue_(int num_bits, T* v, int max_bytes, const uint8_t* buffer,
#pragma warning(push)
#pragma warning(disable : 4800)
#endif
 if (ARROW_PREDICT_FALSE(*bit_offset >= 64)) {
 auto msg = std::string("invalid bit offset: ") + std::to_string(*bit_offset);
 msg += ", may be malformed num_bits: " + std::to_string(num_bits);
 throw std::runtime_error(msg);
 }
 *v = static_cast<T>(bit_util::TrailingBits(*buffered_values, *bit_offset + num_bits) >>
 *bit_offset);
#ifdef _MSC_VER
Expand Down

2 changes: 1 addition & 1 deletion
cpp/src/parquet/encoding.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2721,7 +2721,7 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
 T min_delta_;
 uint32_t mini_block_idx_;
 std::shared_ptr<ResizableBuffer> delta_bit_widths_;
 int delta_bit_width_;
 int delta_bit_width_ = 0;

 T last_value_;
};
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Don't merge] Upgrade the Arrow to 16.1.0#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nikitamikhaylov
wants to merge
6
commits into

from

 Closed


[Don't merge] Upgrade the Arrow to 16.1.0
#67
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
57986f2

Empty commit


nikitamikhaylov Oct 15, 2024
39e53db

Merge pull request #66 from copperybean/release-13.0.0


al13n321 May 21, 2024
45ea0d6

Merge pull request #47 from ClickHouse/fix-uninit-value-msan


Avogar Nov 3, 2023
fb031b0

Merge pull request #39 from ClickHouse/count-from-record-batch


Avogar Aug 9, 2023
21a89cf

Merge pull request #9 from taiyang-li/raw_orc_reader


Avogar Mar 1, 2022
4c22e00

Merge pull request #10 from taiyang-li/fix_pr_9


Avogar Mar 21, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -222,6 +222,11 @@ class ORCFileReader::Impl {
 return Init();
 }

 virtual liborc::Reader* GetRawORCReader() {
 return reader_.get();
 }


 Status Init() {
 int64_t nstripes = reader_->getNumberOfStripes();
 stripes_.resize(static_cast<size_t>(nstripes));
Expand DownExpand Up@@ -548,6 +553,10 @@ class ORCFileReader::Impl {
 return NextStripeReader(batch_size, empty_vec);
 }

 liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
 }

 private:
 MemoryPool* pool_;
 std::unique_ptr<liborc::Reader> reader_;
Expand All@@ -559,6 +568,15 @@ ORCFileReader::ORCFileReader() { impl_.reset(new ORCFileReader::Impl()); }

ORCFileReader::~ORCFileReader() {}

liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
}

Status ORCFileReader::Open(const std::shared_ptr<io::RandomAccessFile>& file,
 MemoryPool* pool, std::unique_ptr<ORCFileReader>* reader) {
 return Open(file, pool).Value(reader);
}

Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
 const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
#ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK
Expand Down

14 changes: 14 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@
#include "arrow/type_fwd.h"
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
#include "arrow/adapters/orc/adapter_util.h"

namespace arrow {
namespace adapters {
Expand All@@ -53,6 +54,19 @@ class ARROW_EXPORT ORCFileReader {
 public:
 ~ORCFileReader();

 /// \brief Creates a new ORC reader.
 ///
 /// \param[in] file the data source
 /// \param[in] pool a MemoryPool to use for buffer allocations
 /// \param[out] reader the returned reader object
 /// \return Status
 ARROW_DEPRECATED("Deprecated in 6.0.0. Use Result-returning overload instead.")
 static Status Open(const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool,
 std::unique_ptr<ORCFileReader>* reader);

 /// \brief Get ORC reader from inside.
 liborc::Reader* GetRawORCReader();

 /// \brief Creates a new ORC reader
 ///
 /// \param[in] file the data source
Expand Down

17 changes: 17 additions & 0 deletions
cpp/src/arrow/ipc/reader.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1369,6 +1369,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
 return total;
 }

 Result<int64_t> RecordBatchCountRows(int i) override {
 DCHECK_GE(i, 0);
 DCHECK_LT(i, num_record_batches());
 ARROW_ASSIGN_OR_RAISE(auto outer_message,
 ReadMessageFromBlock(GetRecordBatchBlock(i)));
 auto metadata = outer_message->metadata();
 const flatbuf::Message* message = nullptr;
 RETURN_NOT_OK(
 internal::VerifyMessage(metadata->data(), metadata->size(), &message));
 auto batch = message->header_as_RecordBatch();
 if (batch == nullptr) {
 return Status::IOError(
 "Header-type of flatbuffer-encoded Message is not RecordBatch.");
 }
 return batch->length();
 }

 Status Open(const std::shared_ptr<io::RandomAccessFile>& file, int64_t footer_offset,
 const IpcReadOptions& options) {
 owned_file_ = file;
Expand Down

2 changes: 2 additions & 0 deletions
cpp/src/arrow/ipc/reader.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,8 @@ class ARROW_EXPORT RecordBatchFileReader
 /// \brief Computes the total number of rows in the file.
 virtual Result<int64_t> CountRows() = 0;

 virtual Result<int64_t> RecordBatchCountRows(int i) = 0;

 /// \brief Begin loading metadata for the desired batches into memory.
 ///
 /// This method will also begin loading all dictionaries messages into memory.
Expand Down

5 changes: 5 additions & 0 deletions
cpp/src/arrow/util/bit_stream_utils.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -272,6 +272,11 @@ inline void GetValue_(int num_bits, T* v, int max_bytes, const uint8_t* buffer,
#pragma warning(push)
#pragma warning(disable : 4800)
#endif
 if (ARROW_PREDICT_FALSE(*bit_offset >= 64)) {
 auto msg = std::string("invalid bit offset: ") + std::to_string(*bit_offset);
 msg += ", may be malformed num_bits: " + std::to_string(num_bits);
 throw std::runtime_error(msg);
 }
 *v = static_cast<T>(bit_util::TrailingBits(*buffered_values, *bit_offset + num_bits) >>
 *bit_offset);
#ifdef _MSC_VER
Expand Down

2 changes: 1 addition & 1 deletion
cpp/src/parquet/encoding.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2721,7 +2721,7 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
 T min_delta_;
 uint32_t mini_block_idx_;
 std::shared_ptr<ResizableBuffer> delta_bit_widths_;
 int delta_bit_width_;
 int delta_bit_width_ = 0;

 T last_value_;
};
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[Don't merge] Upgrade the Arrow to 16.1.0#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nikitamikhaylov
wants to merge
6
commits into

from

 Closed


[Don't merge] Upgrade the Arrow to 16.1.0
#67
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
57986f2

Empty commit


nikitamikhaylov Oct 15, 2024
39e53db

Merge pull request #66 from copperybean/release-13.0.0


al13n321 May 21, 2024
45ea0d6

Merge pull request #47 from ClickHouse/fix-uninit-value-msan


Avogar Nov 3, 2023
fb031b0

Merge pull request #39 from ClickHouse/count-from-record-batch


Avogar Aug 9, 2023
21a89cf

Merge pull request #9 from taiyang-li/raw_orc_reader


Avogar Mar 1, 2022
4c22e00

Merge pull request #10 from taiyang-li/fix_pr_9


Avogar Mar 21, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -222,6 +222,11 @@ class ORCFileReader::Impl {
 return Init();
 }

 virtual liborc::Reader* GetRawORCReader() {
 return reader_.get();
 }


 Status Init() {
 int64_t nstripes = reader_->getNumberOfStripes();
 stripes_.resize(static_cast<size_t>(nstripes));
Expand DownExpand Up@@ -548,6 +553,10 @@ class ORCFileReader::Impl {
 return NextStripeReader(batch_size, empty_vec);
 }

 liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
 }

 private:
 MemoryPool* pool_;
 std::unique_ptr<liborc::Reader> reader_;
Expand All@@ -559,6 +568,15 @@ ORCFileReader::ORCFileReader() { impl_.reset(new ORCFileReader::Impl()); }

ORCFileReader::~ORCFileReader() {}

liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
}

Status ORCFileReader::Open(const std::shared_ptr<io::RandomAccessFile>& file,
 MemoryPool* pool, std::unique_ptr<ORCFileReader>* reader) {
 return Open(file, pool).Value(reader);
}

Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
 const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
#ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK
Expand Down

14 changes: 14 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@
#include "arrow/type_fwd.h"
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
#include "arrow/adapters/orc/adapter_util.h"

namespace arrow {
namespace adapters {
Expand All@@ -53,6 +54,19 @@ class ARROW_EXPORT ORCFileReader {
 public:
 ~ORCFileReader();

 /// \brief Creates a new ORC reader.
 ///
 /// \param[in] file the data source
 /// \param[in] pool a MemoryPool to use for buffer allocations
 /// \param[out] reader the returned reader object
 /// \return Status
 ARROW_DEPRECATED("Deprecated in 6.0.0. Use Result-returning overload instead.")
 static Status Open(const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool,
 std::unique_ptr<ORCFileReader>* reader);

 /// \brief Get ORC reader from inside.
 liborc::Reader* GetRawORCReader();

 /// \brief Creates a new ORC reader
 ///
 /// \param[in] file the data source
Expand Down

17 changes: 17 additions & 0 deletions
cpp/src/arrow/ipc/reader.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1369,6 +1369,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
 return total;
 }

 Result<int64_t> RecordBatchCountRows(int i) override {
 DCHECK_GE(i, 0);
 DCHECK_LT(i, num_record_batches());
 ARROW_ASSIGN_OR_RAISE(auto outer_message,
 ReadMessageFromBlock(GetRecordBatchBlock(i)));
 auto metadata = outer_message->metadata();
 const flatbuf::Message* message = nullptr;
 RETURN_NOT_OK(
 internal::VerifyMessage(metadata->data(), metadata->size(), &message));
 auto batch = message->header_as_RecordBatch();
 if (batch == nullptr) {
 return Status::IOError(
 "Header-type of flatbuffer-encoded Message is not RecordBatch.");
 }
 return batch->length();
 }

 Status Open(const std::shared_ptr<io::RandomAccessFile>& file, int64_t footer_offset,
 const IpcReadOptions& options) {
 owned_file_ = file;
Expand Down

2 changes: 2 additions & 0 deletions
cpp/src/arrow/ipc/reader.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,8 @@ class ARROW_EXPORT RecordBatchFileReader
 /// \brief Computes the total number of rows in the file.
 virtual Result<int64_t> CountRows() = 0;

 virtual Result<int64_t> RecordBatchCountRows(int i) = 0;

 /// \brief Begin loading metadata for the desired batches into memory.
 ///
 /// This method will also begin loading all dictionaries messages into memory.
Expand Down

5 changes: 5 additions & 0 deletions
cpp/src/arrow/util/bit_stream_utils.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -272,6 +272,11 @@ inline void GetValue_(int num_bits, T* v, int max_bytes, const uint8_t* buffer,
#pragma warning(push)
#pragma warning(disable : 4800)
#endif
 if (ARROW_PREDICT_FALSE(*bit_offset >= 64)) {
 auto msg = std::string("invalid bit offset: ") + std::to_string(*bit_offset);
 msg += ", may be malformed num_bits: " + std::to_string(num_bits);
 throw std::runtime_error(msg);
 }
 *v = static_cast<T>(bit_util::TrailingBits(*buffered_values, *bit_offset + num_bits) >>
 *bit_offset);
#ifdef _MSC_VER
Expand Down

2 changes: 1 addition & 1 deletion
cpp/src/parquet/encoding.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2721,7 +2721,7 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
 T min_delta_;
 uint32_t mini_block_idx_;
 std::shared_ptr<ResizableBuffer> delta_bit_widths_;
 int delta_bit_width_;
 int delta_bit_width_ = 0;

 T last_value_;
};
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Don't merge] Upgrade the Arrow to 16.1.0#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nikitamikhaylov
wants to merge
6
commits into

from

 Closed


[Don't merge] Upgrade the Arrow to 16.1.0
#67
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
57986f2

Empty commit


nikitamikhaylov Oct 15, 2024
39e53db

Merge pull request #66 from copperybean/release-13.0.0


al13n321 May 21, 2024
45ea0d6

Merge pull request #47 from ClickHouse/fix-uninit-value-msan


Avogar Nov 3, 2023
fb031b0

Merge pull request #39 from ClickHouse/count-from-record-batch


Avogar Aug 9, 2023
21a89cf

Merge pull request #9 from taiyang-li/raw_orc_reader


Avogar Mar 1, 2022
4c22e00

Merge pull request #10 from taiyang-li/fix_pr_9


Avogar Mar 21, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -222,6 +222,11 @@ class ORCFileReader::Impl {
 return Init();
 }

 virtual liborc::Reader* GetRawORCReader() {
 return reader_.get();
 }


 Status Init() {
 int64_t nstripes = reader_->getNumberOfStripes();
 stripes_.resize(static_cast<size_t>(nstripes));
Expand DownExpand Up@@ -548,6 +553,10 @@ class ORCFileReader::Impl {
 return NextStripeReader(batch_size, empty_vec);
 }

 liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
 }

 private:
 MemoryPool* pool_;
 std::unique_ptr<liborc::Reader> reader_;
Expand All@@ -559,6 +568,15 @@ ORCFileReader::ORCFileReader() { impl_.reset(new ORCFileReader::Impl()); }

ORCFileReader::~ORCFileReader() {}

liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
}

Status ORCFileReader::Open(const std::shared_ptr<io::RandomAccessFile>& file,
 MemoryPool* pool, std::unique_ptr<ORCFileReader>* reader) {
 return Open(file, pool).Value(reader);
}

Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
 const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
#ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK
Expand Down

14 changes: 14 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@
#include "arrow/type_fwd.h"
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
#include "arrow/adapters/orc/adapter_util.h"

namespace arrow {
namespace adapters {
Expand All@@ -53,6 +54,19 @@ class ARROW_EXPORT ORCFileReader {
 public:
 ~ORCFileReader();

 /// \brief Creates a new ORC reader.
 ///
 /// \param[in] file the data source
 /// \param[in] pool a MemoryPool to use for buffer allocations
 /// \param[out] reader the returned reader object
 /// \return Status
 ARROW_DEPRECATED("Deprecated in 6.0.0. Use Result-returning overload instead.")
 static Status Open(const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool,
 std::unique_ptr<ORCFileReader>* reader);

 /// \brief Get ORC reader from inside.
 liborc::Reader* GetRawORCReader();

 /// \brief Creates a new ORC reader
 ///
 /// \param[in] file the data source
Expand Down

17 changes: 17 additions & 0 deletions
cpp/src/arrow/ipc/reader.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1369,6 +1369,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
 return total;
 }

 Result<int64_t> RecordBatchCountRows(int i) override {
 DCHECK_GE(i, 0);
 DCHECK_LT(i, num_record_batches());
 ARROW_ASSIGN_OR_RAISE(auto outer_message,
 ReadMessageFromBlock(GetRecordBatchBlock(i)));
 auto metadata = outer_message->metadata();
 const flatbuf::Message* message = nullptr;
 RETURN_NOT_OK(
 internal::VerifyMessage(metadata->data(), metadata->size(), &message));
 auto batch = message->header_as_RecordBatch();
 if (batch == nullptr) {
 return Status::IOError(
 "Header-type of flatbuffer-encoded Message is not RecordBatch.");
 }
 return batch->length();
 }

 Status Open(const std::shared_ptr<io::RandomAccessFile>& file, int64_t footer_offset,
 const IpcReadOptions& options) {
 owned_file_ = file;
Expand Down

2 changes: 2 additions & 0 deletions
cpp/src/arrow/ipc/reader.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,8 @@ class ARROW_EXPORT RecordBatchFileReader
 /// \brief Computes the total number of rows in the file.
 virtual Result<int64_t> CountRows() = 0;

 virtual Result<int64_t> RecordBatchCountRows(int i) = 0;

 /// \brief Begin loading metadata for the desired batches into memory.
 ///
 /// This method will also begin loading all dictionaries messages into memory.
Expand Down

5 changes: 5 additions & 0 deletions
cpp/src/arrow/util/bit_stream_utils.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -272,6 +272,11 @@ inline void GetValue_(int num_bits, T* v, int max_bytes, const uint8_t* buffer,
#pragma warning(push)
#pragma warning(disable : 4800)
#endif
 if (ARROW_PREDICT_FALSE(*bit_offset >= 64)) {
 auto msg = std::string("invalid bit offset: ") + std::to_string(*bit_offset);
 msg += ", may be malformed num_bits: " + std::to_string(num_bits);
 throw std::runtime_error(msg);
 }
 *v = static_cast<T>(bit_util::TrailingBits(*buffered_values, *bit_offset + num_bits) >>
 *bit_offset);
#ifdef _MSC_VER
Expand Down

2 changes: 1 addition & 1 deletion
cpp/src/parquet/encoding.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2721,7 +2721,7 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
 T min_delta_;
 uint32_t mini_block_idx_;
 std::shared_ptr<ResizableBuffer> delta_bit_widths_;
 int delta_bit_width_;
 int delta_bit_width_ = 0;

 T last_value_;
};
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Don't merge] Upgrade the Arrow to 16.1.0#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nikitamikhaylov
wants to merge
6
commits into

from

 Closed


[Don't merge] Upgrade the Arrow to 16.1.0
#67
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
57986f2

Empty commit


nikitamikhaylov Oct 15, 2024
39e53db

Merge pull request #66 from copperybean/release-13.0.0


al13n321 May 21, 2024
45ea0d6

Merge pull request #47 from ClickHouse/fix-uninit-value-msan


Avogar Nov 3, 2023
fb031b0

Merge pull request #39 from ClickHouse/count-from-record-batch


Avogar Aug 9, 2023
21a89cf

Merge pull request #9 from taiyang-li/raw_orc_reader


Avogar Mar 1, 2022
4c22e00

Merge pull request #10 from taiyang-li/fix_pr_9


Avogar Mar 21, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -222,6 +222,11 @@ class ORCFileReader::Impl {
 return Init();
 }

 virtual liborc::Reader* GetRawORCReader() {
 return reader_.get();
 }


 Status Init() {
 int64_t nstripes = reader_->getNumberOfStripes();
 stripes_.resize(static_cast<size_t>(nstripes));
Expand DownExpand Up@@ -548,6 +553,10 @@ class ORCFileReader::Impl {
 return NextStripeReader(batch_size, empty_vec);
 }

 liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
 }

 private:
 MemoryPool* pool_;
 std::unique_ptr<liborc::Reader> reader_;
Expand All@@ -559,6 +568,15 @@ ORCFileReader::ORCFileReader() { impl_.reset(new ORCFileReader::Impl()); }

ORCFileReader::~ORCFileReader() {}

liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
}

Status ORCFileReader::Open(const std::shared_ptr<io::RandomAccessFile>& file,
 MemoryPool* pool, std::unique_ptr<ORCFileReader>* reader) {
 return Open(file, pool).Value(reader);
}

Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
 const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
#ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK
Expand Down

14 changes: 14 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@
#include "arrow/type_fwd.h"
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
#include "arrow/adapters/orc/adapter_util.h"

namespace arrow {
namespace adapters {
Expand All@@ -53,6 +54,19 @@ class ARROW_EXPORT ORCFileReader {
 public:
 ~ORCFileReader();

 /// \brief Creates a new ORC reader.
 ///
 /// \param[in] file the data source
 /// \param[in] pool a MemoryPool to use for buffer allocations
 /// \param[out] reader the returned reader object
 /// \return Status
 ARROW_DEPRECATED("Deprecated in 6.0.0. Use Result-returning overload instead.")
 static Status Open(const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool,
 std::unique_ptr<ORCFileReader>* reader);

 /// \brief Get ORC reader from inside.
 liborc::Reader* GetRawORCReader();

 /// \brief Creates a new ORC reader
 ///
 /// \param[in] file the data source
Expand Down

17 changes: 17 additions & 0 deletions
cpp/src/arrow/ipc/reader.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1369,6 +1369,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
 return total;
 }

 Result<int64_t> RecordBatchCountRows(int i) override {
 DCHECK_GE(i, 0);
 DCHECK_LT(i, num_record_batches());
 ARROW_ASSIGN_OR_RAISE(auto outer_message,
 ReadMessageFromBlock(GetRecordBatchBlock(i)));
 auto metadata = outer_message->metadata();
 const flatbuf::Message* message = nullptr;
 RETURN_NOT_OK(
 internal::VerifyMessage(metadata->data(), metadata->size(), &message));
 auto batch = message->header_as_RecordBatch();
 if (batch == nullptr) {
 return Status::IOError(
 "Header-type of flatbuffer-encoded Message is not RecordBatch.");
 }
 return batch->length();
 }

 Status Open(const std::shared_ptr<io::RandomAccessFile>& file, int64_t footer_offset,
 const IpcReadOptions& options) {
 owned_file_ = file;
Expand Down

2 changes: 2 additions & 0 deletions
cpp/src/arrow/ipc/reader.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,8 @@ class ARROW_EXPORT RecordBatchFileReader
 /// \brief Computes the total number of rows in the file.
 virtual Result<int64_t> CountRows() = 0;

 virtual Result<int64_t> RecordBatchCountRows(int i) = 0;

 /// \brief Begin loading metadata for the desired batches into memory.
 ///
 /// This method will also begin loading all dictionaries messages into memory.
Expand Down

5 changes: 5 additions & 0 deletions
cpp/src/arrow/util/bit_stream_utils.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -272,6 +272,11 @@ inline void GetValue_(int num_bits, T* v, int max_bytes, const uint8_t* buffer,
#pragma warning(push)
#pragma warning(disable : 4800)
#endif
 if (ARROW_PREDICT_FALSE(*bit_offset >= 64)) {
 auto msg = std::string("invalid bit offset: ") + std::to_string(*bit_offset);
 msg += ", may be malformed num_bits: " + std::to_string(num_bits);
 throw std::runtime_error(msg);
 }
 *v = static_cast<T>(bit_util::TrailingBits(*buffered_values, *bit_offset + num_bits) >>
 *bit_offset);
#ifdef _MSC_VER
Expand Down

2 changes: 1 addition & 1 deletion
cpp/src/parquet/encoding.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2721,7 +2721,7 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
 T min_delta_;
 uint32_t mini_block_idx_;
 std::shared_ptr<ResizableBuffer> delta_bit_widths_;
 int delta_bit_width_;
 int delta_bit_width_ = 0;

 T last_value_;
};
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[Don't merge] Upgrade the Arrow to 16.1.0#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

nikitamikhaylov
wants to merge
6
commits into

from

 Closed


[Don't merge] Upgrade the Arrow to 16.1.0
#67
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
57986f2

Empty commit


nikitamikhaylov Oct 15, 2024
39e53db

Merge pull request #66 from copperybean/release-13.0.0


al13n321 May 21, 2024
45ea0d6

Merge pull request #47 from ClickHouse/fix-uninit-value-msan


Avogar Nov 3, 2023
fb031b0

Merge pull request #39 from ClickHouse/count-from-record-batch


Avogar Aug 9, 2023
21a89cf

Merge pull request #9 from taiyang-li/raw_orc_reader


Avogar Mar 1, 2022
4c22e00

Merge pull request #10 from taiyang-li/fix_pr_9


Avogar Mar 21, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 18 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -222,6 +222,11 @@ class ORCFileReader::Impl {
 return Init();
 }

 virtual liborc::Reader* GetRawORCReader() {
 return reader_.get();
 }


 Status Init() {
 int64_t nstripes = reader_->getNumberOfStripes();
 stripes_.resize(static_cast<size_t>(nstripes));
Expand DownExpand Up@@ -548,6 +553,10 @@ class ORCFileReader::Impl {
 return NextStripeReader(batch_size, empty_vec);
 }

 liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
 }

 private:
 MemoryPool* pool_;
 std::unique_ptr<liborc::Reader> reader_;
Expand All@@ -559,6 +568,15 @@ ORCFileReader::ORCFileReader() { impl_.reset(new ORCFileReader::Impl()); }

ORCFileReader::~ORCFileReader() {}

liborc::Reader* ORCFileReader::GetRawORCReader() {
 return impl_->GetRawORCReader();
}

Status ORCFileReader::Open(const std::shared_ptr<io::RandomAccessFile>& file,
 MemoryPool* pool, std::unique_ptr<ORCFileReader>* reader) {
 return Open(file, pool).Value(reader);
}

Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
 const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
#ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK
Expand Down

14 changes: 14 additions & 0 deletions
cpp/src/arrow/adapters/orc/adapter.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,7 @@
#include "arrow/type_fwd.h"
#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"
#include "arrow/adapters/orc/adapter_util.h"

namespace arrow {
namespace adapters {
Expand All@@ -53,6 +54,19 @@ class ARROW_EXPORT ORCFileReader {
 public:
 ~ORCFileReader();

 /// \brief Creates a new ORC reader.
 ///
 /// \param[in] file the data source
 /// \param[in] pool a MemoryPool to use for buffer allocations
 /// \param[out] reader the returned reader object
 /// \return Status
 ARROW_DEPRECATED("Deprecated in 6.0.0. Use Result-returning overload instead.")
 static Status Open(const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool,
 std::unique_ptr<ORCFileReader>* reader);

 /// \brief Get ORC reader from inside.
 liborc::Reader* GetRawORCReader();

 /// \brief Creates a new ORC reader
 ///
 /// \param[in] file the data source
Expand Down

17 changes: 17 additions & 0 deletions
cpp/src/arrow/ipc/reader.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1369,6 +1369,23 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
 return total;
 }

 Result<int64_t> RecordBatchCountRows(int i) override {
 DCHECK_GE(i, 0);
 DCHECK_LT(i, num_record_batches());
 ARROW_ASSIGN_OR_RAISE(auto outer_message,
 ReadMessageFromBlock(GetRecordBatchBlock(i)));
 auto metadata = outer_message->metadata();
 const flatbuf::Message* message = nullptr;
 RETURN_NOT_OK(
 internal::VerifyMessage(metadata->data(), metadata->size(), &message));
 auto batch = message->header_as_RecordBatch();
 if (batch == nullptr) {
 return Status::IOError(
 "Header-type of flatbuffer-encoded Message is not RecordBatch.");
 }
 return batch->length();
 }

 Status Open(const std::shared_ptr<io::RandomAccessFile>& file, int64_t footer_offset,
 const IpcReadOptions& options) {
 owned_file_ = file;
Expand Down

2 changes: 2 additions & 0 deletions
cpp/src/arrow/ipc/reader.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,8 @@ class ARROW_EXPORT RecordBatchFileReader
 /// \brief Computes the total number of rows in the file.
 virtual Result<int64_t> CountRows() = 0;

 virtual Result<int64_t> RecordBatchCountRows(int i) = 0;

 /// \brief Begin loading metadata for the desired batches into memory.
 ///
 /// This method will also begin loading all dictionaries messages into memory.
Expand Down

5 changes: 5 additions & 0 deletions
cpp/src/arrow/util/bit_stream_utils.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -272,6 +272,11 @@ inline void GetValue_(int num_bits, T* v, int max_bytes, const uint8_t* buffer,
#pragma warning(push)
#pragma warning(disable : 4800)
#endif
 if (ARROW_PREDICT_FALSE(*bit_offset >= 64)) {
 auto msg = std::string("invalid bit offset: ") + std::to_string(*bit_offset);
 msg += ", may be malformed num_bits: " + std::to_string(num_bits);
 throw std::runtime_error(msg);
 }
 *v = static_cast<T>(bit_util::TrailingBits(*buffered_values, *bit_offset + num_bits) >>
 *bit_offset);
#ifdef _MSC_VER
Expand Down

2 changes: 1 addition & 1 deletion
cpp/src/parquet/encoding.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2721,7 +2721,7 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual public TypedDecoder<DTyp
 T min_delta_;
 uint32_t mini_block_idx_;
 std::shared_ptr<ResizableBuffer> delta_bit_widths_;
 int delta_bit_width_;
 int delta_bit_width_ = 0;

 T last_value_;
};
Expand Down