Uh oh!
There was an error while loading. Please reload this page.
Allow direct local client connections to select a binary version - #552
Allow direct local client connections to select a binary version#552sdairs wants to merge 2 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
sdairs
commented
Aug 26, 2026
Carry-over review from PR #500 (old PR for #469). Functionally this PR is stronger than #500 (parse-time typed validation with genuinely good postgres/latest rejection messages, deliberate+documented zero/one/multiple fallback policy, broader subprocess matrix, default-file non-mutation asserted). Two required items:
Cosmetic: partial-version "newest installed match" is a mild expansion beyond the issue's "explicit exact version" framing — it is documented and user-directed, so acceptable, but confirm intentional. |
569ad10 to
a301f21Compare4396b01 to
8506510Compare8506510 to
49ffd6cCompare0b56079 to
c335826Comparec335826 to
63d1194Compare63d1194 to
537c6f3Compare1695102 to
f2f1c5aComparef2f1c5a to
fbfbf93Comparefbfbf93 to
3f87608Compare3f87608 to
100f161Compare100f161 to
407781cCompare209656c to
ed7ca6bCompareed7ca6b to
88a5e8fCompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 88a5e8f. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
88a5e8f to
a5a089bComparea5a089b to
abffd3eCompareabffd3e to
6a08fb4Compare
Summary
local client --versionselection for installed ClickHouse binaries without modifying the global defaultTests
cargo test -p clickhousectlcargo clippy -p clickhousectl --all-targets -- -D warningscargo fmt --all --checkCloses#469