Uh oh!
There was an error while loading. Please reload this page.
fix: don't mis-split event namespace when it contains a dot - #239
Open
lio-p wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GalaxyClient.track()split the event string on every.and kept thefirst 3 parts, so a
namespacecontaining a literal dot (e.g. a packagename like
ruamel.yaml) shifted the split and corruptedcomponent/event.Fix
Take the last two segments as
component/eventName(short fixed literals,never dotted) and everything before as
namespace. No-op for the commoncase; correct for dotted namespaces.
Testing
Added
test/galaxy-client.test.jsusing Node's built-innode:test(no newruntime dependency). Run with
npm test. A tiny zero-dependency ESM resolverhook (
test/register.mjs,test/extensionless-resolver.mjs) lets the testimport the bundler-style source directly.
🤖 Generated with Claude Code