Uh oh!
There was an error while loading. Please reload this page.
xmemory: raise recall answer budget 4KB -> 16KB - #412
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recall handler clips xmemory's read result to
_MAX_XMEM_ANSWER_BYTES = 4_000before appending it to the memU block. 4KB is tight for the structured read modes (raw-tables/xresponse) and for decomposed multi-sub-query answers (reader_results), which get truncated mid-payload.This bumps the sub-budget to 16KB. Sizing: memU part is capped at 10KB (
_MAX_RECALL_BYTES), so the combined worst case is ~26KB — still well under the ~55KB harness inline-output limit that these budgets exist to stay clear of (see #95).One-line constant change + comment; no behavior change below 4KB. Full test suite passes (3360).