Dealing with open transactions when using advisory lock. Issue #14 - #15
Merged
Conversation
jasoncodes
added a commit
to ennova/with_advisory_lock
that referenced
this pull request
Nov 28, 2016
This made backwards incompatible changes with regards to when the lock releases. It was no longer guaranteed to be released at block end. Additionally, `.current_advisory_lock` would return `nil` in this scenario even though the lock was still being held. This reverts commit 35bd94d, reversing changes made to 68835db.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really don't know how to implement a test for this behaviour...
Could any of you help me?
Thanks