Skip to content

test(negtest): adr-required 索引世界负向验证(预期红,验证后即关)——W1-C1 #164 AC-2 - #211

Closed
randypanding wants to merge 1 commit into
mainfrom
w1c1-negtest-adr
Closed

test(negtest): adr-required 索引世界负向验证(预期红,验证后即关)——W1-C1 #164 AC-2#211
randypanding wants to merge 1 commit into
mainfrom
w1c1-negtest-adr

Conversation

@randypanding

Copy link
Copy Markdown
Contributor

目的

W1-C1 #164 AC-2 负向验证(一次性 PR,预期 adr-required 红,验证后即关闭,勿合并):

  • 引用 ADR-9999(不存在的编号)→ 应报"不在 INDEX entries(幽灵 ADR)"
  • 引用 ADR-0017(lifecycle=archived)→ 应报"生命周期=archived(历史回填,不可作为新决策依据)"

两拒绝均出现 = 防幽灵语义不回归 + archived 拒引落地(#207)双重实证。

Card: #164

Copilot AI lite review requested due to automatic review settings August 21, 2026 14:47
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@randypanding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e007c799-1a3a-4446-a486-ba0d2c5c156d

📥 Commits

Reviewing files that changed from the base of the PR and between 46fa5de and 4744935.

📒 Files selected for processing (1)
  • scripts/negtest-w1c1-164.txt

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

test(negtest): Add one-off AC-2 negative validation fixture for ADR index rules

🧪 Tests 🕐 Less than 5 minutes

Grey Divider

AI Description

• Add a one-off negative-test carrier file for W1-C1 #164 AC-2.
• Intended to fail adr-required checks (ghost ADR + archived ADR references).
• Do not merge; close after validation is confirmed.
High-Level Assessment

The following are alternative approaches to this PR:

1. Add dedicated CI test cases for ADR linter
  • ➕ Repeatable regression coverage without needing one-off PRs
  • ➕ Clear pass/fail expectations captured in automated tests
  • ➖ Requires building/maintaining a test harness around adr-required rules
  • ➖ Higher upfront effort than a one-time validation PR
2. Use a minimal markdown doc/ADR fixture instead of a .txt
  • ➕ Closer to real-world inputs the ADR tooling typically scans (markdown/ADR docs)
  • ➕ Easier to reason about the exact reference syntax being validated
  • ➖ May require placing the file in a specific docs/ADR location to be picked up
  • ➖ Still a one-off artifact unless cleaned up

Recommendation: For a one-time, intentionally-red validation PR, the current lightweight fixture approach is acceptable. If the team wants to prevent regressions long-term (ghost ADR prevention + archived ADR rejection), convert this scenario into an automated CI test suite and avoid future one-off PRs.

Files changed (1) +1 / -0

Tests (1) +1 / -0
negtest-w1c1-164.txtAdd one-off negative-test marker file for AC-2 validation +1/-0

Add one-off negative-test marker file for AC-2 validation

• Adds a single-line placeholder file used as a carrier for the W1-C1 #164 AC-2 negative validation run. This PR is intentionally expected to fail adr-required checks and is not meant to be merged.

scripts/negtest-w1c1-164.txt

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a one-off “negative test” touch file under scripts/ (a C1 path) to intentionally trigger the adr-required gate for W1-C1 #164 AC-2 validation, with the expectation that the workflow run fails and the PR is closed (not merged).

Changes:

  • Add a single-line marker file in scripts/ to ensure the PR is classified as a C1 change for adr-required evaluation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@randypanding

Copy link
Copy Markdown
Contributor Author

负向验证完成(14:48 UTC):gate 索引世界对 ADR-9999 报『不在 INDEX entries(幽灵 ADR)』、对 ADR-0017 报『生命周期=archived(历史回填,不可作为新决策依据)』——AC-2 防幽灵不回归 + archived 拒引双实证。一次性 PR 按约关闭。

@randypanding
randypanding deleted the w1c1-negtest-adr branch August 21, 2026 14:49
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can tweak Display preferences with a live preview to see your comment before it ships

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants