Skip to content

fix: 移除 main 误携 holdout gitlink(CI checkout 全红根因,#438 同款) - #467

Merged
randypanding merged 1 commit into
mainfrom
fix-holdout-gitlink
Aug 29, 2026
Merged

fix: 移除 main 误携 holdout gitlink(CI checkout 全红根因,#438 同款)#467
randypanding merged 1 commit into
mainfrom
fix-holdout-gitlink

Conversation

@randypanding

@randypanding randypanding commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Card: #425
ADR: ADR-0085(T8/T9 收口链路依赖 CI 可跑——checkout 修复是收口前置)

缺陷

15ac9c1(owner 侧会话直推"一人公司治理体系诊断与落地")携带工作区 holdout/ gitlink →
fatal: No url found for submodule path 'holdout' in .gitmodules → CI checkout 全红
(gate/hygiene/adversary 连坐;PR #466 与红队审计均被阻断)。

修复

git rm --cached holdout(#438 同款先例)。纯 gitlink 移除,零语义变更。

合并后动作

重跑 PR #466 红队审计(adversary target=specs/IR-0006)→ acceptance 合并 → IR-0006 T9 收口。

Summary by CodeRabbit

  • 变更
    • 移除了不再使用的 holdout 模块及相关引用。

15ac9c1(owner 侧会话"一人公司治理体系诊断与落地"直推)把工作区 holdout/
独立克隆以 gitlink 形态带入 main——fatal: No url found for submodule path
'holdout' in .gitmodules,CI checkout 全红(gate/hygiene/adversary 全族
连坐)。git rm --cached 移除;holdout/ 本地克隆不入库(.gitignore 已有)。

直推豁免未登记——owner 醒后按 ADR-0093 同款追认或回退(登记为残留)。
Copilot AI lite review requested due to automatic review settings August 29, 2026 23:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove stray holdout gitlink to restore CI checkout

🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Removes the unconfigured holdout gitlink that caused every CI checkout to fail.
• Restores gate, hygiene, and adversary workflows without changing repository behavior.
High-Level Assessment

Removing the accidental gitlink from the index is the correct minimal fix because holdout is not an intended submodule and is already ignored locally. Adding .gitmodules configuration would incorrectly formalize an unintended repository dependency.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c82c6eb-f606-4e90-baed-16994115bdeb

📥 Commits

Reviewing files that changed from the base of the PR and between 15ac9c1 and 57ad65a.

📒 Files selected for processing (1)
  • holdout
💤 Files with no reviewable changes (1)
  • holdout

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

移除了 holdout 子模块及其指向提交 40d2db2cad0039e6a0a313fefa454249bef221a2 的引用。

Changes

Cohort / File(s) Summary
holdout 子模块
holdout
删除 holdout 子模块引用。

Suggested labels: bug

Merge Risk: ⚪ Minimal · up to 57ad6

This change removes the unintended holdout gitlink without changing product behavior, so no actionable merge-blocking risk remains beyond normal checks.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning 标题使用了有效的 Conventional Commits 前缀 fix,且准确描述了移除 holdout gitlink 的主要变更。但标题长度为 57 个字符,超过 50 个字符限制。 将标题缩短至不超过 50 个字符,同时保留 fix: 前缀和主要变更信息,例如:fix: 移除误提交的 holdout gitlink
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-holdout-gitlink

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the bug Something isn't working label Aug 29, 2026
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants