Skip to content

policy: Shorts_Director 退役-2/3 实体声明收窄(ADR-0105) - #484

Merged
randypanding merged 1 commit into
mainfrom
policy/shorts-retire2-entities
Sep 1, 2026
Merged

policy: Shorts_Director 退役-2/3 实体声明收窄(ADR-0105)#484
randypanding merged 1 commit into
mainfrom
policy/shorts-retire2-entities

Conversation

@randypanding

Copy link
Copy Markdown
Contributor

ADR-0105

  • 依据: ADR-0105(archive/adr)确立的"policy 显式枚举同步 + ADR 留痕"退役通道,后续卡沿用不逐次新开 ADR(该 ADR 后果节明示)。
  • 变更: Shorts_Director entities 声明删除 brand_kernel/shot/production_order 三行(配套 Shorts_Director 卡 fix: §12 活体验证防起飞窗口误报 + liveness 指纹归一化(P1-4,ADR-0034) #111 / 退役-2/3 PR 删除对应 schema 文件)。
  • 存留: asset/event/qc_assertion/video_plan 四实体 + contracts/common glob 不变。

Copilot AI lite review requested due to automatic review settings September 1, 2026 13:54
@qodo-code-review

Copy link
Copy Markdown

ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: ff6abf81-7f20-4d11-a700-1995c97382d2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Narrow Shorts_Director entity contracts for retirement phase 2

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Removes three retired entity schemas from Shorts_Director’s governed contract declarations.
• Preserves remaining entity, shared contract, and migration policy settings.
High-Level Assessment

The explicit declaration removal is the appropriate approach because it follows ADR-0105’s synchronized policy-enumeration retirement process. Automatic schema discovery or broader glob changes would weaken explicit governance and could unintentionally alter coverage for retained entities.

Files changed (1) +0 / -3

Other (1) +0 / -3
contracts.yamlRemove retired Shorts_Director entity declarations +0/-3

Remove retired Shorts_Director entity declarations

• Removes brand_kernel, production_order, and shot schemas from Shorts_Director’s governed contracts. Retains asset, event, qc_assertion, video_plan, shared contracts, and the existing migration setting.

governance/policy/contracts.yaml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the governance contract-policy definition for Shorts_Director to reflect the ADR-0105 retirement step by narrowing the explicitly enumerated entity schema set (removing retired entities from the declared contract surface).

Changes:

  • Removed brand_kernel, shot, and production_order entity schema entries from Shorts_Director’s contracts list.
  • Kept the remaining entity schemas (asset, event, qc_assertion, video_plan) and existing globs (schema/contracts/**, schema/common/**) unchanged.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@randypanding
randypanding merged commit be96435 into main Sep 1, 2026
16 checks passed
@randypanding
randypanding deleted the policy/shorts-retire2-entities branch September 1, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants