fix: agent-registry 可见性申报修正 private→public(ADR-0019) - #62
Conversation
|
Warning Review limit reached
Next review available in: 14 minutes Limit details: You’ve used all 3 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
PR Summary by QodoCorrect agent-registry visibility declaration to public
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. agent-registry entry remains local
|
| - name: agent-registry | ||
| layer: L1 | ||
| visibility: private | ||
| visibility: public |
There was a problem hiding this comment.
1. agent-registry entry remains local 📘 Rule violation § Compliance
This change modifies the organization repository registry entry in governance/REPOS.yaml, while the checklist requires ADR and registry entries to reside in the designated agent-registry repository. Keeping the agent-registry registry record here leaves a local registry entry in the prohibited repository.
Agent Prompt
## Issue description
The PR modifies a repository-registry entry in `governance/REPOS.yaml`, but the compliance rule requires registry entries to be maintained in the designated `agent-registry` repository.
## Issue Context
The changed line is the `agent-registry` registry record whose visibility is being changed from private to public. Preserve the intended visibility correction in the designated registry repository and remove or replace the local registry entry according to the repository layout required by the organization.
## Fix Focus Areas
- governance/REPOS.yaml[34-39]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| - name: agent-registry | ||
| layer: L1 | ||
| visibility: private | ||
| visibility: public |
There was a problem hiding this comment.
2. Stale private-visibility documentation 🐞 Bug ⚙ Maintainability
Changing agent-registry to public leaves the user-facing repository map labeling it “私有” and leaves gate/drift-check comments explaining behavior on the premise that the repository is private. This contradicts the authoritative declaration and can mislead maintainers about the access model and the reason ADR existence validation is deferred.
Agent Prompt
## Issue description
`agent-registry` is now declared public, but repository documentation and validation comments still describe it as private.
## Issue Context
Update the user-facing repository table and the ADR-validation rationale so they reflect public visibility. Preserve the security rationale if it remains applicable, but do not claim that cross-repository reads are unavailable solely because the repository is private.
## Fix Focus Areas
- profile/README.md[21-21]
- .github/workflows/gate.yml[77-82]
- governance/drift-check.sh[271-276]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
superseded by #63(全仓公开政策 ADR-0020 的完整落地,本 PR 的 agent-registry 申报修正已并入)。 |
- drift-check §7a: 申报 visibility≠public 即 drift(堵 ADR-0019 式错误申报) - drift-check §7b/c: 线上全量仓合并遍历,private 即 drift(不依赖申报完整性;exempt 不豁免可见性) - governance-drift: 每日 03:00 → 每小时整点(公开仓 Actions 免费) - REPOS.yaml: agent-registry/agent-tools → public;GM-4 收录政策+frequency hourly - 取代 #62(其单点修改已并入) Co-authored-by: randypanding <randypanding@users.noreply.github.com>
摘要(GM-4 组织地图修正,决策记录:agent-registry ADR-0019)
governance/REPOS.yaml 将 agent-registry 申报为
visibility: private,与组织全公开惯例相悖(flows.new_repo --public 建仓、其余 5 仓全 public)。该错误期望状态使 owner 的 public 化操作被每日 drift-check §7a 报为漂移(2026-08-19 03:49 UTC 运行 failure 即此因)。修正:
visibility: private → public。配套:
C1 路径(governance/),引用 ADR-0019(存在性由 drift-check §10 后验)。