Skip to content

fix: agent-registry 可见性申报修正 private→public(ADR-0019) - #62

Closed
randypanding wants to merge 1 commit into
mainfrom
traefix/agent-registry-public
Closed

fix: agent-registry 可见性申报修正 private→public(ADR-0019)#62
randypanding wants to merge 1 commit into
mainfrom
traefix/agent-registry-public

Conversation

@randypanding

Copy link
Copy Markdown
Contributor

摘要(GM-4 组织地图修正,决策记录:agent-registry ADR-0019)

governance/REPOS.yaml 将 agent-registry 申报为 visibility: private,与组织全公开惯例相悖(flows.new_repo --public 建仓、其余 5 仓全 public)。该错误期望状态使 owner 的 public 化操作被每日 drift-check §7a 报为漂移(2026-08-19 03:49 UTC 运行 failure 即此因)。

修正:visibility: private → public

配套:

C1 路径(governance/),引用 ADR-0019(存在性由 drift-check §10 后验)。

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@randypanding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Limit details: You’ve used all 3 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 523206fc-5a33-4e3d-8ae1-ba707d82a103

📥 Commits

Reviewing files that changed from the base of the PR and between 26d2eef and c89ac37.

📒 Files selected for processing (1)
  • governance/REPOS.yaml

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Correct agent-registry visibility declaration to public

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Declares agent-registry as public, matching its actual repository setting.
• Prevents false visibility drift failures under governance check §7a.
• Aligns the organization map with ADR-0019 and public-repository conventions.
High-Level Assessment

Changing the declarative source of truth is the optimal approach because the repository is intentionally public under ADR-0019. Altering drift-check behavior would weaken governance validation rather than correct the inaccurate expected state.

Files changed (1) +1 / -1

Bug fix (1) +1 / -1
REPOS.yamlDeclare agent-registry as public +1/-1

Declare agent-registry as public

• Changes the active agent-registry repository visibility from private to public. This aligns the organization map with ADR-0019 and prevents drift-check §7a from flagging the public repository as mismatched.

governance/REPOS.yaml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (1) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. agent-registry entry remains local 📘 Rule violation § Compliance
Description
This change modifies the organization repository registry entry in governance/REPOS.yaml, while
the checklist requires ADR and registry entries to reside in the designated agent-registry
repository. Keeping the agent-registry registry record here leaves a local registry entry in the
prohibited repository.
Code

governance/REPOS.yaml[36]

+    visibility: public
Relevance

●●● Strong

Recent governance precedent accepts aligning C1 scope and keeping ADR-backed registry records in
agent-registry.

PR-#19
PR-#48

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The changed line is part of the local repository registry: its surrounding entry identifies
agent-registry and the file's purpose is the organization repo registry. Compliance ID 2778541
prohibits ADR documents and registry entries in this repository and requires those records to be
kept in agent-registry.

Rule 2778541: Disallow ADR documents and registry entries in this repository
governance/REPOS.yaml[34-39]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR modifies a repository-registry entry in `governance/REPOS.yaml`, but the compliance rule requires registry entries to be maintained in the designated `agent-registry` repository.

## Issue Context
The changed line is the `agent-registry` registry record whose visibility is being changed from private to public. Preserve the intended visibility correction in the designated registry repository and remove or replace the local registry entry according to the repository layout required by the organization.

## Fix Focus Areas
- governance/REPOS.yaml[34-39]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. Stale private-visibility documentation 🐞 Bug ⚙ Maintainability
Description
Changing agent-registry to public leaves the user-facing repository map labeling it “私有” and
leaves gate/drift-check comments explaining behavior on the premise that the repository is private.
This contradicts the authoritative declaration and can mislead maintainers about the access model
and the reason ADR existence validation is deferred.
Code

governance/REPOS.yaml[36]

+    visibility: public
Relevance

●●● Strong

Recent accepted governance reviews require declarations, gates, and documentation to remain
semantically consistent.

PR-#19
PR-#48

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The changed declaration says agent-registry is public, while the profile explicitly labels the
same repository private. Both the PR gate and the daily drift checker also state that
agent-registry is private as the reason ADR existence checks cannot run in the PR context; these
statements are stale after the visibility change.

governance/REPOS.yaml[34-39]
profile/README.md[17-22]
.github/workflows/gate.yml[74-82]
governance/drift-check.sh[271-276]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`agent-registry` is now declared public, but repository documentation and validation comments still describe it as private.

## Issue Context
Update the user-facing repository table and the ADR-validation rationale so they reflect public visibility. Preserve the security rationale if it remains applicable, but do not claim that cross-repository reads are unavailable solely because the repository is private.

## Fix Focus Areas
- profile/README.md[21-21]
- .github/workflows/gate.yml[77-82]
- governance/drift-check.sh[271-276]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Compliance rules (platform): 7 rules
Review mode: 🚀 Fast: 这是单个治理配置字段的局部修改,仅将 agent-registry 可见性从 private 改为 public;不涉及运行时代码、权限逻辑或多路径变更,风险明确且自包含。

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread governance/REPOS.yaml
- name: agent-registry
layer: L1
visibility: private
visibility: public

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. agent-registry entry remains local 📘 Rule violation § Compliance

This change modifies the organization repository registry entry in governance/REPOS.yaml, while
the checklist requires ADR and registry entries to reside in the designated agent-registry
repository. Keeping the agent-registry registry record here leaves a local registry entry in the
prohibited repository.
Agent Prompt
## Issue description
The PR modifies a repository-registry entry in `governance/REPOS.yaml`, but the compliance rule requires registry entries to be maintained in the designated `agent-registry` repository.

## Issue Context
The changed line is the `agent-registry` registry record whose visibility is being changed from private to public. Preserve the intended visibility correction in the designated registry repository and remove or replace the local registry entry according to the repository layout required by the organization.

## Fix Focus Areas
- governance/REPOS.yaml[34-39]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Comment thread governance/REPOS.yaml
- name: agent-registry
layer: L1
visibility: private
visibility: public

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

2. Stale private-visibility documentation 🐞 Bug ⚙ Maintainability

Changing agent-registry to public leaves the user-facing repository map labeling it “私有” and
leaves gate/drift-check comments explaining behavior on the premise that the repository is private.
This contradicts the authoritative declaration and can mislead maintainers about the access model
and the reason ADR existence validation is deferred.
Agent Prompt
## Issue description
`agent-registry` is now declared public, but repository documentation and validation comments still describe it as private.

## Issue Context
Update the user-facing repository table and the ADR-validation rationale so they reflect public visibility. Preserve the security rationale if it remains applicable, but do not claim that cross-repository reads are unavailable solely because the repository is private.

## Fix Focus Areas
- profile/README.md[21-21]
- .github/workflows/gate.yml[77-82]
- governance/drift-check.sh[271-276]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@randypanding

Copy link
Copy Markdown
Contributor Author

superseded by #63(全仓公开政策 ADR-0020 的完整落地,本 PR 的 agent-registry 申报修正已并入)。

randypanding added a commit that referenced this pull request Aug 19, 2026
- drift-check §7a: 申报 visibility≠public 即 drift(堵 ADR-0019 式错误申报)
- drift-check §7b/c: 线上全量仓合并遍历,private 即 drift(不依赖申报完整性;exempt 不豁免可见性)
- governance-drift: 每日 03:00 → 每小时整点(公开仓 Actions 免费)
- REPOS.yaml: agent-registry/agent-tools → public;GM-4 收录政策+frequency hourly
- 取代 #62(其单点修改已并入)

Co-authored-by: randypanding <randypanding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant