Skip to content

fix: workflow_call secrets 去 type 键(W0-C4 #133,ADR-0050) - #41

Merged
randypanding merged 1 commit into
mainfrom
fix-spec-author-secrets2
Aug 21, 2026
Merged

fix: workflow_call secrets 去 type 键(W0-C4 #133,ADR-0050)#41
randypanding merged 1 commit into
mainfrom
fix-spec-author-secrets2

Conversation

@randypanding

Copy link
Copy Markdown
Contributor

dispatch 422 实测:secrets 声明只接受 required/description(type 是 inputs 的字段)。这是 conductor startup_failure 的真正根因链第二环。

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@randypanding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b43a0cee-93ee-400c-9991-afd6672e5686

📥 Commits

Reviewing files that changed from the base of the PR and between be88a8d and 0535174.

📒 Files selected for processing (1)
  • .github/workflows/spec-author.yml

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix workflow_call secrets schema by removing unsupported type key

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Remove unsupported type field from workflow_call.secrets declarations to avoid dispatch 422.
• Ensure called workflow secrets validate correctly when invoked by conductor or via dispatch.
Diagram

graph TD
  A([Caller workflow]) --> B["spec-author.yml (workflow_call)"] --> C["workflow_call.secrets (required only)"]
  D([workflow_dispatch]) --> B --> E["workflow_dispatch.inputs"]
  C --> F["Job steps run"]
Loading
High-Level Assessment

This is the correct fix: workflow_call.secrets only supports required/description, so removing type aligns with GitHub Actions schema and prevents 422 validation failures. Other options (e.g., secrets: inherit) trade off security/scoping and don’t address the schema error directly.

Files changed (1) +3 / -3

Bug fix (1) +3 / -3
spec-author.ymlDrop unsupported 'type' from workflow_call secrets declarations +3/-3

Drop unsupported 'type' from workflow_call secrets declarations

• Updates the reusable workflow’s 'workflow_call.secrets' entries to remove the invalid 'type: environment' field, keeping only 'required: true'. This prevents GitHub Actions from rejecting the workflow call with 'Unexpected value 'type'' / dispatch 422.

.github/workflows/spec-author.yml

@randypanding
randypanding merged commit ea21f86 into main Aug 21, 2026
12 checks passed
@randypanding
randypanding deleted the fix-spec-author-secrets2 branch August 21, 2026 06:21
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can tweak Display preferences with a live preview to see your comment before it ships

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant