Skip to content

fix: 重试包装器检出挪到 runner.temp——ciw-scripts/ 污染调用仓 lint 扫描面(.github #94) - #44

Merged
randypanding merged 1 commit into
mainfrom
fix/v1.5.7-ciwscripts-out-of-tree
Aug 21, 2026
Merged

fix: 重试包装器检出挪到 runner.temp——ciw-scripts/ 污染调用仓 lint 扫描面(.github #94)#44
randypanding merged 1 commit into
mainfrom
fix/v1.5.7-ciwscripts-out-of-tree

Conversation

@randypanding

Copy link
Copy Markdown
Contributor

template-service 实测:prettier 扫到工作区内 ciw-scripts/ 的 26 个文件 style 告警 → make lint 必红(flaky-retry 正确判定为确定性失败)。检出挪到 $RUNNER_TEMP,工作区不再有外来文件。C1:.github/ 路径,ADR-0043 域。

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@randypanding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8eae5d6f-878f-4f8b-8404-4c09fa9480b3

📥 Commits

Reviewing files that changed from the base of the PR and between 6becd37 and a5675aa.

📒 Files selected for processing (1)
  • .github/workflows/check.yml

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix: checkout CI-Workflows scripts to RUNNER_TEMP to avoid lint pollution

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Checkout CI-Workflows retry wrapper into $RUNNER_TEMP instead of the workspace.
• Prevent caller-repo lint (e.g., Prettier) from scanning external ciw-scripts files.
• Update flaky-retry invocation path to match the new checkout location.
Diagram

graph TD
  A["Caller repo workspace"] --> B["Validate ciw-ref"] --> C["Checkout CI-Workflows"] --> D[("RUNNER_TEMP/ciw-scripts")] --> E["Run flaky-retry: make check"] --> F["Upload reports"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Ignore ciw-scripts in lint config
  • ➕ Avoids changing checkout paths and script invocation
  • ➕ Keeps all sources in the workspace for debugging
  • ➖ Requires every caller repo to update lint/prettier ignore rules
  • ➖ Easy to miss other tools that scan the workspace (future regressions)
2. Use sparse-checkout / minimal checkout content
  • ➕ Reduces scanned surface by only checking out required wrapper files
  • ➕ Keeps scripts in a deterministic location under workspace
  • ➖ More complex checkout configuration and maintenance
  • ➖ Still risks workspace scanners unless paths are consistently ignored

Recommendation: Current approach (checkout into $RUNNER_TEMP) is the most robust and caller-independent: it prevents any workspace-scanning lint/tooling from seeing external CI-Workflows files, without requiring per-repo ignore rules. Alternatives either push configuration burden to callers or add maintenance complexity.

Files changed (1) +3 / -3

Bug fix (1) +3 / -3
check.ymlMove CI-Workflows retry wrapper checkout to $RUNNER_TEMP +3/-3

Move CI-Workflows retry wrapper checkout to $RUNNER_TEMP

• Changes the secondary actions/checkout of Cloudbird-Software/CI-Workflows to use ${{ runner.temp }}/ciw-scripts instead of a workspace-relative ciw-scripts folder. Updates the flaky-retry script invocation to reference $RUNNER_TEMP so make check runs from the new location.

.github/workflows/check.yml

@randypanding
randypanding merged commit 54cc55c into main Aug 21, 2026
12 checks passed
@randypanding
randypanding deleted the fix/v1.5.7-ciwscripts-out-of-tree branch August 21, 2026 06:37
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can tweak Display preferences with a live preview to see your comment before it ships

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant