Skip to content

fix: 包装器拷出即删——checkout 拒绝工作区外路径(v1.5.7 回退修正,.github #94) - #45

Merged
randypanding merged 1 commit into
mainfrom
fix/v1.5.8-wrapper-copy-out
Aug 21, 2026
Merged

fix: 包装器拷出即删——checkout 拒绝工作区外路径(v1.5.7 回退修正,.github #94)#45
randypanding merged 1 commit into
mainfrom
fix/v1.5.8-wrapper-copy-out

Conversation

@randypanding

Copy link
Copy Markdown
Contributor

v1.5.7 的 path: ${{ runner.temp }}/... 被 checkout v7 拒绝(Repository path not under workspace)。改为工作区内检出 → 拷 flaky-retry.sh 到 RUNNER_TEMP → 删除检出目录 → 跑包装器。同时保住 template-service 的 prettier 不扫到外来文件。C1:.github/,ADR-0043 域。

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@randypanding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 575bb35f-8f3a-4a75-9441-c3430b0b825d

📥 Commits

Reviewing files that changed from the base of the PR and between 54cc55c and d76f844.

📒 Files selected for processing (1)
  • .github/workflows/check.yml

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix GitHub Actions checkout path: copy wrapper to RUNNER_TEMP then cleanup

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Checkout CI-Workflows into workspace to satisfy actions/checkout v7 path rules
• Copy flaky-retry.sh into RUNNER_TEMP, then delete the temporary checkout
• Run make check via wrapper without expanding repo lint/prettier scan scope
Diagram

graph TD
  A["check.yml"] --> B["actions/checkout\nCI-Workflows"] --> C["ciw-scripts-tmp"] --> D["flaky-retry.sh"] --> E[("RUNNER_TEMP")] --> F["bash wrapper\nmake check"]
  C -."rm -rf".-> G["cleanup tmp"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Fetch single file via raw URL (curl/wget)
  • ➕ Avoids full repo checkout and cleanup step
  • ➕ Even smaller workspace footprint
  • ➖ Must ensure strong pinning (commit SHA) and integrity checks
  • ➖ More brittle if GitHub raw URLs or paths change
2. Vendor flaky-retry.sh into this repo
  • ➕ Eliminates external dependency and checkout logic
  • ➕ Simplifies CI steps and reduces network calls
  • ➖ Requires ongoing manual sync with CI-Workflows updates
  • ➖ Risk of divergence across repos using the shared wrapper
3. Publish wrapper as a composite action
  • ➕ Reusable without manual copying/cleanup
  • ➕ Encapsulates best practices and path constraints in one place
  • ➖ Requires changes in CI-Workflows repo and versioning rollout
  • ➖ More moving parts than a simple script copy

Recommendation: Current approach is a good minimal fix: it preserves the pinned CI-Workflows source-of-truth while complying with actions/checkout v7 workspace-path constraints, and it keeps the caller repo’s lint/prettier scan surface clean by deleting the checkout immediately after copying the needed script.

Files changed (1) +8 / -3

Bug fix (1) +8 / -3
check.ymlCheckout CI-Workflows in workspace, copy wrapper to RUNNER_TEMP, then cleanup +8/-3

Checkout CI-Workflows in workspace, copy wrapper to RUNNER_TEMP, then cleanup

• Updates the CI workflow to avoid checking out into an absolute runner.temp path (rejected by actions/checkout v7). The workflow now checks out CI-Workflows into a workspace-local temp directory, copies flaky-retry.sh to RUNNER_TEMP, removes the checkout directory, and runs make check via the copied wrapper.

.github/workflows/check.yml

@randypanding
randypanding merged commit 81f5457 into main Aug 21, 2026
12 checks passed
@randypanding
randypanding deleted the fix/v1.5.8-wrapper-copy-out branch August 21, 2026 06:48
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can tweak Display preferences with a live preview to see your comment before it ships

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant