Skip to content

chore: bump node, pnpm and rollup - #40

Open
adriencaccia wants to merge 1 commit into
mainfrom
feat/optimization
Open

chore: bump node, pnpm and rollup#40
adriencaccia wants to merge 1 commit into
mainfrom
feat/optimization

Conversation

@adriencaccia

Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #40 will degrade performances by 49.54%

Comparing feat/optimization (fc8ee29) with main (c8110bd)

Summary

⚡ 29 improvements
❌ 5 regressions
✅ 26 untouched benchmarks
⁉️ 26 dropped benchmarks

⚠️Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmarkmainfeat/optimizationChange
RegExp#test14.1 µs12.2 µs+15.33%
String#indexOf10.3 µs9 µs+14.47%
switch 111.7 µs10.1 µs+16.01%
switch 212.1 µs10.4 µs+16.48%
RegExp#test14.2 µs12.4 µs+14.88%
String#indexOf10.3 µs9 µs+14.8%
switch 111.7 µs10.1 µs+16.35%
switch 212.1 µs10.4 µs+15.88%
test_iterative_fibo_1019.6 µs15 µs+30.47%
test_iterative_fibo_10019.4 µs12.3 µs+58.17%
test_recursive_cached_fibo_1025.8 µs33.3 µs-22.69%
test_recursive_cached_fibo_3047.1 µs37.6 µs+25.39%
test_recursive_fibo_1021.7 µs32 µs-32.1%
test_recursive_fibo_201.5 ms2.9 ms-49.54%
test sync baz 1019.6 µs10.1 µs+94.09%
test sync baz 10017.5 µs11.8 µs+48.51%
test_iterative_fibo_1025.1 µs20.4 µs+22.77%
test_recursive_cached_fibo_1030.9 µs36.4 µs-14.99%
test_recursive_cached_fibo_2038.2 µs31.3 µs+22.26%
test_recursive_cached_fibo_3055.4 µs42.7 µs+29.91%
...............

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Nerivec

Copy link
Copy Markdown

This should probably be revisited now that node 18 is EOL?

@adriencaccia

Copy link
Copy Markdown
MemberAuthor

This should probably be revisited now that node 18 is EOL?

Definitely, we will drop support for node 18 altogether in a upcoming major.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@adriencaccia@Nerivec