Skip to content

fix: explicitely disable instrument hooks warnings - #164

Open
art049 wants to merge 1 commit into
mainfrom
fix/instrument-hooks-options
Open

fix: explicitely disable instrument hooks warnings#164
art049 wants to merge 1 commit into
mainfrom
fix/instrument-hooks-options

Conversation

@art049

Copy link
Copy Markdown
Member

@not-matthias, we should be explicit about the warnings to ignore, skipping them all would create unseen issues
(bumped into that while building the exec-harness which needs most of those flags and we don't want to skip all warnings)

@codspeed-hq

Copy link
Copy Markdown

CodSpeed Performance Report

Merging this PR will degrade performance by 71.43%

Comparing fix/instrument-hooks-options (017f605) with main (a8754dd)

Summary

⚡ 15 improved benchmarks
❌ 6 regressed benchmarks
✅ 554 untouched benchmarks

⚠️Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

ModeBenchmarkBASEHEADEfficiency
WallTimesmall_drop2 ns1 ns×2
WallTimeiter_batched_large_input44 ns48 ns-8.33%
WallTimeiter_batched_per_iteration44 ns48 ns-8.33%
WallTimefind_highest_set_bit[1024]7 ns5 ns+40%
WallTimegenerate_combinations[5]1.3 µs1.6 µs-23.37%
WallTimegraph_coloring[4]1,097 ns974 ns+12.63%
WallTimegenerate_combinations[9]7.5 µs5.2 µs+43.26%
WallTimehamiltonian_cycle[5]1,703 ns914 ns+86.32%
WallTimehamiltonian_cycle[7]2.1 µs1.1 µs+95.76%
WallTimeadd_two_integers[(42, 13)]20 ns6 ns×3.3
WallTimeknight_tour[8]293.1 ms314.6 ms-6.85%
WallTimehamiltonian_cycle[6]1 µs1.5 µs-32.14%
WallTimehamiltonian_cycle[4]1,451 ns791 ns+83.44%
WallTimegraph_coloring[6]1.5 µs1.1 µs+32.65%
WallTimegraph_coloring[5]1.2 µs1.1 µs+12.51%
WallTimeadd_two_integers[(255, 255)]6 ns21 ns-71.43%
Simulationprocess_items_with_counter835.8 ns806.7 ns+3.62%
Simulationfind_highest_set_bit[65535]151.4 ns122.2 ns+23.86%
Simulationfind_highest_set_bit[42]151.4 ns122.2 ns+23.86%
Simulationfind_highest_set_bit[1024]151.4 ns122.2 ns+23.86%
..................

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@art049@GuillaumeLagrange@not-matthias