Uh oh!
There was an error while loading. Please reload this page.
Make the runner build on windows - #297
Draft
GuillaumeLagrange wants to merge 13 commits into
Draft
Conversation
On macos a symlink breaks the existing test creating an infinite loop where `instropected_go` detects itself as the real `go` executable. Fixed by changing the behavior to what instrospected_node does.
Fixes compilation warnings in exec-harness's build script.
…tor support gates Replaces the loose `os` + `os_version` strings on `SystemInfo` with an `Os` enum. Adds `Executor::support_level(&Os)` so each executor declares its own OS matrix: `run_executor` bails on `Unsupported`, skips `setup()` on `RequiresManualSetup`, and runs it on `FullySupported`.
These tests panic on macOS, and for now are not relevant since we do not support profiling on macOS. When we do support it, we should have os-specific tests
Had a lot of issues building directly within the shared folder, this script can be thrown away if it's no longer relevant.
`pid_t` is not available on msvc in the libc crate.
This aligns the function signature with the actual implementation.
Note: the runner is still absolutely not functional, we just have this test to avoid adding more debt passively before making it functional.
GuillaumeLagrangeforce-pushed
the
cod-2510-make-a-rust-benchmark-run-on-windows-no-wsl
branch
from
April 16, 2026 09:07
453175f to
a2f1fbbCompareGuillaumeLagrangeforce-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
4 times, most recently
from
April 16, 2026 14:43
3c21514 to
25ee001Compare
Base automatically changed from
cod-2459-be-able-to-run-all-integrations-on-macos to
mainApril 16, 2026 15:50
GuillaumeLagrange
marked this pull request as draft
June 19, 2026 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runner is still very much non functional outside of unix, this PR just does preliminary work and adds safeguards for us for when we do want to spend the time on making it run on windows.
Lower prio PR compared to the macos ones