Uh oh!
There was an error while loading. Please reload this page.
Support the pedantic API - #81
Conversation
209b49d to
57148a1Compare
adriencaccia
left a comment
There was a problem hiding this comment.
Nice!
It would make sense to test the benchmark.pedantic function in tests/test_pytest_plugin_walltime.py
84605a0 to
22d4d33Compareart049
commented
Jun 6, 2025
Yep I'll add a nominal test for both! |
57148a1 to
9e0797eCompareCodSpeed Instrumentation Performance ReportMerging #81 will not alter performanceComparing Summary
|
9e0797e to
4875846CompareCodSpeed Walltime Performance ReportMerging #81 will degrade performances by 7.67%Comparing Summary
Benchmarks breakdown
|
4875846 to
f38528dComparef38528d to
96fe457Compareflying-sheep
commented
Jul 10, 2025
Please revert the typing changes. E.g. |
| self._called = False | ||
| def __call__( | ||
| self, target: Callable[..., T], *args: tuple, **kwargs: dict[str, Any] |
There was a problem hiding this comment.
this used to be correct, now it makes no sense at all.
what you changed it to is “each positional argument is a tuple, and each keyword argument is a dict”. So this is valid according to your typing:
benchmark(print, (), (1,2), file={})but this is invalid according to your typing:
benchmark(print, "a", file="out.txt")
Fixes#77
We'll merge both after your PR @not-matthias