Adding Action Confirmations - #400

Merged
adityapat24 merged 8 commits into
mainfrom
397-dev-adding-more-action-confirmations
Apr 17, 2026
Merged

Adding Action Confirmations#400
adityapat24 merged 8 commits into
mainfrom
397-dev-adding-more-action-confirmations

Conversation

@adityapat24

@adityapat24adityapat24 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Issue

Closes#397

📝 Description

Added the action confirmation modal based on the discussed user actions

Briefly list the changes made to the code:

  1. Added modal when editing and saving grant
  2. Added to delete user profile picture
  3. Added for changing user personal information

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Frontend Testing
image
image
image
image
image

@adityapat24adityapat24 linked an issue Apr 9, 2026 that may be closed by this pull request
DEV Adding more action confirmations #397
Closed
janekamata
janekamata approved these changes Apr 9, 2026
View reviewed changes

@janekamatajanekamata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested myself by going through the different popups and everything seemed to be working

prooflesben
prooflesben requested changes Apr 11, 2026
View reviewed changes

@prooflesbenprooflesben left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people

@janetqliujanetqliu mentioned this pull request Apr 12, 2026
Closed
4 tasks
@prooflesben

prooflesben commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

Add cost missing confirmatiopn

@prooflesben

prooflesben commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

edit cost missing confirmation

@prooflesben

prooflesben commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

would love to hear opinions on this but should saving the dashbpoard data have a confirmation?

prooflesben
prooflesben requested changes Apr 15, 2026
View reviewed changes

@prooflesbenprooflesben left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing and adding a cost is missing confirmation

@janekamata

janekamata commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

would love to hear opinions on this but should saving the dashbpoard data have a confirmation?

It's not changing anything so I don't think so

@prooflesbenprooflesben linked an issue Apr 16, 2026 that may be closed by this pull request
DEV - Warn users for state-changing actions #411
Closed
4 tasks
@adityapat24
adityapat24 merged commit 2f0ce91 into mainApr 17, 2026
1 check passed
janekamata added a commit that referenced this pull request Apr 18, 2026
@janekamata
Squashed commit of the following:
d774cec
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit that referenced this pull request Apr 18, 2026
@janekamata
Squashed commit of the following:
68ad466
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit that referenced this pull request Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Sat Apr 18 00:34:03 2026 -0400
changed colors and added missing confirmations (#431)
* changed colors and added missing confirmations
* Styling fixes
* prioritize adding errors over action confirmation modal
* Updating yellow
---------
Co-authored-by: Jane Kamata <janekamata8@gmail.com>
Co-authored-by: lyannne <xu.ly@northeastern.edu>
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janekamatajanekamatajanekamata approved these changes
@prooflesbenprooflesbenprooflesben approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DEV - Warn users for state-changing actions DEV Adding more action confirmations

4 participants

@adityapat24@prooflesben@janekamata@lyannne
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Adding Action Confirmations - #400
Merged
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Apr 17, 2026
Merged
Adding Action Confirmations#400
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Conversation
@adityapat24
@adityapat24adityapat24
commented
Apr 9, 2026

Copy link


Copy Markdown

Contributor
ℹ️ Issue
Closes#397
📝 Description
Added the action confirmation modal based on the discussed user actions
Briefly list the changes made to the code:
  1. Added modal when editing and saving grant
  2. Added to delete user profile picture
  3. Added for changing user personal information
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Frontend Testing
image
image
image
image
image
@adityapat24adityapat24
linked an issue
Apr 9, 2026
that may be
closed
by this pull request


DEV Adding more action confirmations
#397

Closed

janekamata
janekamata
approved these changes
Apr 9, 2026
View reviewed changes
@janekamatajanekamata
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested myself by going through the different popups and everything seemed to be working
prooflesben
prooflesben
requested changes
Apr 11, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people
@janetqliujanetqliu
mentioned this pull request
Apr 12, 2026

Closed

4 tasks
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
Add cost missing confirmatiopn
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
edit cost missing confirmation
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
prooflesben
prooflesben
requested changes
Apr 15, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing and adding a cost is missing confirmation
@janekamata
janekamata
commented
Apr 16, 2026

Copy link


Copy Markdown

Contributor
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
It's not changing anything so I don't think so
@prooflesbenprooflesben
linked an issue
Apr 16, 2026
that may be
closed
by this pull request


DEV - Warn users for state-changing actions
#411

Closed

4 tasks
@adityapat24
adityapat24
merged commit 2f0ce91
into
mainApr 17, 2026

1 check passed

janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
d774cec
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
68ad466
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Sat Apr 18 00:34:03 2026 -0400
changed colors and added missing confirmations (#431)
* changed colors and added missing confirmations
* Styling fixes
* prioritize adding errors over action confirmation modal
* Updating yellow
---------
Co-authored-by: Jane Kamata <janekamata8@gmail.com>
Co-authored-by: lyannne <xu.ly@northeastern.edu>
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@janekamatajanekamatajanekamata approved these changes
@prooflesbenprooflesbenprooflesben approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

DEV - Warn users for state-changing actions

DEV Adding more action confirmations


4 participants

@adityapat24@prooflesben@janekamata@lyannne

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Adding Action Confirmations - #400
Merged
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Apr 17, 2026
Merged
Adding Action Confirmations#400
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Conversation
@adityapat24
@adityapat24adityapat24
commented
Apr 9, 2026

Copy link


Copy Markdown

Contributor
ℹ️ Issue
Closes#397
📝 Description
Added the action confirmation modal based on the discussed user actions
Briefly list the changes made to the code:
  1. Added modal when editing and saving grant
  2. Added to delete user profile picture
  3. Added for changing user personal information
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Frontend Testing
image
image
image
image
image
@adityapat24adityapat24
linked an issue
Apr 9, 2026
that may be
closed
by this pull request


DEV Adding more action confirmations
#397

Closed

janekamata
janekamata
approved these changes
Apr 9, 2026
View reviewed changes
@janekamatajanekamata
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested myself by going through the different popups and everything seemed to be working
prooflesben
prooflesben
requested changes
Apr 11, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people
@janetqliujanetqliu
mentioned this pull request
Apr 12, 2026

Closed

4 tasks
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
Add cost missing confirmatiopn
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
edit cost missing confirmation
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
prooflesben
prooflesben
requested changes
Apr 15, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing and adding a cost is missing confirmation
@janekamata
janekamata
commented
Apr 16, 2026

Copy link


Copy Markdown

Contributor
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
It's not changing anything so I don't think so
@prooflesbenprooflesben
linked an issue
Apr 16, 2026
that may be
closed
by this pull request


DEV - Warn users for state-changing actions
#411

Closed

4 tasks
@adityapat24
adityapat24
merged commit 2f0ce91
into
mainApr 17, 2026

1 check passed

janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
d774cec
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
68ad466
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Sat Apr 18 00:34:03 2026 -0400
changed colors and added missing confirmations (#431)
* changed colors and added missing confirmations
* Styling fixes
* prioritize adding errors over action confirmation modal
* Updating yellow
---------
Co-authored-by: Jane Kamata <janekamata8@gmail.com>
Co-authored-by: lyannne <xu.ly@northeastern.edu>
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@janekamatajanekamatajanekamata approved these changes
@prooflesbenprooflesbenprooflesben approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

DEV - Warn users for state-changing actions

DEV Adding more action confirmations


4 participants

@adityapat24@prooflesben@janekamata@lyannne

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Adding Action Confirmations - #400
Merged
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Apr 17, 2026
Merged
Adding Action Confirmations#400
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Conversation
@adityapat24
@adityapat24adityapat24
commented
Apr 9, 2026

Copy link


Copy Markdown

Contributor
ℹ️ Issue
Closes#397
📝 Description
Added the action confirmation modal based on the discussed user actions
Briefly list the changes made to the code:
  1. Added modal when editing and saving grant
  2. Added to delete user profile picture
  3. Added for changing user personal information
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Frontend Testing
image
image
image
image
image
@adityapat24adityapat24
linked an issue
Apr 9, 2026
that may be
closed
by this pull request


DEV Adding more action confirmations
#397

Closed

janekamata
janekamata
approved these changes
Apr 9, 2026
View reviewed changes
@janekamatajanekamata
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested myself by going through the different popups and everything seemed to be working
prooflesben
prooflesben
requested changes
Apr 11, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people
@janetqliujanetqliu
mentioned this pull request
Apr 12, 2026

Closed

4 tasks
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
Add cost missing confirmatiopn
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
edit cost missing confirmation
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
prooflesben
prooflesben
requested changes
Apr 15, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing and adding a cost is missing confirmation
@janekamata
janekamata
commented
Apr 16, 2026

Copy link


Copy Markdown

Contributor
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
It's not changing anything so I don't think so
@prooflesbenprooflesben
linked an issue
Apr 16, 2026
that may be
closed
by this pull request


DEV - Warn users for state-changing actions
#411

Closed

4 tasks
@adityapat24
adityapat24
merged commit 2f0ce91
into
mainApr 17, 2026

1 check passed

janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
d774cec
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
68ad466
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Sat Apr 18 00:34:03 2026 -0400
changed colors and added missing confirmations (#431)
* changed colors and added missing confirmations
* Styling fixes
* prioritize adding errors over action confirmation modal
* Updating yellow
---------
Co-authored-by: Jane Kamata <janekamata8@gmail.com>
Co-authored-by: lyannne <xu.ly@northeastern.edu>
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@janekamatajanekamatajanekamata approved these changes
@prooflesbenprooflesbenprooflesben approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

DEV - Warn users for state-changing actions

DEV Adding more action confirmations


4 participants

@adityapat24@prooflesben@janekamata@lyannne

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Adding Action Confirmations - #400
Merged
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Apr 17, 2026
Merged
Adding Action Confirmations#400
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Conversation
@adityapat24
@adityapat24adityapat24
commented
Apr 9, 2026

Copy link


Copy Markdown

Contributor
ℹ️ Issue
Closes#397
📝 Description
Added the action confirmation modal based on the discussed user actions
Briefly list the changes made to the code:
  1. Added modal when editing and saving grant
  2. Added to delete user profile picture
  3. Added for changing user personal information
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Frontend Testing
image
image
image
image
image
@adityapat24adityapat24
linked an issue
Apr 9, 2026
that may be
closed
by this pull request


DEV Adding more action confirmations
#397

Closed

janekamata
janekamata
approved these changes
Apr 9, 2026
View reviewed changes
@janekamatajanekamata
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested myself by going through the different popups and everything seemed to be working
prooflesben
prooflesben
requested changes
Apr 11, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people
@janetqliujanetqliu
mentioned this pull request
Apr 12, 2026

Closed

4 tasks
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
Add cost missing confirmatiopn
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
edit cost missing confirmation
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
prooflesben
prooflesben
requested changes
Apr 15, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing and adding a cost is missing confirmation
@janekamata
janekamata
commented
Apr 16, 2026

Copy link


Copy Markdown

Contributor
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
It's not changing anything so I don't think so
@prooflesbenprooflesben
linked an issue
Apr 16, 2026
that may be
closed
by this pull request


DEV - Warn users for state-changing actions
#411

Closed

4 tasks
@adityapat24
adityapat24
merged commit 2f0ce91
into
mainApr 17, 2026

1 check passed

janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
d774cec
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
68ad466
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Sat Apr 18 00:34:03 2026 -0400
changed colors and added missing confirmations (#431)
* changed colors and added missing confirmations
* Styling fixes
* prioritize adding errors over action confirmation modal
* Updating yellow
---------
Co-authored-by: Jane Kamata <janekamata8@gmail.com>
Co-authored-by: lyannne <xu.ly@northeastern.edu>
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@janekamatajanekamatajanekamata approved these changes
@prooflesbenprooflesbenprooflesben approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

DEV - Warn users for state-changing actions

DEV Adding more action confirmations


4 participants

@adityapat24@prooflesben@janekamata@lyannne

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Adding Action Confirmations - #400
Merged
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Apr 17, 2026
Merged
Adding Action Confirmations#400
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Conversation
@adityapat24
@adityapat24adityapat24
commented
Apr 9, 2026

Copy link


Copy Markdown

Contributor
ℹ️ Issue
Closes#397
📝 Description
Added the action confirmation modal based on the discussed user actions
Briefly list the changes made to the code:
  1. Added modal when editing and saving grant
  2. Added to delete user profile picture
  3. Added for changing user personal information
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Frontend Testing
image
image
image
image
image
@adityapat24adityapat24
linked an issue
Apr 9, 2026
that may be
closed
by this pull request


DEV Adding more action confirmations
#397

Closed

janekamata
janekamata
approved these changes
Apr 9, 2026
View reviewed changes
@janekamatajanekamata
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested myself by going through the different popups and everything seemed to be working
prooflesben
prooflesben
requested changes
Apr 11, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people
@janetqliujanetqliu
mentioned this pull request
Apr 12, 2026

Closed

4 tasks
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
Add cost missing confirmatiopn
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
edit cost missing confirmation
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
prooflesben
prooflesben
requested changes
Apr 15, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing and adding a cost is missing confirmation
@janekamata
janekamata
commented
Apr 16, 2026

Copy link


Copy Markdown

Contributor
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
It's not changing anything so I don't think so
@prooflesbenprooflesben
linked an issue
Apr 16, 2026
that may be
closed
by this pull request


DEV - Warn users for state-changing actions
#411

Closed

4 tasks
@adityapat24
adityapat24
merged commit 2f0ce91
into
mainApr 17, 2026

1 check passed

janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
d774cec
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
68ad466
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Sat Apr 18 00:34:03 2026 -0400
changed colors and added missing confirmations (#431)
* changed colors and added missing confirmations
* Styling fixes
* prioritize adding errors over action confirmation modal
* Updating yellow
---------
Co-authored-by: Jane Kamata <janekamata8@gmail.com>
Co-authored-by: lyannne <xu.ly@northeastern.edu>
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@janekamatajanekamatajanekamata approved these changes
@prooflesbenprooflesbenprooflesben approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

DEV - Warn users for state-changing actions

DEV Adding more action confirmations


4 participants

@adityapat24@prooflesben@janekamata@lyannne

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Adding Action Confirmations - #400
Merged
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Apr 17, 2026
Merged
Adding Action Confirmations#400
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Conversation
@adityapat24
@adityapat24adityapat24
commented
Apr 9, 2026

Copy link


Copy Markdown

Contributor
ℹ️ Issue
Closes#397
📝 Description
Added the action confirmation modal based on the discussed user actions
Briefly list the changes made to the code:
  1. Added modal when editing and saving grant
  2. Added to delete user profile picture
  3. Added for changing user personal information
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Frontend Testing
image
image
image
image
image
@adityapat24adityapat24
linked an issue
Apr 9, 2026
that may be
closed
by this pull request


DEV Adding more action confirmations
#397

Closed

janekamata
janekamata
approved these changes
Apr 9, 2026
View reviewed changes
@janekamatajanekamata
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested myself by going through the different popups and everything seemed to be working
prooflesben
prooflesben
requested changes
Apr 11, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people
@janetqliujanetqliu
mentioned this pull request
Apr 12, 2026

Closed

4 tasks
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
Add cost missing confirmatiopn
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
edit cost missing confirmation
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
prooflesben
prooflesben
requested changes
Apr 15, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing and adding a cost is missing confirmation
@janekamata
janekamata
commented
Apr 16, 2026

Copy link


Copy Markdown

Contributor
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
It's not changing anything so I don't think so
@prooflesbenprooflesben
linked an issue
Apr 16, 2026
that may be
closed
by this pull request


DEV - Warn users for state-changing actions
#411

Closed

4 tasks
@adityapat24
adityapat24
merged commit 2f0ce91
into
mainApr 17, 2026

1 check passed

janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
d774cec
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
68ad466
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Sat Apr 18 00:34:03 2026 -0400
changed colors and added missing confirmations (#431)
* changed colors and added missing confirmations
* Styling fixes
* prioritize adding errors over action confirmation modal
* Updating yellow
---------
Co-authored-by: Jane Kamata <janekamata8@gmail.com>
Co-authored-by: lyannne <xu.ly@northeastern.edu>
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@janekamatajanekamatajanekamata approved these changes
@prooflesbenprooflesbenprooflesben approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

DEV - Warn users for state-changing actions

DEV Adding more action confirmations


4 participants

@adityapat24@prooflesben@janekamata@lyannne

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Adding Action Confirmations - #400
Merged
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Apr 17, 2026
Merged
Adding Action Confirmations#400
adityapat24 merged 8 commits into
mainfrom 
397-dev-adding-more-action-confirmations
Conversation
@adityapat24
@adityapat24adityapat24
commented
Apr 9, 2026

Copy link


Copy Markdown

Contributor
ℹ️ Issue
Closes#397
📝 Description
Added the action confirmation modal based on the discussed user actions
Briefly list the changes made to the code:
  1. Added modal when editing and saving grant
  2. Added to delete user profile picture
  3. Added for changing user personal information
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Frontend Testing
image
image
image
image
image
@adityapat24adityapat24
linked an issue
Apr 9, 2026
that may be
closed
by this pull request


DEV Adding more action confirmations
#397

Closed

janekamata
janekamata
approved these changes
Apr 9, 2026
View reviewed changes
@janekamatajanekamata
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested myself by going through the different popups and everything seemed to be working
prooflesben
prooflesben
requested changes
Apr 11, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people
@janetqliujanetqliu
mentioned this pull request
Apr 12, 2026

Closed

4 tasks
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
Add cost missing confirmatiopn
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
edit cost missing confirmation
@prooflesben
prooflesben
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
prooflesben
prooflesben
requested changes
Apr 15, 2026
View reviewed changes
@prooflesbenprooflesben
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing and adding a cost is missing confirmation
@janekamata
janekamata
commented
Apr 16, 2026

Copy link


Copy Markdown

Contributor
would love to hear opinions on this but should saving the dashbpoard data have a confirmation?
It's not changing anything so I don't think so
@prooflesbenprooflesben
linked an issue
Apr 16, 2026
that may be
closed
by this pull request


DEV - Warn users for state-changing actions
#411

Closed

4 tasks
@adityapat24
adityapat24
merged commit 2f0ce91
into
mainApr 17, 2026

1 check passed

janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
d774cec
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
68ad466
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
janekamata added a commit
that referenced
this pull request
Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Sat Apr 18 00:34:03 2026 -0400
changed colors and added missing confirmations (#431)
* changed colors and added missing confirmations
* Styling fixes
* prioritize adding errors over action confirmation modal
* Updating yellow
---------
Co-authored-by: Jane Kamata <janekamata8@gmail.com>
Co-authored-by: lyannne <xu.ly@northeastern.edu>
commit 2f0ce91
Merge: e604a40847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Fri Apr 17 15:38:12 2026 -0400
Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations
Adding Action Confirmations
commit 847520a
Merge: b3be17be604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date: Thu Apr 16 21:58:52 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date: Thu Apr 16 21:42:44 2026 -0400
white background
commit e604a40
Merge: 5e66036e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Thu Apr 16 21:36:56 2026 -0400
Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects
update user profile updates side effects
commit ceaadd4
Merge: b2fabd45e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Wed Apr 15 22:26:16 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit 5e66036
Merge: 8dec21bfefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 18:09:59 2026 -0400
Merge pull request #429 from Code-4-Community/bug-fix-filters
Fixing filters bug
commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date: Wed Apr 15 14:15:50 2026 -0400
Fixing filters bug
commit e7803ec
Merge: e68bab48dec21b
Author: prooflesben <prooflesben@gmail.com>
Date: Wed Apr 15 13:26:37 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit 8dec21b
Merge: 6490d985d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date: Wed Apr 15 12:53:24 2026 -0400
Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well
update delete grant so it deletes notifs too
commit e68bab4
Merge: 1f208b210fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:22:05 2026 -0400
Merge branch 'main' into 396-dev-user-profile-updates-side-effects
commit b2fabd4
Merge: e2779c810fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date: Mon Apr 13 13:21:20 2026 -0400
Merge branch 'main' into 397-dev-adding-more-action-confirmations
commit e2779c8
Merge: 28ebeba2202e50
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:50:23 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:43:34 2026 -0400
action confirmations for everything and adding in colors
commit 3acea04
Merge: ff6e87e08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date: Sun Apr 12 16:24:02 2026 -0400
Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations
commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 18:31:57 2026 -0400
fixed code and tests
commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Thu Apr 9 17:46:42 2026 -0400
update user profile updates side effects
commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date: Thu Apr 9 15:15:43 2026 -0400
confirmation for needed actions
commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 20:17:31 2026 -0400
updated tests
commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date: Fri Apr 3 19:29:31 2026 -0400
update delete grant so it deletes notifs too
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@janekamatajanekamatajanekamata approved these changes
@prooflesbenprooflesbenprooflesben approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

DEV - Warn users for state-changing actions

DEV Adding more action confirmations


4 participants

@adityapat24@prooflesben@janekamata@lyannne