Admin Bugbash Fixes

[Yurika-Kan]

📝 Description

• Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
• Invalid ?donationId / ?orderId deep links show a "not found" error.
• Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
• Failed application fetches render an "Unable to Load Applications" error state.
• Application Review "View Details" uses navigate() instead of href (SPA transition).
• Cognito errors include the AWS reason and re-throw existing HttpExceptions.
• Approve Food Manufacturers pagination arrows disable at first/last page.
• Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
• User Management shows an "Admin" badge on admin rows.
• Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
• Order Management table wrapped in overflowX="auto".
• Removed dev-only "All Pages" nav link.
• Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
• Admin order table now refreshes auto after allocation edits.

[Copilot]

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

• Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
• Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
• Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing HttpExceptions and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dburkhart07]

one other thing: is the test.ico actually needed here?

[dburkhart07]

see a few slack questions in addition to this.

[dburkhart07]

We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

[jiang-h-y]

Found a new bug, where the alert state gets stale.

To reproduce:

1. Open the "Add New User" modal.
2. Enter a faulty name/email/phone number.
3. Close the modal.
4. Open the modal again, and the error message appears without filling in any fields.

[Yurika-Kan]

• Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
• Trim SignUpDto: adminCreateUser only uses fields it needs now.
• Reset isEditing: donation details modal clears edit state on close.
• Protected routes marker: comment in app.tsx flags where protected routes start.
• Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
• Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

[Copilot]

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

• The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

 @IsOptional()
@IsString()
@IsPhoneNumber('US', {
message: 'Secondary phone contact must be a valid US phone number.',
})

[Yurika-Kan]

• stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
• Filter selection now prunes itself against live options on every refetch
• Search box text now clears when filter dropdown closes

[dburkhart07]

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

[jiang-h-y]

lgtm! tested that the bugs we surfaced can no longer be reproduced

[Yurika-Kan]

📝 Description

• Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
• Invalid ?donationId / ?orderId deep links show a "not found" error.
• Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
• Failed application fetches render an "Unable to Load Applications" error state.
• Application Review "View Details" uses navigate() instead of href (SPA transition).
• Cognito errors include the AWS reason and re-throw existing HttpExceptions.
• Approve Food Manufacturers pagination arrows disable at first/last page.
• Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
• User Management shows an "Admin" badge on admin rows.
• Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
• Order Management table wrapped in overflowX="auto".
• Removed dev-only "All Pages" nav link.
• Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
• Admin order table now refreshes auto after allocation edits.

[Copilot]

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

• Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
• Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
• Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing HttpExceptions and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dburkhart07]

one other thing: is the test.ico actually needed here?

[dburkhart07]

see a few slack questions in addition to this.

[dburkhart07]

We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

[jiang-h-y]

Found a new bug, where the alert state gets stale.

To reproduce:

1. Open the "Add New User" modal.
2. Enter a faulty name/email/phone number.
3. Close the modal.
4. Open the modal again, and the error message appears without filling in any fields.

[Yurika-Kan]

• Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
• Trim SignUpDto: adminCreateUser only uses fields it needs now.
• Reset isEditing: donation details modal clears edit state on close.
• Protected routes marker: comment in app.tsx flags where protected routes start.
• Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
• Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

[Copilot]

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

• The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

 @IsOptional()
@IsString()
@IsPhoneNumber('US', {
message: 'Secondary phone contact must be a valid US phone number.',
})

[Yurika-Kan]

• stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
• Filter selection now prunes itself against live options on every refetch
• Search box text now clears when filter dropdown closes

[dburkhart07]

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

[jiang-h-y]

lgtm! tested that the bugs we surfaced can no longer be reproduced

[Yurika-Kan]

📝 Description

• Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
• Invalid ?donationId / ?orderId deep links show a "not found" error.
• Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
• Failed application fetches render an "Unable to Load Applications" error state.
• Application Review "View Details" uses navigate() instead of href (SPA transition).
• Cognito errors include the AWS reason and re-throw existing HttpExceptions.
• Approve Food Manufacturers pagination arrows disable at first/last page.
• Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
• User Management shows an "Admin" badge on admin rows.
• Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
• Order Management table wrapped in overflowX="auto".
• Removed dev-only "All Pages" nav link.
• Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
• Admin order table now refreshes auto after allocation edits.

[Copilot]

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

• Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
• Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
• Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing HttpExceptions and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dburkhart07]

one other thing: is the test.ico actually needed here?

[dburkhart07]

see a few slack questions in addition to this.

[dburkhart07]

We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

[jiang-h-y]

Found a new bug, where the alert state gets stale.

To reproduce:

1. Open the "Add New User" modal.
2. Enter a faulty name/email/phone number.
3. Close the modal.
4. Open the modal again, and the error message appears without filling in any fields.

[Yurika-Kan]

• Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
• Trim SignUpDto: adminCreateUser only uses fields it needs now.
• Reset isEditing: donation details modal clears edit state on close.
• Protected routes marker: comment in app.tsx flags where protected routes start.
• Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
• Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

[Copilot]

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

• The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

 @IsOptional()
@IsString()
@IsPhoneNumber('US', {
message: 'Secondary phone contact must be a valid US phone number.',
})

[Yurika-Kan]

• stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
• Filter selection now prunes itself against live options on every refetch
• Search box text now clears when filter dropdown closes

[dburkhart07]

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

[jiang-h-y]

lgtm! tested that the bugs we surfaced can no longer be reproduced

[Yurika-Kan]

📝 Description

• Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
• Invalid ?donationId / ?orderId deep links show a "not found" error.
• Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
• Failed application fetches render an "Unable to Load Applications" error state.
• Application Review "View Details" uses navigate() instead of href (SPA transition).
• Cognito errors include the AWS reason and re-throw existing HttpExceptions.
• Approve Food Manufacturers pagination arrows disable at first/last page.
• Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
• User Management shows an "Admin" badge on admin rows.
• Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
• Order Management table wrapped in overflowX="auto".
• Removed dev-only "All Pages" nav link.
• Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
• Admin order table now refreshes auto after allocation edits.

[Copilot]

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

• Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
• Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
• Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing HttpExceptions and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dburkhart07]

one other thing: is the test.ico actually needed here?

[dburkhart07]

see a few slack questions in addition to this.

[dburkhart07]

We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

[jiang-h-y]

Found a new bug, where the alert state gets stale.

To reproduce:

1. Open the "Add New User" modal.
2. Enter a faulty name/email/phone number.
3. Close the modal.
4. Open the modal again, and the error message appears without filling in any fields.

[Yurika-Kan]

• Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
• Trim SignUpDto: adminCreateUser only uses fields it needs now.
• Reset isEditing: donation details modal clears edit state on close.
• Protected routes marker: comment in app.tsx flags where protected routes start.
• Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
• Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

[Copilot]

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

• The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

 @IsOptional()
@IsString()
@IsPhoneNumber('US', {
message: 'Secondary phone contact must be a valid US phone number.',
})

[Yurika-Kan]

• stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
• Filter selection now prunes itself against live options on every refetch
• Search box text now clears when filter dropdown closes

[dburkhart07]

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

[jiang-h-y]

lgtm! tested that the bugs we surfaced can no longer be reproduced

[Yurika-Kan]

📝 Description

• Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
• Invalid ?donationId / ?orderId deep links show a "not found" error.
• Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
• Failed application fetches render an "Unable to Load Applications" error state.
• Application Review "View Details" uses navigate() instead of href (SPA transition).
• Cognito errors include the AWS reason and re-throw existing HttpExceptions.
• Approve Food Manufacturers pagination arrows disable at first/last page.
• Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
• User Management shows an "Admin" badge on admin rows.
• Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
• Order Management table wrapped in overflowX="auto".
• Removed dev-only "All Pages" nav link.
• Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
• Admin order table now refreshes auto after allocation edits.

[Copilot]

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

• Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
• Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
• Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing HttpExceptions and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dburkhart07]

one other thing: is the test.ico actually needed here?

[dburkhart07]

see a few slack questions in addition to this.

[dburkhart07]

We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

[jiang-h-y]

Found a new bug, where the alert state gets stale.

To reproduce:

1. Open the "Add New User" modal.
2. Enter a faulty name/email/phone number.
3. Close the modal.
4. Open the modal again, and the error message appears without filling in any fields.

[Yurika-Kan]

• Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
• Trim SignUpDto: adminCreateUser only uses fields it needs now.
• Reset isEditing: donation details modal clears edit state on close.
• Protected routes marker: comment in app.tsx flags where protected routes start.
• Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
• Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

[Copilot]

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

• The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

 @IsOptional()
@IsString()
@IsPhoneNumber('US', {
message: 'Secondary phone contact must be a valid US phone number.',
})

[Yurika-Kan]

• stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
• Filter selection now prunes itself against live options on every refetch
• Search box text now clears when filter dropdown closes

[dburkhart07]

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

[jiang-h-y]

lgtm! tested that the bugs we surfaced can no longer be reproduced

[Yurika-Kan]

📝 Description

• Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
• Invalid ?donationId / ?orderId deep links show a "not found" error.
• Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
• Failed application fetches render an "Unable to Load Applications" error state.
• Application Review "View Details" uses navigate() instead of href (SPA transition).
• Cognito errors include the AWS reason and re-throw existing HttpExceptions.
• Approve Food Manufacturers pagination arrows disable at first/last page.
• Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
• User Management shows an "Admin" badge on admin rows.
• Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
• Order Management table wrapped in overflowX="auto".
• Removed dev-only "All Pages" nav link.
• Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
• Admin order table now refreshes auto after allocation edits.

[Copilot]

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

• Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
• Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
• Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing HttpExceptions and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dburkhart07]

one other thing: is the test.ico actually needed here?

[dburkhart07]

see a few slack questions in addition to this.

[dburkhart07]

We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

[jiang-h-y]

Found a new bug, where the alert state gets stale.

To reproduce:

1. Open the "Add New User" modal.
2. Enter a faulty name/email/phone number.
3. Close the modal.
4. Open the modal again, and the error message appears without filling in any fields.

[Yurika-Kan]

• Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
• Trim SignUpDto: adminCreateUser only uses fields it needs now.
• Reset isEditing: donation details modal clears edit state on close.
• Protected routes marker: comment in app.tsx flags where protected routes start.
• Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
• Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

[Copilot]

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

• The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

 @IsOptional()
@IsString()
@IsPhoneNumber('US', {
message: 'Secondary phone contact must be a valid US phone number.',
})

[Yurika-Kan]

• stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
• Filter selection now prunes itself against live options on every refetch
• Search box text now clears when filter dropdown closes

[dburkhart07]

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

[jiang-h-y]

lgtm! tested that the bugs we surfaced can no longer be reproduced

[Yurika-Kan]

📝 Description

• Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
• Invalid ?donationId / ?orderId deep links show a "not found" error.
• Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
• Failed application fetches render an "Unable to Load Applications" error state.
• Application Review "View Details" uses navigate() instead of href (SPA transition).
• Cognito errors include the AWS reason and re-throw existing HttpExceptions.
• Approve Food Manufacturers pagination arrows disable at first/last page.
• Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
• User Management shows an "Admin" badge on admin rows.
• Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
• Order Management table wrapped in overflowX="auto".
• Removed dev-only "All Pages" nav link.
• Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
• Admin order table now refreshes auto after allocation edits.

[Copilot]

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

• Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
• Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
• Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing HttpExceptions and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dburkhart07]

one other thing: is the test.ico actually needed here?

[dburkhart07]

see a few slack questions in addition to this.

[dburkhart07]

We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

[jiang-h-y]

Found a new bug, where the alert state gets stale.

To reproduce:

1. Open the "Add New User" modal.
2. Enter a faulty name/email/phone number.
3. Close the modal.
4. Open the modal again, and the error message appears without filling in any fields.

[Yurika-Kan]

• Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
• Trim SignUpDto: adminCreateUser only uses fields it needs now.
• Reset isEditing: donation details modal clears edit state on close.
• Protected routes marker: comment in app.tsx flags where protected routes start.
• Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
• Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

[Copilot]

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

• The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

 @IsOptional()
@IsString()
@IsPhoneNumber('US', {
message: 'Secondary phone contact must be a valid US phone number.',
})

[Yurika-Kan]

• stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
• Filter selection now prunes itself against live options on every refetch
• Search box text now clears when filter dropdown closes

[dburkhart07]

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

[jiang-h-y]

lgtm! tested that the bugs we surfaced can no longer be reproduced

[Yurika-Kan]

📝 Description

• Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
• Invalid ?donationId / ?orderId deep links show a "not found" error.
• Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
• Failed application fetches render an "Unable to Load Applications" error state.
• Application Review "View Details" uses navigate() instead of href (SPA transition).
• Cognito errors include the AWS reason and re-throw existing HttpExceptions.
• Approve Food Manufacturers pagination arrows disable at first/last page.
• Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
• User Management shows an "Admin" badge on admin rows.
• Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
• Order Management table wrapped in overflowX="auto".
• Removed dev-only "All Pages" nav link.
• Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
• Admin order table now refreshes auto after allocation edits.

[Copilot]

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

• Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
• Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
• Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing HttpExceptions and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dburkhart07]

one other thing: is the test.ico actually needed here?

[dburkhart07]

see a few slack questions in addition to this.

[dburkhart07]

We now have an issue that, if the user is already logged in, and is supposed to be brought straight to the profile page (one that depends entirely on backend data, unlike the homepage we used to have), itll take 30 seconds for the backend to startup before the user can actually see details on it (right now it just says No Profile Found until then). Im not sure if there is a workaround for this (or maybe its not a big deal since in theory the backend will be permanently running when its in production), but wanted to ask.

[jiang-h-y]

Found a new bug, where the alert state gets stale.

To reproduce:

1. Open the "Add New User" modal.
2. Enter a faulty name/email/phone number.
3. Close the modal.
4. Open the modal again, and the error message appears without filling in any fields.

[Yurika-Kan]

• Retry profile fetch: cold backend no longer sticks "not found" forever, retries first.
• Trim SignUpDto: adminCreateUser only uses fields it needs now.
• Reset isEditing: donation details modal clears edit state on close.
• Protected routes marker: comment in app.tsx flags where protected routes start.
• Search in filter dropdowns: manufacturer/pantry filters get search box (adminDonation, approveFoodManufacturers, approvePantries).
• Hide edit/delete on reserved donations: donationDetailsModal hides edit/delete when items have reserved quantity.

[Copilot]

Pull request overview

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts:41

• The updated validation copy here uses "Secondary phone contact…", but other updated DTOs in this PR use the shorter "Secondary phone…" phrasing. For consistency (and clearer UX), align this message with the others (e.g., "Secondary phone must be a valid US phone number.").

 @IsOptional()
@IsString()
@IsPhoneNumber('US', {
message: 'Secondary phone contact must be a valid US phone number.',
})

[Yurika-Kan]

• stale manufacturer filter stuck showing "No donations match filter" after last matching donation deleted
• Filter selection now prunes itself against live options on every refetch
• Search box text now clears when filter dropdown closes

[dburkhart07]

Admin and Volunteer Food Request Management Filter still needs the search added to it, but aside from this looks great!!!

[jiang-h-y]

lgtm! tested that the bugs we surfaced can no longer be reproduced