Uh oh!
There was an error while loading. Please reload this page.
Move codeigniter4/framework to require-dev - #33
Conversation
To avoid dependabot error in CodeIgniter 4 repo, see https://github.com/codeigniter4/CodeIgniter4/network/updates/953278072
samsonasik
commented
Jan 24, 2025
/cc @paulbalandan |
paulbalandan
commented
Jan 24, 2025
I'm currently understanding the issue, but sure let's merge this for now. |
samsonasik
commented
Jan 24, 2025
I added to conflict for avoid install before 4.5 |
paulbalandan
commented
Jan 24, 2025
Can you tell me why? |
samsonasik
commented
Jan 24, 2025
this ensure current check equal, but it still installable on CodeIgniter 4, if user try to install in codeigniter <4.5, it can't, but doesn't necessarily to require it. this is what I do on my module, eg can use opt in doctrine functinality, but when user do, user needs to use specific doctrine version Of course, I can revert it if it doesn't necessarily needed. |
samsonasik
commented
Jan 24, 2025
it may related with self.version usage on CodeIgniter4 repo https://github.com/codeigniter4/CodeIgniter4/blob/b5e9715518186a9f4a98deeac1587b1131d01f8b/composer.json#L35 |
samsonasik
commented
Jan 24, 2025
@paulbalandan do you think conflict config is not needed for codeigniter 4.5 ? |
paulbalandan
commented
Jan 24, 2025
The move to I'll merge this let's see what happens. |
To avoid dependabot error in CodeIgniter 4 repo, see https://github.com/codeigniter4/CodeIgniter4/network/updates/953278072