Skip to content

Updating Tester address - #173

Merged
zpChris merged 8 commits into
mainfrom
updatingTesterAddress
Jun 22, 2021
Merged

Updating Tester address#173
zpChris merged 8 commits into
mainfrom
updatingTesterAddress

Conversation

@jasonz6688

@jasonz6688jasonz6688 commented Jun 19, 2021

Copy link
Copy Markdown
Contributor

List of Changes:

  • Updated the Tester address to match the new VM instance setup.
  • Updated the landing page "Link Copied!" text to "Email Copied!" to match the action.
  • Fix the My Account dropdown "Logout" field on the Join and Create Game pages.
  • Fix the filter problem functionality with duplicates in the list.

Notes:

  • This PR fixes the issue where the Tester repository was not accessible; I think when we renewed our GCP setup, the Tester address for the VM instance got updated.

Screencast and Images:

There are no screencasts or images attached as there are no updates to the UI.

@jasonz6688
jasonz6688 requested a review from zpChrisJune 19, 2021 23:01
@zpChriszpChris changed the title updating tester addressUpdating Tester addressJun 19, 2021
@zpChris

zpChris commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

I'm dealing with two others issues, which I may try to fix on this PR or another.

  1. The "My Account" dropdown on the Join Game page does not allow the user to Logout.
  2. The filter problem functionality on the frontend lobby page fails.
    • I will likely make a screencast for this and create a new branch / PR for this fix.

@zpChris

Copy link
Copy Markdown
Contributor

I fixed the first issue above, but not yet the second.

@zpChriszpChris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made most of the changes on this PR, but since they're all pretty obvious and were referenced by @alankbi, I'll approve and merge this in 👍

@zpChris

zpChris commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

I've also fixed the second problem as well - the issue was that the verified and account problems are combined but the list is not de-duplicated, so since the keys are not unique, the frontend runs into some strange problems (pun intended).

The first video below shows the original issue, and the second video shows when it is fixed.

Problems Filter Bug
Screencast of the Problems Filter Bug

Problems Filter List
Screencast of the Problems Filter List

@alankbialankbi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@zpChris
zpChris merged commit b4776b8 into mainJun 22, 2021
@zpChris
zpChris deleted the updatingTesterAddress branch June 22, 2021 13:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jasonz6688@zpChris@alankbi